[mythtv-commits] [MythTV/mythtv] a448cb: Avoid calling RemoveAllPIDFilters() when using Vch...

[Steve Erlenborn]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: a448cbea12bc58202878af6e82680791899cd021
      https://github.com/MythTV/mythtv/commit/a448cbea12bc58202878af6e82680791899cd021
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2024-06-01 (Sat, 01 Jun 2024)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp

  Log Message:
  -----------
  Avoid calling RemoveAllPIDFilters() when using Vchan tuning

The first step is to improve the error messages. In two places
the "UpdateFilters called in wrong tune mode" message has been
updated to specify the value of the wrong tune mode.

After this update, an example of the error message is:

 mythbackend: mythbackend[779282]: E HDHRStreamHandleri
   hdhrstreamhandler.cpp:242 (UpdateFilters) HDHRSH[4](13249773):i
   UpdateFilters called in wrong tune mode, 4

>From this, we know that the tune mode was hdhrTuneModeVChannel.
We know that UpdateFilters was called, but in hdhrstreamhandler.cpp,
the only call to it is avoided for Vchan tuning.

108 void HDHRStreamHandler::run(void)
...
140             UpdateFiltersFromStreamData();
141             if (m_tuneMode != hdhrTuneModeVChannel)
142                 UpdateFilters();

Code examination revealed that the offending invocation of
UpdateFilters() is in RemoveAllPIDFilters().

This routine is called unconditionally in

108 void HDHRStreamHandler::run(void)
...
183     LOG(VB_RECORD, LOG_INFO, LOC + "RunTS(): " + "shutdown");
184
185     RemoveAllPIDFilters();

The solution is to condition the call to RemoveAllPIDFilters()
in the same way the call to UpdateFilters() was previously
conditioned. If we're using Virtual Channel Tuning, then don't
bother removing filters which were never created in the first
place.

Resolves #905



To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications