[mythtv-commits] [MythTV/mythtv] 388715: libmythbase/logging.cpp: silence -Wunused-result

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 388715dbf89939d15432266c02ac7b923b30f84f
      https://github.com/MythTV/mythtv/commit/388715dbf89939d15432266c02ac7b923b30f84f
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/logging.cpp

  Log Message:
  -----------
  libmythbase/logging.cpp: silence -Wunused-result

by replacing the write system call, which may only partially write,
with the C++ standard iostreams.


  Commit: a3025d3914ef65ff4295218aff027b8a79b397f1
      https://github.com/MythTV/mythtv/commit/a3025d3914ef65ff4295218aff027b8a79b397f1
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythbase/loggingserver.h

  Log Message:
  -----------
  LoggerBase: make this not a QObject

which it doesn't need to be.


  Commit: fa67582a454d09eb485f9185873989e1e8f97f95
      https://github.com/MythTV/mythtv/commit/fa67582a454d09eb485f9185873989e1e8f97f95
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythbase/loggingserver.h

  Log Message:
  -----------
  FileLogger: convert to C++ I/O

The POSIX write() system call may truncate the output.  The proper
way to use it is in a loop.

Instead, use the high level C++ STL I/O.

The Boost library would be needed to keep using the open() and close()
system calls, i.e. to wrap a FILE* with an iostream.

I don't see a way via the C++ STL ofstream to set the Unix file
permissions.  However, it seems to default to the previously
specified 0664.

I'm not sure how to test that FileLogger::reopen() actually works
with a log roller, but it should be equivalent.


  Commit: 6e6d60dec442dcfe7759e8261f7c99ce727a9070
      https://github.com/MythTV/mythtv/commit/6e6d60dec442dcfe7759e8261f7c99ce727a9070
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/logging.h
    M mythtv/libs/libmythbase/loggingserver.cpp

  Log Message:
  -----------
  logging: deduplicate string formating

between console and file logging.

The new shared long log format is the logConsole format.


  Commit: 6a9d6a744548b4d2da6334ef7cdfaa973b63a326
      https://github.com/MythTV/mythtv/commit/6a9d6a744548b4d2da6334ef7cdfaa973b63a326
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/logging.h
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythlogging.h
    M mythtv/libs/libmythbase/test/test_logging/test_logging.cpp

  Log Message:
  -----------
  logging: add option to print long log format to console


  Commit: 3bb26bac524b5c4bef2aac68b545d4a04e3a2554
      https://github.com/MythTV/mythtv/commit/3bb26bac524b5c4bef2aac68b545d4a04e3a2554
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/configure
    M mythtv/libs/libmythbase/logging.cpp

  Log Message:
  -----------
  logging, configure: add option to always force the long log format


  Commit: 0c4674db7cd537477f6072a8ea1522eada9e2319
      https://github.com/MythTV/mythtv/commit/0c4674db7cd537477f6072a8ea1522eada9e2319
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/verbosedefs.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  add LOG_TRACE

Initially for compatibility with FFmpeg's log levels, but should also be
useful in MythTV.


  Commit: 4d1ffd47d9565abf74ca1158ebaed87246f53486
      https://github.com/MythTV/mythtv/commit/4d1ffd47d9565abf74ca1158ebaed87246f53486
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-10-07 (Mon, 07 Oct 2024)

  Changed paths:
    M cmake/MythOptions.cmake
    M mythtv/libs/libmythbase/mythconfig.h.in

  Log Message:
  -----------
  Add cmake option to always force the long log format.


  Commit: 2a8ab8f58e2906a791fdaae64bfbec20d527cfd3
      https://github.com/MythTV/mythtv/commit/2a8ab8f58e2906a791fdaae64bfbec20d527cfd3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2024-12-30 (Mon, 30 Dec 2024)

  Changed paths:
    M cmake/MythOptions.cmake
    M mythtv/configure
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/logging.h
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythbase/loggingserver.h
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythconfig.h.in
    M mythtv/libs/libmythbase/mythlogging.h
    M mythtv/libs/libmythbase/test/test_logging/test_logging.cpp
    M mythtv/libs/libmythbase/verbosedefs.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  Merge pull request #604 from ulmus-scott/logging

Logging cleanup and add options to force long console log format


Compare: https://github.com/MythTV/mythtv/compare/5c887163422c...2a8ab8f58e29

To unsubscribe from these emails, change your notification settings at https://github.com/MythTV/mythtv/settings/notifications