[mythtv-commits] [MythTV/mythtv] 8e54a5: tidy: Explicitly convert variables to be the same ...

David Hampton noreply at github.com
Wed May 31 03:36:07 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 8e54a58d5d4d371c93612fed6ac900130f96eca9
      https://github.com/MythTV/mythtv/commit/8e54a58d5d4d371c93612fed6ac900130f96eca9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h

  Log Message:
  -----------
  tidy: Explicitly convert variables to be the same width as a pointer.

Convert some "uint" variables/arguments to be "size_t".  This
eliminates warnings about the implicit widening of a multiplication
result on 64-bit cpu where "uint" is a 32-bit value.


  Commit: 3fe5de0686c0a20cef76b8e52dd99630f3eb19a4
      https://github.com/MythTV/mythtv/commit/3fe5de0686c0a20cef76b8e52dd99630f3eb19a4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  tidy: Update notes for disabled clang-tidy tests.


  Commit: 864e03140e15f335574e04b5ad560560e969bca4
      https://github.com/MythTV/mythtv/commit/864e03140e15f335574e04b5ad560560e969bca4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  tidy: Track changing test name.


  Commit: d34c1995efeac6a7625221a4d9bea812e3839088
      https://github.com/MythTV/mythtv/commit/d34c1995efeac6a7625221a4d9bea812e3839088
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-05-30 (Tue, 30 May 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/visualize.cpp
    M mythtv/programs/mythtranscode/external/replex/multiplex.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.cpp

  Log Message:
  -----------
  tidy: Explicitly convert variables to be the same width as a pointer.

In the case of a CPU with a 32-bit integer and a 64-bit pointer, this
eliminates warnings about the implicit widening of a multiplication
result.  Calculations should always widen first and then multiply to
prevent an overflow of the smaller sized type.


Compare: https://github.com/MythTV/mythtv/compare/19abde0f2ee1...d34c1995efea


More information about the mythtv-commits mailing list