[mythtv-commits] [MythTV/mythtv] f2a964: Fix detection of optical drives

hambre noreply at github.com
Thu Mar 30 19:00:20 UTC 2023


  Branch: refs/heads/fixes/33
  Home:   https://github.com/MythTV/mythtv
  Commit: f2a964ed814a08d8a3016e5b0b1f0979e4586360
      https://github.com/MythTV/mythtv/commit/f2a964ed814a08d8a3016e5b0b1f0979e4586360
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Fix detection of optical drives

Checking for mount points is not reliable to determine if a block device
is an optical drive. This commit uses the 'MediaCompatibility' property
of the 'org.freedesktop.UDisks2.Drive' DBUS interface to check if the
drive supports optical media.
Also changes the function name in the log messages to match the function
they are called from.

(cherry picked from commit 998669de6114706d0459214ecc030aed7489afab)


  Commit: 44b1ac1d59aff9b9e4340e9a693a0e7a2b3e0799
      https://github.com/MythTV/mythtv/commit/44b1ac1d59aff9b9e4340e9a693a0e7a2b3e0799
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Remove checking 'ReadOnly' drive property

When checking if a drive is an optical drive, rely only on the
'MediaCompatibility' property and not the 'ReadOnly' property
of the 'org.freedesktop.UDisks2.Drive' interface.

(cherry picked from commit 9957ffab6c452c373bc60a1b9b9c3a3212d4f8f0)


  Commit: 0682d4d42dd50ad8592c522fe39fc8a81a11ee59
      https://github.com/MythTV/mythtv/commit/0682d4d42dd50ad8592c522fe39fc8a81a11ee59
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Cleanup function 'DetectDevice'

Remove dead code which is not going to be used anymore

(cherry picked from commit 80b4911f15324440fbd04c3580922463f87a2ae1)


Compare: https://github.com/MythTV/mythtv/compare/142a8e070841...0682d4d42dd5


More information about the mythtv-commits mailing list