[mythtv-commits] [MythTV/mythtv] 09c82a: Remove std::move from Service API macro

Peter Bennett noreply at github.com
Tue Mar 28 13:52:06 UTC 2023

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 09c82a11a19cc6250b807443ce054daa7141bd33
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2023-03-28 (Tue, 28 Mar 2023)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.h
    M mythtv/programs/mythbackend/servicesv2/v2myth.cpp

  Log Message:
  Remove std::move from Service API macro

std::move is dangerous to use without careful analysis. It causes the
original value to be cleared. This resulted in a problem with
Myth/GetBackendInfo and may cause unexpected problems with other API
methods. Removing it from the macro removes it from all API value
setting and causes an assignment to be done instead.

This commit also reverts commit c92362e , which was a workaround fix
for Myth/GetBackendInfo.

Fixes #739

More information about the mythtv-commits mailing list