[mythtv-commits] [MythTV/mythtv] 832c4c: cmake: Compile dvbdescriptors.cpp on win32.

David Hampton noreply at github.com
Tue Mar 28 01:06:34 UTC 2023

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 832c4caba4f678f4f2e29f56687ccc0a533e8f8a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp

  Log Message:
  cmake: Compile dvbdescriptors.cpp on win32.

By default, the iconv headers make the second argument to iconv() a
"const char **". Unfortunately the compiler will not implicitly cast
the "char **" used by this file into that type.  Add the define so
that the type on windows is "char **" to match our usage.  This define
has no effect on other systems.

  Commit: 99479ddfa86efed75c91d2dfc142fe22159210bd
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp

  Log Message:
  cmake: Fix warning about  narrowing in an initializer list.

The compiler is complaining that it can't narrow a value from type
"long long" to "long" in an initializer list.  Given that this code is
using milliseconds, then by definition the return value of the count()
function contains at least 45 bits, and is probably always a int64_t.
The timestamp tv_nsec field (a long) can be either 32 or 64 bits
depending on the definition of "long" on the platform.  Add an
intermediate variable so that the compiler can perform the narrowing
outside of an initializer, and thus doesn't complain.

Compare: https://github.com/MythTV/mythtv/compare/80b4911f1532...99479ddfa86e

More information about the mythtv-commits mailing list