[mythtv-commits] [MythTV/mythtv] 998669: Fix detection of optical drives

hambre noreply at github.com
Mon Mar 27 21:33:31 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 998669de6114706d0459214ecc030aed7489afab
      https://github.com/MythTV/mythtv/commit/998669de6114706d0459214ecc030aed7489afab
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Fix detection of optical drives

Checking for mount points is not reliable to determine if a block device
is an optical drive. This commit uses the 'MediaCompatibility' property
of the 'org.freedesktop.UDisks2.Drive' DBUS interface to check if the
drive supports optical media.
Also changes the function name in the log messages to match the function
they are called from.


  Commit: 9957ffab6c452c373bc60a1b9b9c3a3212d4f8f0
      https://github.com/MythTV/mythtv/commit/9957ffab6c452c373bc60a1b9b9c3a3212d4f8f0
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Remove checking 'ReadOnly' drive property

When checking if a drive is an optical drive, rely only on the
'MediaCompatibility' property and not the 'ReadOnly' property
of the 'org.freedesktop.UDisks2.Drive' interface.


  Commit: 80b4911f15324440fbd04c3580922463f87a2ae1
      https://github.com/MythTV/mythtv/commit/80b4911f15324440fbd04c3580922463f87a2ae1
  Author: Jan Hambrecht <jaham at gmx.net>
  Date:   2023-03-27 (Mon, 27 Mar 2023)

  Changed paths:
    M mythtv/libs/libmyth/mediamonitor-unix.cpp

  Log Message:
  -----------
  Cleanup function 'DetectDevice'

Remove dead code which is not going to be used anymore


Compare: https://github.com/MythTV/mythtv/compare/ec863c537b69...80b4911f1532


More information about the mythtv-commits mailing list