[mythtv-commits] [MythTV/mythtv] f6a7f2: tidy: Convert all variables of type QEvent::Type t...

Mon Jun 26 17:45:23 UTC 2023

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: f6a7f2820a6ea35fd8b4511582feef00e1bbce48
      https://github.com/MythTV/mythtv/commit/f6a7f2820a6ea35fd8b4511582feef00e1bbce48
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.h
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/decoder.h
    M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
    M mythplugins/mythmusic/mythmusic/decoderhandler.h
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.h
    M mythtv/libs/libmyth/output.cpp
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/mythevent.cpp
    M mythtv/libs/libmythbase/mythevent.h
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmedia.h
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.h
    M mythtv/libs/libmythmetadata/metadatafactory.cpp
    M mythtv/libs/libmythmetadata/metadatafactory.h
    M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
    M mythtv/libs/libmythmetadata/metadataimagedownload.h
    M mythtv/libs/libmythmetadata/videoscan.cpp
    M mythtv/libs/libmythmetadata/videoscan.h
    M mythtv/libs/libmythtv/channelscan/scanmonitor.cpp
    M mythtv/libs/libmythtv/channelscan/scanmonitor.h
    M mythtv/libs/libmythui/devices/jsmenuevent.cpp
    M mythtv/libs/libmythui/devices/jsmenuevent.h
    M mythtv/libs/libmythui/devices/lircevent.cpp
    M mythtv/libs/libmythui/devices/lircevent.h
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythgesture.cpp
    M mythtv/libs/libmythui/mythgesture.h
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/mythnotificationcenter.h
    M mythtv/libs/libmythui/mythprogressdialog.cpp
    M mythtv/libs/libmythui/mythprogressdialog.h
    M mythtv/libs/libmythui/mythscreentype.cpp
    M mythtv/libs/libmythui/mythscreentype.h
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.h
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h

  Log Message:
  -----------
  tidy: Convert all variables of type QEvent::Type to be const.

These values should never change once they are initialized.  Marking
them const allow the compiler to enforce that constraint.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.html

  Commit: 4c664724576598f11fa8a4263109d2489b21c951
      https://github.com/MythTV/mythtv/commit/4c664724576598f11fa8a4263109d2489b21c951
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M mythtv/libs/libmythui/mythnotification.cpp
    M mythtv/libs/libmythui/mythnotification.h

  Log Message:
  -----------
  tidy: Convert mythnotification variables of type QEvent::Type to be const.

These values should never change once they are initialized.  Marking
them const allow the compiler to enforce that constraint.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables.html

  Commit: 9a0ddd021eae05715892c8c23e1b38670c539a7b
      https://github.com/MythTV/mythtv/commit/9a0ddd021eae05715892c8c23e1b38670c539a7b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/cddecoder.cpp
    M mythplugins/mythmusic/mythmusic/cddecoder.h
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/decoder.h
    M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
    M mythplugins/mythmusic/mythmusic/decoderhandler.h
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/lyricsview.cpp
    M mythplugins/mythmusic/mythmusic/mainvisual.cpp
    M mythplugins/mythmusic/mythmusic/musiccommon.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.h
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
    M mythplugins/mythmusic/mythmusic/searchview.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythplugins/mythmusic/mythmusic/visualizerview.cpp
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp
    M mythplugins/mythnews/mythnews/newssite.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputjack.cpp
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/output.cpp
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/http/mythwebsocketevent.cpp
    M mythtv/libs/libmythbase/mythevent.cpp
    M mythtv/libs/libmythbase/mythevent.h
    M mythtv/libs/libmythmetadata/lyricsdata.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/messagehandler.cpp
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_web.cpp
    M mythtv/libs/libmythtv/channelscan/scanmonitor.cpp
    M mythtv/libs/libmythtv/channelscan/scanmonitor.h
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythnotification.cpp
    M mythtv/libs/libmythui/mythnotification.h
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/mythnotificationcenter_private.h
    M mythtv/libs/libmythui/mythudplistener.cpp
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythupnp/websocket_extensions/websocket_mythevent.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythcommflag/mythcommflag.cpp
    M mythtv/programs/mythfrontend/backendconnectionmanager.cpp
    M mythtv/programs/mythfrontend/galleryslideview.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/idlescreen.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/progfind.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp
    M mythtv/programs/mythfrontend/setupwizard_video.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  tidy: Change Event::Type names to begin with 'k' for constant.

This brings these new constants in line with the naming scheme of the
rest of MythTV.

All changes made by clang-tidy.

https://clang.llvm.org/extra/clang-tidy/checks/readability/identifier-naming.html

  Commit: 281b54893f89f88d3769fccb8907f9368cbd1012
      https://github.com/MythTV/mythtv/commit/281b54893f89f88d3769fccb8907f9368cbd1012
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-06-25 (Sun, 25 Jun 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/cddecoder.cpp
    M mythplugins/mythmusic/mythmusic/cddecoder.h
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/cdrip.h
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/decoder.h
    M mythplugins/mythmusic/mythmusic/decoderhandler.cpp
    M mythplugins/mythmusic/mythmusic/decoderhandler.h
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/lyricsview.cpp
    M mythplugins/mythmusic/mythmusic/mainvisual.cpp
    M mythplugins/mythmusic/mythmusic/musiccommon.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.h
    M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
    M mythplugins/mythmusic/mythmusic/searchview.cpp
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythplugins/mythmusic/mythmusic/visualizerview.cpp
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp
    M mythplugins/mythnews/mythnews/newssite.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputjack.cpp
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/output.cpp
    M mythtv/libs/libmyth/output.h
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/http/mythwebsocketevent.cpp
    M mythtv/libs/libmythbase/mythevent.cpp
    M mythtv/libs/libmythbase/mythevent.h
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmedia.h
    M mythtv/libs/libmythmetadata/lyricsdata.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.h
    M mythtv/libs/libmythmetadata/metadatafactory.cpp
    M mythtv/libs/libmythmetadata/metadatafactory.h
    M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
    M mythtv/libs/libmythmetadata/metadataimagedownload.h
    M mythtv/libs/libmythmetadata/videoscan.cpp
    M mythtv/libs/libmythmetadata/videoscan.h
    M mythtv/libs/libmythprotoserver/requesthandler/messagehandler.cpp
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_web.cpp
    M mythtv/libs/libmythtv/channelscan/scanmonitor.cpp
    M mythtv/libs/libmythtv/channelscan/scanmonitor.h
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/devices/jsmenuevent.cpp
    M mythtv/libs/libmythui/devices/jsmenuevent.h
    M mythtv/libs/libmythui/devices/lircevent.cpp
    M mythtv/libs/libmythui/devices/lircevent.h
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/libs/libmythui/mythdialogbox.h
    M mythtv/libs/libmythui/mythgesture.cpp
    M mythtv/libs/libmythui/mythgesture.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythnotification.cpp
    M mythtv/libs/libmythui/mythnotification.h
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/mythnotificationcenter.h
    M mythtv/libs/libmythui/mythnotificationcenter_private.h
    M mythtv/libs/libmythui/mythprogressdialog.cpp
    M mythtv/libs/libmythui/mythprogressdialog.h
    M mythtv/libs/libmythui/mythscreentype.cpp
    M mythtv/libs/libmythui/mythscreentype.h
    M mythtv/libs/libmythui/mythudplistener.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuiimage.cpp
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythupnp/websocket_extensions/websocket_mythevent.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythcommflag/mythcommflag.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.h
    M mythtv/programs/mythfrontend/backendconnectionmanager.cpp
    M mythtv/programs/mythfrontend/galleryslideview.cpp
    M mythtv/programs/mythfrontend/gallerythumbview.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/idlescreen.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/progfind.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp
    M mythtv/programs/mythfrontend/setupwizard_video.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  Merge QEvent::Type conversion to const.

Compare: https://github.com/MythTV/mythtv/compare/b77efb6919be...281b54893f89