[mythtv-commits] [MythTV/mythtv] 808f5c: Fix tidy/clazy warnings in new code.

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 808f5cff5943c57a5295c04a92a9f60d1af7abdb
      https://github.com/MythTV/mythtv/commit/808f5cff5943c57a5295c04a92a9f60d1af7abdb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/visualize.cpp
    M mythplugins/mythmusic/mythmusic/visualize.h
    M mythtv/programs/mythfrontend/galleryviews.cpp

  Log Message:
  -----------
  Fix tidy/clazy warnings in new code.

1) Base WaveForm on StereoScope instead of MonoScope.  The only change
Monoscope makes is to override two functions, and Waveform explicitly
calls past these Monoscope overrides to their StereoScope originals.

2) Fix a few "initialize variables" and "isolate declarations
warnings" by combining the initial declaration and initial value into
a single line.

3) Fix a couple of modernize "use bool literal" and "use auto"
warnings.


  Commit: 23442e200c8298f427df7bd25f3983709d9526a7
      https://github.com/MythTV/mythtv/commit/23442e200c8298f427df7bd25f3983709d9526a7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M mythtv/configure
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/libmythtv.pro

  Log Message:
  -----------
  Support the new libhdhomerun API (Oct 2022).

This adds a new discovery API using the following functions:

    hdhomerun_discover2_find_devices_broadcast
    hdhomerun_discover2_find_devices_targeted

and marks the older discovery functions as legacy functions.

Closes #649.


Compare: https://github.com/MythTV/mythtv/compare/6f04854c27c2...23442e200c82