[mythtv-commits] [MythTV/mythtv] 648864: Default to last channel used in Manual Record rule

[kmdewaal]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 648864b3bf2f54d83e3a8f3e86dc9cf9d49d8619
      https://github.com/MythTV/mythtv/commit/648864b3bf2f54d83e3a8f3e86dc9cf9d49d8619
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/manualschedule.cpp
    M mythtv/programs/mythfrontend/manualschedule.h

  Log Message:
  -----------
  Default to last channel used in Manual Record rule

When a user is entering a number of Manual Record rules
in a row, it would be nice if the previously used channel
was remembered and used as the default for the current
rule. For example, if you wanted to enter rules to record
Chicago Med, Chicago Fire, and Chicago P.D., which are
all on the same channel, it would save time on the second
and third rules, to default to the common channel.

To implement this, when a Manual Record rule is entered,
store the channel number such that it can be set as the
default channel for the next Manual Record rule.

Fixes #655


  Commit: 161e6849b186ca664567fb9c85cfc4954a80c7ab
      https://github.com/MythTV/mythtv/commit/161e6849b186ca664567fb9c85cfc4954a80c7ab
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/manualschedule.cpp
    M mythtv/programs/mythfrontend/manualschedule.h

  Log Message:
  -----------
  Updates based on review comments

Braces have been added for the one-line if.

Variable 'last_manual_chan' has been renamed to
's_lastChannelIndex', and its initialization has
been moved to the header file using inline.


  Commit: 67e1449a3b97d9ffec5e8ae4d029d06b6572bb1f
      https://github.com/MythTV/mythtv/commit/67e1449a3b97d9ffec5e8ae4d029d06b6572bb1f
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/manualschedule.h

  Log Message:
  -----------
  Adding Doxygen description for s_lastChannelIndex

Resolves #655


  Commit: 7e389f15f01c28d537c73e8ed985a82a86a91cb0
      https://github.com/MythTV/mythtv/commit/7e389f15f01c28d537c73e8ed985a82a86a91cb0
  Author: Steve Erlenborn <1751095+SteveErl at users.noreply.github.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/manualschedule.cpp
    M mythtv/programs/mythfrontend/manualschedule.h

  Log Message:
  -----------
  Allow default to last channel in Manual Record

A new configuration option has been introduced to allow
the user to specify how the starting channel should be
set in a new Manual Record rule.

Setup -> General -> General

has a new line "Starting channel for Manual Record"
with a choice between "Guide Starting Channel" and
"Last Manual Record Channel". The default configuration
is "Guide Starting Channel" which provides the existing
behavior of always setting the starting channel to
DefaultTVChannel. This value is set at

Setup -> Video -> Program Guide -> Guide Starts at Channel

If the user chooses the new behavior, "Last Manual Record Channel",
then when a new Manual Record rule is started, the channel will
be initialized to the value used in the previous Manual Record
rule. The very first time a Manual Record rule is entered, there
will be no previously used channel, so it will default to
DefaultTVChannel.

With this implementation, the existing behavior will not
change unless the user requests "Last Manual Record Channel"
option. When they do pick "Last Manual Record Channel", the
new behavior will bring them joy.

Resolves #655


  Commit: c2d2e1ab996eb294b5087885a9ec80ed14ee41a1
      https://github.com/MythTV/mythtv/commit/c2d2e1ab996eb294b5087885a9ec80ed14ee41a1
  Author: kmdewaal <kdewaal at mythtv.org>
  Date:   2023-02-03 (Fri, 03 Feb 2023)

  Changed paths:
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/manualschedule.cpp

  Log Message:
  -----------
  Merge pull request #664 from SteveErl/erlMerge5

Default to last channel used in Manual Record rule


Compare: https://github.com/MythTV/mythtv/compare/96dbeec4795d...c2d2e1ab996e