[mythtv-commits] [MythTV/mythtv] 183a61: Fix two compiler "variables set but not used" warn...

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 183a610bf433935904c5cd1bb99a80e7f143fc08
      https://github.com/MythTV/mythtv/commit/183a610bf433935904c5cd1bb99a80e7f143fc08
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-19 (Sat, 19 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythtv/test/test_copyframes/test_copyframes.cpp

  Log Message:
  -----------
  Fix two compiler "variables set but not used" warnings.


  Commit: 7290bbee2a3240f553e657eaa672410b8b661569
      https://github.com/MythTV/mythtv/commit/7290bbee2a3240f553e657eaa672410b8b661569
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-19 (Sat, 19 Nov 2022)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/mythmediamonitor.cpp
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp
    M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
    M mythtv/libs/libmythfreemheg/ParseText.cpp
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/commbreakmap.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.cpp
    M mythtv/libs/libmythtv/mythframe.cpp
    M mythtv/libs/libmythtv/mythmediaoverlay.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/vulkan/mythvideotexturevulkan.cpp
    M mythtv/libs/libmythtv/vulkan/mythvideovulkan.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythuibuttontree.cpp
    M mythtv/libs/libmythui/platforms/mythdisplayx11.cpp
    M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
    M mythtv/libs/libmythui/vulkan/mythvertexbuffervulkan.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/msocketdevice_unix.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythtranscode/external/replex/multiplex.cpp

  Log Message:
  -----------
  tidy: Simplify a handful of boolean expressions.

This checker appears to have been enhanced with a new algorithm in
llvm 15, and has found 41 new places where boolean expressions can be
simplified.

Changes made by clang-tidy. A couple of manual white space cleanups.

https://releases.llvm.org/15.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability/simplify-boolean-expr.html


  Commit: 94304cdd5dc329b842b450c39d79a78dc465173d
      https://github.com/MythTV/mythtv/commit/94304cdd5dc329b842b450c39d79a78dc465173d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythui/mythnotificationcenter.cpp

  Log Message:
  -----------
  tidy: Simplify one more boolean expression.

This checker appears to have been enhanced with a new algorithm in
llvm 15, and has found 41 new places where boolean expressions can be
simplified.

https://releases.llvm.org/15.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/readability/simplify-boolean-expr.html


  Commit: 751de0169c9e43631d158ecc391caa131c86539e
      https://github.com/MythTV/mythtv/commit/751de0169c9e43631d158ecc391caa131c86539e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/opengl/mythegldmabuf.cpp
    M mythtv/libs/libmythtv/opengl/mythnvdecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglvideo.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp

  Log Message:
  -----------
  tidy: No need to create temporary objects when calling emplace.

This checker has been enhanced in llvm 15 and has found 9 new places
where a call to emplace_back is combined with an object
constructor. This creates a unnecessary temporary object.

Changes made by clang-tidy.

https://releases.llvm.org/15.0.0/tools/clang/tools/extra/docs/clang-tidy/checks/modernize/use-emplace.html


  Commit: 2bbd475b6a7ed56fc10167f44c7c463d63e87ed1
      https://github.com/MythTV/mythtv/commit/2bbd475b6a7ed56fc10167f44c7c463d63e87ed1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  tidy: Ignore three new clang-tidy checks in LLVM 15.


  Commit: 502297513f3be6459aa9e74642f1dc829e220b27
      https://github.com/MythTV/mythtv/commit/502297513f3be6459aa9e74642f1dc829e220b27
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2captureCard.h

  Log Message:
  -----------
  tidy: Fix redundant member init warning.


  Commit: 7dc1c3bbdd890bcfc43463e735c51ed6fbf743de
      https://github.com/MythTV/mythtv/commit/7dc1c3bbdd890bcfc43463e735c51ed6fbf743de
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp

  Log Message:
  -----------
  Fix clang unused variable/function warnings on X86.


  Commit: 1e7f613cde22d30438b55419388b7b29e590d790
      https://github.com/MythTV/mythtv/commit/1e7f613cde22d30438b55419388b7b29e590d790
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmyth/mythcontext.cpp

  Log Message:
  -----------
  clazy: Fix "missing reference on non-trivial type" warning.


  Commit: 798bd8070a4bbc078b5978742aee3ca699a96215
      https://github.com/MythTV/mythtv/commit/798bd8070a4bbc078b5978742aee3ca699a96215
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmyth/backendselect.h
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmythbase/configuration.h

  Log Message:
  -----------
  tidy: Fix member variable names in new code.

Member variables should be named in the form m_camelBackCaseName for
consistency with existing code.


  Commit: 3b846d1e62f73e0f7655f52d271937c6daca22f1
      https://github.com/MythTV/mythtv/commit/3b846d1e62f73e0f7655f52d271937c6daca22f1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythbase/configuration.cpp

  Log Message:
  -----------
  tidy: Fix "use braced initializer list" warning in new code.


  Commit: dc56fd249048cad737996cb8a81da43915c5f705
      https://github.com/MythTV/mythtv/commit/dc56fd249048cad737996cb8a81da43915c5f705
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-11-20 (Sun, 20 Nov 2022)

  Changed paths:
    M mythtv/libs/libmythbase/configuration.cpp

  Log Message:
  -----------
  tidy: Fix "suspicious call argument" warning in configuration.cpp.

Tidy is pointing to a potential error where a function whose first
argument is "oldName" is being called with a second argument of "old".
The code is correct.  Rename the "old" variable to "backupName" to
eliminate the warning.

https://clang.llvm.org/extra/clang-tidy/checks/readability/suspicious-call-argument.html


Compare: https://github.com/MythTV/mythtv/compare/146689e87684...dc56fd249048