[mythtv-commits] [MythTV/mythtv] 76b9fb: Also check 'local' directory for python site-packa...

David Hampton noreply at github.com
Tue May 31 04:29:52 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 76b9fb4dbdcf6a85a86cbf11609795ac22659690
      https://github.com/MythTV/mythtv/commit/76b9fb4dbdcf6a85a86cbf11609795ac22659690
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythplugins/configure

  Log Message:
  -----------
  Also check 'local' directory for python site-packages.

This allows mythnetvision to find the MythTV bindings, whether they
are installed into .../lib or .../local/lib.


  Commit: c55a15f09b7b852184d30a61f690e8b2a32bf887
      https://github.com/MythTV/mythtv/commit/c55a15f09b7b852184d30a61f690e8b2a32bf887
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp

  Log Message:
  -----------
  tidy: Remove duplicate include.


  Commit: f8ac211ede86c9f81c13357904c64a73de0727af
      https://github.com/MythTV/mythtv/commit/f8ac211ede86c9f81c13357904c64a73de0727af
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M .clang-tidy
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
    M mythtv/libs/libmythtv/Bluray/mythbdinfo.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
    M mythtv/libs/libmythtv/io/mythavformatwriter.cpp
    M mythtv/libs/libmythtv/mythframe.cpp

  Log Message:
  -----------
  tidy: Fix "misplaced widening cast" warnings.

This check will warn when there is a cast of a calculation result to a
bigger type. If the intention of the cast is to avoid loss of
precision then the cast is misplaced, and there can be loss of
precision. Otherwise the cast is ineffective.

Fix these warning by casting the first term of the multiplication to
the bigger type, instead of casting the result of the multiplication.


  Commit: dca946e85ded010daa87d7573aeedb034d7fa782
      https://github.com/MythTV/mythtv/commit/dca946e85ded010daa87d7573aeedb034d7fa782
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M .clang-tidy
    M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
    M mythtv/libs/libmyth/audio/audiooutputgraph.h
    M mythtv/libs/libmythbase/mythchrono.h
    M mythtv/libs/libmythtv/mythhdrtracker.cpp
    M mythtv/libs/libmythtv/mythhdrtracker.h
    M mythtv/libs/libmythui/mythhdr.cpp
    M mythtv/libs/libmythui/mythhdr.h
    M mythtv/libs/libmythui/mythvrr.cpp
    M mythtv/libs/libmythui/mythvrr.h
    M mythtv/libs/libmythui/platforms/drm/mythdrmhdr.cpp
    M mythtv/libs/libmythui/platforms/drm/mythdrmhdr.h
    M mythtv/libs/libmythui/platforms/mythnvcontrol.cpp
    M mythtv/libs/libmythui/platforms/mythnvcontrol.h
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/services/frontend.h
    M mythtv/programs/mythtranscode/external/replex/element.cpp

  Log Message:
  -----------
  tidy: Fix "reserved identifier" warnings.

The C and C++ standards both reserve the following names for such use:

    identifiers that begin with an underscore followed by an uppercase letter;
    identifiers in the global namespace that begin with an underscore.

Rename the identifiers to not use reserved characters. Unfortunately
the name "Display" is globally defined by something like X windows, so
"_Display" can't be changed to "Display" because the compiler would
then generate multiply defined symbol warnings, thus the name
"MDisplay" for "myth display".


  Commit: 8620471eb28fe7dd052b844a579f9f6c53853a9b
      https://github.com/MythTV/mythtv/commit/8620471eb28fe7dd052b844a579f9f6c53853a9b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M .clang-tidy
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSStream.cpp

  Log Message:
  -----------
  tidy: Fix 'signed char' to 'int' warnings.

>From clang-tidy:

  When the code contains an explicit signed char -> integer
  conversion, the human programmer probably expects that the converted
  value matches with the character code (a value from [0..255]),
  however, the actual value is in [-128..127] interval.

Fix these warnings by changing the variable type from char* to
uint8_t* so it is explicit that we expect to have the values [0..255].


  Commit: ed3133a2ca30edecddc6c672ea0475972cd69633
      https://github.com/MythTV/mythtv/commit/ed3133a2ca30edecddc6c672ea0475972cd69633
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in programinfo.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-implicit-widening-of-multiplication-result.html


  Commit: 3143d397cceb62750274fc532905b824ffcf8dce
      https://github.com/MythTV/mythtv/commit/3143d397cceb62750274fc532905b824ffcf8dce
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythpower.cpp
    M mythtv/libs/libmythbase/threadedfilewriter.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythbase.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type.

https://clang.llvm.org/extra/clang-tidy/checks/bugprone-implicit-widening-of-multiplication-result.html


  Commit: 71045d19984176f5d480afc3d7033f5bc01c434d
      https://github.com/MythTV/mythtv/commit/71045d19984176f5d480afc3d7033f5bc01c434d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmythmetadata/musicfilescanner.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythmetadata.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type.


  Commit: f13445e4cd8f04a0f4af541ea6f75864893b043b
      https://github.com/MythTV/mythtv/commit/f13445e4cd8f04a0f4af541ea6f75864893b043b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythtv.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type.


  Commit: 46e8e0ea1efe17fb2b4c1d5771dc9dbaa51ebd0c
      https://github.com/MythTV/mythtv/commit/46e8e0ea1efe17fb2b4c1d5771dc9dbaa51ebd0c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythbackend/recordingextender.cpp
    M mythtv/programs/mythbackend/scheduler.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythbackend.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type.


  Commit: b7f334482e786d36732d46be2e89981f5819e13c
      https://github.com/MythTV/mythtv/commit/b7f334482e786d36732d46be2e89981f5819e13c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/videofilter.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythfrontend.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type. Fix the
warnings by either changing one of the constants to a 'long long' or
by enlarging the type of a variable.


  Commit: 312f37543e5fd0e8272b73b18df4c45168328e60
      https://github.com/MythTV/mythtv/commit/312f37543e5fd0e8272b73b18df4c45168328e60
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythcommflag.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Fix this code to use int64_t for everything, instead of calculating in
an int64_t and truncating to an int, then converting back to int64_t
for the next calculation, and then truncating again, etc.


  Commit: 77739865d9d4c02609a52f31ee320129052bd08b
      https://github.com/MythTV/mythtv/commit/77739865d9d4c02609a52f31ee320129052bd08b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/programs/mythshutdown/mythshutdown.cpp
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythshutdown/welcome.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

In these cases, the fix is simply to force the "multiplication by -1"
to happen as a 64 bit number.


  Commit: 1b1f145536cefeb7e282d8a553240410bc31146a
      https://github.com/MythTV/mythtv/commit/1b1f145536cefeb7e282d8a553240410bc31146a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/archiveutil.cpp
    M mythplugins/mytharchive/mytharchive/archiveutil.h
    M mythplugins/mytharchive/mytharchive/exportnative.cpp
    M mythplugins/mytharchive/mytharchive/fileselector.cpp
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mytharchive/mytharchive/recordingselector.cpp
    M mythplugins/mytharchive/mytharchive/selectdestination.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mythnews/mythnews/mythnews.cpp
    M mythplugins/mythnews/mythnews/mythnews.h
    M mythtv/libs/libmythbase/stringutil.cpp
    M mythtv/libs/libmythbase/stringutil.h
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  Collapse (k)byte size formatting functions into a single location.


  Commit: 61db5c4d605e965aa754bdfb5753d7801dc6af3e
      https://github.com/MythTV/mythtv/commit/61db5c4d605e965aa754bdfb5753d7801dc6af3e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythsystemunix.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythsystemunix.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type. Fix the
warnings by casting the result to the expected type.


  Commit: ee25ad440956ff6a723df9542e2384c1d3c9f160
      https://github.com/MythTV/mythtv/commit/ee25ad440956ff6a723df9542e2384c1d3c9f160
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.h

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythzoneminder.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

This set of warnings are false positives as the compiler is generating
constant values that are well within the range of the type. The fix is
simply to force the compiler to perform the multiplication to happen
as a 64bit number.


  Commit: 419f8af3819599027688d71b4d56007dbf860f43
      https://github.com/MythTV/mythtv/commit/419f8af3819599027688d71b4d56007dbf860f43
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-05-30 (Mon, 30 May 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythcdrom.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythcdrom.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Fix by forcing the compiler to perform the multiplication as a 64bit
number.


Compare: https://github.com/MythTV/mythtv/compare/ec49edd7197b...419f8af38195


More information about the mythtv-commits mailing list