[mythtv-commits] [MythTV/mythtv] 0f8e58: Fix "33.0.-1 is an invalid version" warning in pyt...

David Hampton noreply at github.com
Mon Jun 20 16:07:14 UTC 2022


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 0f8e58b20a4246d46a77406fcf3c5368fbabaf8b
      https://github.com/MythTV/mythtv/commit/0f8e58b20a4246d46a77406fcf3c5368fbabaf8b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/bindings/python/setup.cfg

  Log Message:
  -----------
  Fix "33.0.-1 is an invalid version" warning in python bindings.


  Commit: 8f8cec434a0af1cdce0fbb6412feefa0528bcdd0
      https://github.com/MythTV/mythtv/commit/8f8cec434a0af1cdce0fbb6412feefa0528bcdd0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/bindings/perl/MythTV.pm

  Log Message:
  -----------
  Fix warning about perl version number.

    WARNING: Setting VERSION via file 'MythTV.pm' failed
     at /usr/share/perl5/vendor_perl/ExtUtils/MakeMaker.pm line 761.

It appears that the tools only allow numbers, a period, and an
underscore as valid characters. Drop the 'git' tag to satisfy the
tools.


  Commit: 46002c8caaa51d96a21ebb3d063e9c94532d45c0
      https://github.com/MythTV/mythtv/commit/46002c8caaa51d96a21ebb3d063e9c94532d45c0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
    M mythtv/libs/libmyth/audio/audiooutputgraph.h

  Log Message:
  -----------
  Fix shadowed variable warnings in audiooutputgraph.

Recent commit dca946e85d changed a couple of function parameter names
from "_Buffer" to "Buffer" to eliminate warnings about using reserved
variable names.  This created "shadowed variable" warnings because the
class already has a sub-class named "Buffer".  Change that sub-class
name to eliminate these warnings.


  Commit: 86a369edec98361f8076491abf20ed5b4493e44c
      https://github.com/MythTV/mythtv/commit/86a369edec98361f8076491abf20ed5b4493e44c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  Rewrite videodlg.cpp without std::binary_function.

std::binary_function was deprecated in the C++11 standard, and has been
removed from the C++17 standard. Eventually compilers will stop
supporting it.


  Commit: ba445080d8c44cd9267ea4ab2f8cef02ce0be2b7
      https://github.com/MythTV/mythtv/commit/ba445080d8c44cd9267ea4ab2f8cef02ce0be2b7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/proglist.cpp

  Log Message:
  -----------
  Rewrite proglist.cpp without std::binary_function.

std::binary_function was deprecated in the C++11 standard, and has been
removed from the C++17 standard. Eventually compilers will stop
supporting it.

This diff is easier to read using the '-b' argument.


  Commit: 682ec7dd4c9a9bbd435a9d020e719c27c174876d
      https://github.com/MythTV/mythtv/commit/682ec7dd4c9a9bbd435a9d020e719c27c174876d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/mythmusic.cpp

  Log Message:
  -----------
  tidy: Fix "readability named parameter" warning.


  Commit: dce05ee5766e906653e480adb25caf55254617e7
      https://github.com/MythTV/mythtv/commit/dce05ee5766e906653e480adb25caf55254617e7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/playlist.h
    M mythplugins/mythmusic/mythmusic/playlistcontainer.cpp
    M mythplugins/mythmusic/mythmusic/playlistcontainer.h

  Log Message:
  -----------
  tidy: Fix "make parameter a const reference" warning.


  Commit: 98bdd9b86b30089c3e76f65a772c2b0e9f4e441b
      https://github.com/MythTV/mythtv/commit/98bdd9b86b30089c3e76f65a772c2b0e9f4e441b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/cdrip.h

  Log Message:
  -----------
  tidy: Fix "constructor does not initialize fields" warning.


  Commit: b328ada30c4ef40c5196bc52d5b04572f698ed46
      https://github.com/MythTV/mythtv/commit/b328ada30c4ef40c5196bc52d5b04572f698ed46
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/logviewer.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythweather/mythweather/sourceManager.cpp
    M mythplugins/mythweather/mythweather/weatherScreen.cpp
    M mythplugins/mythweather/mythweather/weatherSource.cpp

  Log Message:
  -----------
  tidy: Fix "avoid repeating the return type" warnings. (plugins)

Avoid repeating the return type from the declaration; use a braced
initializer list instead.

These changes were all made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html


  Commit: 1baeb71853090e307027652c952d6222ff610ae3
      https://github.com/MythTV/mythtv/commit/1baeb71853090e307027652c952d6222ff610ae3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/programs/mythbackend/encoderlink.cpp
    M mythtv/programs/mythbackend/filetransfer.cpp
    M mythtv/programs/mythbackend/mythsettings.h
    M mythtv/programs/mythbackend/playbacksock.cpp
    M mythtv/programs/mythbackend/recordingextender.cpp
    M mythtv/programs/mythbackend/services/content.cpp
    M mythtv/programs/mythbackend/services/guide.cpp
    M mythtv/programs/mythbackend/services/image.cpp
    M mythtv/programs/mythbackend/servicesv2/v2content.cpp
    M mythtv/programs/mythbackend/servicesv2/v2guide.cpp
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythfrontend/actionset.cpp
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythfrontend/mythcontrols.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videolist.cpp
    M mythtv/programs/mythfrontend/videoplayercommand.cpp
    M mythtv/programs/mythtranscode/transcode.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp

  Log Message:
  -----------
  tidy: Fix "avoid repeating the return type" warnings. (programs)

Avoid repeating the return type from the declaration; use a braced
initializer list instead.

These changes were all made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html


  Commit: 2a70c7456ea5dbfd13a404ac709ecdf573452b9f
      https://github.com/MythTV/mythtv/commit/2a70c7456ea5dbfd13a404ac709ecdf573452b9f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/remoteutil.cpp
    M mythtv/libs/libmyth/rssparse.cpp
    M mythtv/libs/libmythbase/http/mythhttpencoding.cpp
    M mythtv/libs/libmythbase/http/mythhttpmetamethod.cpp
    M mythtv/libs/libmythbase/http/mythwsdl.cpp
    M mythtv/libs/libmythbase/http/mythxsd.cpp
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/mythbinaryplist.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythcoreutil.cpp
    M mythtv/libs/libmythbase/mythdeque.h
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythlocale.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythsession.cpp
    M mythtv/libs/libmythbase/recordingtypes.cpp
    M mythtv/libs/libmythbase/remotefile.cpp
    M mythtv/libs/libmythbase/storagegroup.cpp
    M mythtv/libs/libmythbase/stringutil.h
    M mythtv/libs/libmythbase/unziputil.cpp
    M mythtv/libs/libmythfreemheg/Bitmap.cpp
    M mythtv/libs/libmythfreemheg/DynamicLineArt.cpp
    M mythtv/libs/libmythfreemheg/Engine.cpp
    M mythtv/libs/libmythfreemheg/Stream.cpp
    M mythtv/libs/libmythfreemheg/Text.cpp
    M mythtv/libs/libmythfreemheg/Visible.cpp
    M mythtv/libs/libmythfreemheg/Visible.h
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/imagemetadata.cpp
    M mythtv/libs/libmythmetadata/imagethumbs.cpp
    M mythtv/libs/libmythmetadata/metadatacommon.cpp
    M mythtv/libs/libmythmetadata/metadatafactory.cpp
    M mythtv/libs/libmythmetadata/metadatagrabber.cpp
    M mythtv/libs/libmythmetadata/metaio.h
    M mythtv/libs/libmythmetadata/metaioflacvorbis.cpp
    M mythtv/libs/libmythmetadata/metaioid3.cpp
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/musicutils.cpp
    M mythtv/libs/libmythmetadata/videometadata.cpp
    M mythtv/libs/libmythmetadata/videometadatalistmanager.cpp
    M mythtv/libs/libmythprotoserver/sockethandler/filetransfer.cpp
    M mythtv/libs/libmythservicecontracts/service.cpp

  Log Message:
  -----------
  tidy: Fix "avoid repeating the return type" warnings. (libs 1)

Avoid repeating the return type from the declaration; use a braced
initializer list instead.

These changes were all made by the clang-tidy program. (The one in
stringutil.h had to have a cast added so that the compiler would match
the function overrides.)

https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html


  Commit: 26904474092c0a01d869c040e23a88dfe037e86f
      https://github.com/MythTV/mythtv/commit/26904474092c0a01d869c040e23a88dfe037e86f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/HLS/httplivestream.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/captions/subtitlereader.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.h
    M mythtv/libs/libmythtv/diseqc.cpp
    M mythtv/libs/libmythtv/dtvconfparserhelpers.cpp
    M mythtv/libs/libmythtv/dtvconfparserhelpers.h
    M mythtv/libs/libmythtv/io/mythfilebuffer.cpp
    M mythtv/libs/libmythtv/iptvtuningdata.h
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/mheg/netstream.cpp
    M mythtv/libs/libmythtv/mpeg/atsc_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.h
    M mythtv/libs/libmythtv/mpeg/atsctables.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.h
    M mythtv/libs/libmythtv/mpeg/dishdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
    M mythtv/libs/libmythtv/mpeg/freesat_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mpeg/premieredescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/splicedescriptors.cpp
    M mythtv/libs/libmythtv/mythcodecid.cpp
    M mythtv/libs/libmythtv/mythframe.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythtvmenu.cpp
    M mythtv/libs/libmythtv/mythvideoprofile.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp
    M mythtv/libs/libmythtv/recorders/cetonstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/satiputils.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.cpp
    M mythtv/libs/libmythtv/sourceutil.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/videometadatautil.cpp
    M mythtv/libs/libmythtv/videoouttypes.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythui/mythgenerictree.cpp
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/mythrender.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp
    M mythtv/libs/libmythui/myththemedmenu.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuilocation.cpp
    M mythtv/libs/libmythui/mythuithemehelper.cpp
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythui/opengl/mythpainteropengl.h
    M mythtv/libs/libmythui/platforms/mythdrmdevice.cpp
    M mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.cpp
    M mythtv/libs/libmythui/xmlparsebase.cpp
    M mythtv/libs/libmythupnp/eventing.h
    M mythtv/libs/libmythupnp/htmlserver.h
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/serializers/serializer.cpp
    M mythtv/libs/libmythupnp/serializers/xmlSerializer.cpp
    M mythtv/libs/libmythupnp/upnpserviceimpl.h
    M mythtv/libs/libmythupnp/upnputil.cpp
    M mythtv/libs/libmythupnp/wsdl.cpp
    M mythtv/libs/libmythupnp/xsd.cpp

  Log Message:
  -----------
  tidy: Fix "avoid repeating the return type" warnings. (libs 2)

Avoid repeating the return type from the declaration; use a braced
initializer list instead.

These changes were all made by the clang-tidy program.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html


  Commit: 59ae36f9febea9862ceee5fdf3cd7625fc9eaf7e
      https://github.com/MythTV/mythtv/commit/59ae36f9febea9862ceee5fdf3cd7625fc9eaf7e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M .clang-tidy
    M mythplugins/mythnetvision/mythnetvision/netcommon.cpp
    M mythtv/libs/libmythbase/mythbinaryplist.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythfreemheg/Text.cpp
    M mythtv/libs/libmythfreemheg/Visible.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
    M mythtv/libs/libmythupnp/serverSideScripting.cpp
    M mythtv/libs/libmythupnp/upnpcds.cpp
    M mythtv/programs/mythbackend/services/content.cpp
    M mythtv/programs/mythbackend/services/guide.cpp
    M mythtv/programs/mythbackend/servicesv2/v2content.cpp
    M mythtv/programs/mythbackend/servicesv2/v2guide.cpp
    M mythtv/programs/mythbackend/test/test_recordingextender/test_recordingextender.cpp
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp

  Log Message:
  -----------
  tidy: Fix "avoid repeating the return type" warnings. (addl)

Avoid repeating the return type from the declaration; use a braced
initializer list instead.

These changes were all made by hand.

https://clang.llvm.org/extra/clang-tidy/checks/modernize-return-braced-init-list.html


  Commit: cd16a1c3590a43954fbe5306969582a5d1b45126
      https://github.com/MythTV/mythtv/commit/cd16a1c3590a43954fbe5306969582a5d1b45126
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/dtvconfparserhelpers.h

  Log Message:
  -----------
  qt6: Tweak one "avoid repeating the return type" change.

Qt6 has changed the QChar constructor overloads such that the compiler
can't determine the correct constructor to use for QChar(0).  Changing
this to QChar() yields the same value and solves the overload problem.


  Commit: cb74320fe05a56fdb8aded5cb81042d07ae774aa
      https://github.com/MythTV/mythtv/commit/cb74320fe05a56fdb8aded5cb81042d07ae774aa
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.h

  Log Message:
  -----------
  tidy: Fix "implicit conversion bool <-> int" in mythplayer.

Change a variable type to bool. Add an explicit comparison to zero,
and remove an explicit comparison to zero.


  Commit: 026f5abe86592160a316524bb5108a5a7ace49d0
      https://github.com/MythTV/mythtv/commit/026f5abe86592160a316524bb5108a5a7ace49d0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythsocket.h
    M mythtv/programs/mythfilerecorder/mythfilerecorder.h

  Log Message:
  -----------
  tidy: Fix "implicit conversion bool -> int" related to QAtomicInt.

These constants should use 0/1 instead of false/true.


  Commit: 1830c2951f8218d457ad4acb753a5f54e09d9339
      https://github.com/MythTV/mythtv/commit/1830c2951f8218d457ad4acb753a5f54e09d9339
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.h

  Log Message:
  -----------
  Convert int->size_t in cc608decoder.


  Commit: 09c1ba55856147486d677b16874dc678e12f474e
      https://github.com/MythTV/mythtv/commit/09c1ba55856147486d677b16874dc678e12f474e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythmetadata/videoscan.cpp

  Log Message:
  -----------
  Remove unused variable.


  Commit: c10a04967264377ce4cd8d09108a86c5e7d15c33
      https://github.com/MythTV/mythtv/commit/c10a04967264377ce4cd8d09108a86c5e7d15c33
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/galleryviews.h

  Log Message:
  -----------
  Convert int->ssize_t in galleryviews.

This variable is set from a call to a size() function, and its only
use is when it is compared to the result of a size() function.  The
type is ssize_t instead of size_t because the initial call to create
the object uses a value of "xxx.size() - 1" without testing if that
expression yields -1.


  Commit: f9dab47605709ac66c39a75c8fdeb92eb4ca31e5
      https://github.com/MythTV/mythtv/commit/f9dab47605709ac66c39a75c8fdeb92eb4ca31e5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/galleryconfig.h

  Log Message:
  -----------
  tidy: Fix "method can be made static" warning.


  Commit: 0099a2b9d2000ec69c75b663a7d19ccb91abb9c1
      https://github.com/MythTV/mythtv/commit/0099a2b9d2000ec69c75b663a7d19ccb91abb9c1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp

  Log Message:
  -----------
  tidy: Fix "repeated branch" warning.

Clarify the error messages to distinguish between the two failure
cases.


  Commit: d664376a6afe31ea75ebf1bb6a1dac8df533b4ef
      https://github.com/MythTV/mythtv/commit/d664376a6afe31ea75ebf1bb6a1dac8df533b4ef
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythbase/mythcorecontext.h

  Log Message:
  -----------
  tidy: Convert several #define to constexpr.


  Commit: 98762a871c8bda7d8da0cf8e18f771c9508cc48e
      https://github.com/MythTV/mythtv/commit/98762a871c8bda7d8da0cf8e18f771c9508cc48e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythbase/libmythbase.pro
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythbase/mythdb.h
    M mythtv/libs/libmythbase/mythdbcon.h
    M mythtv/libs/libmythbase/mythlocale.h
    M mythtv/libs/libmythbase/mythobservable.h
    M mythtv/libs/libmythbase/mythsession.h
    A mythtv/libs/libmythbase/qtuplift.h

  Log Message:
  -----------
  tidy: Fix a few "defines a destructor but not..." warnings.

The clang-tidy "special member functions" check looks for violations
of the "rule of five".  This states that if you define any of a
destructor, a copy constructor, a copy assignment, a move constructor,
or a move assignment function, then you need to define all of them.
Non compiler generated default versions of these functions are
generally only needed when managing a dynamically allocated resource,
and they all need to be implemented to properly manage that dynamic
resource.

https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/special-member-functions.html
https://cpppatterns.com/patterns/rule-of-five.html


  Commit: 02247cfba9921c44882f01fd0bda39e7addd4b5d
      https://github.com/MythTV/mythtv/commit/02247cfba9921c44882f01fd0bda39e7addd4b5d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-20 (Mon, 20 Jun 2022)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythplugins/mythmusic/mythmusic/musicplayer.cpp

  Log Message:
  -----------
  Restore two include statements in mythmusic.

These were removed by 1e1e8145, but are needed to correctly include CD
support.

Fixes #586.


Compare: https://github.com/MythTV/mythtv/compare/8f99b9a78611...02247cfba992


More information about the mythtv-commits mailing list