[mythtv-commits] [MythTV/mythtv] 68bb4d: Add new _Z and _UZ literals to parallel the c++23 ...

Sat Jun 18 19:13:47 UTC 2022

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 68bb4d7208e545b67deffc31ca5d5436d6bbcdb4
      https://github.com/MythTV/mythtv/commit/68bb4d7208e545b67deffc31ca5d5436d6bbcdb4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythbase/libmythbase.pro
    A mythtv/libs/libmythbase/sizetliteral.h

  Log Message:
  -----------
  Add new _Z and _UZ literals to parallel the c++23 Z/UZ literals.

These literals specify that a constant is of type ssize_t or size_t.
These are needed because the size of these two types differ between
32bit and 64bit cpus.

  Commit: 6b235a13d80fffad97912ab82dec6656e573da09
      https://github.com/MythTV/mythtv/commit/6b235a13d80fffad97912ab82dec6656e573da09
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputdigitalencoder.cpp
    M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
    M mythtv/libs/libmyth/audio/eldutils.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmyth.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert a variable to the appropriate type.

  Commit: ea36b22e1e7b0a29d31303dfa49c3dca163a998b
      https://github.com/MythTV/mythtv/commit/ea36b22e1e7b0a29d31303dfa49c3dca163a998b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythfreemheg/Programs.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythfreemheg.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Cast a multiplication argument to a larger type.

  Commit: f7abed41e20b9153c270853de557feecdbd1279b
      https://github.com/MythTV/mythtv/commit/f7abed41e20b9153c270853de557feecdbd1279b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythfreesurround/el_processor.cpp
    M mythtv/libs/libmythfreesurround/freesurround.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythfreesurround.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert variables to the appropriate type.

  Commit: faf2ba4f8a4b747d9faccd67918f88b4866ebd5b
      https://github.com/MythTV/mythtv/commit/faf2ba4f8a4b747d9faccd67918f88b4866ebd5b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythui/devices/lirc.cpp
    M mythtv/libs/libmythui/mythimage.h
    M mythtv/libs/libmythui/mythpainter.cpp
    M mythtv/libs/libmythui/mythuithemecache.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythui.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Cast multiplication arguments to a larger type.

  Commit: 6a9cc47d5bbce4dc148fb6957405b08d09892d2b
      https://github.com/MythTV/mythtv/commit/6a9cc47d5bbce4dc148fb6957405b08d09892d2b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythfilerecorder.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Convert a variable to the appropriate type.

  Commit: 44e10d909accfca21af5eab4e6245fcb6f6894a1
      https://github.com/MythTV/mythtv/commit/44e10d909accfca21af5eab4e6245fcb6f6894a1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/thumbfinder.cpp
    M mythplugins/mytharchive/mytharchive/thumbfinder.h
    M mythplugins/mytharchive/mytharchivehelper/external/pxsup2dast.c

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mytharchive.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert a variable to the appropriate type.

3) Remove a cast from int64_t to int, that then gets implicitly cast back
to int64_t.

  Commit: 18c16e00235fe355952d61fcfa950ee1f5b2ab68
      https://github.com/MythTV/mythtv/commit/18c16e00235fe355952d61fcfa950ee1f5b2ab68
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/bumpscope.cpp
    M mythplugins/mythmusic/mythmusic/bumpscope.h
    M mythplugins/mythmusic/mythmusic/flacencoder.h
    M mythplugins/mythmusic/mythmusic/synaesthesia.cpp
    M mythplugins/mythmusic/mythmusic/visualize.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythmusic.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert a variable to the appropriate type.

3) Convert a couple of #define to typed static constexpr.

  Commit: 0f0edc5bdf0310dd4956b3d8a184d9e003e03273
      https://github.com/MythTV/mythtv/commit/0f0edc5bdf0310dd4956b3d8a184d9e003e03273
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
    M mythplugins/mythzoneminder/mythzmserver/zmserver.h
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythzoneminder.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert a variable to the appropriate type.

3) Convert a #define to a typed static constexpr.

  Commit: 3e060209cab0d5f2b58c137b6bc72a90878172c9
      https://github.com/MythTV/mythtv/commit/3e060209cab0d5f2b58c137b6bc72a90878172c9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythmetadata/metadatacommon.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythmetadata.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

Convert a couple of variables to the appropriate type.

  Commit: b3a1f7e53de3037d89367eb8a6f8b171e78d5a2e
      https://github.com/MythTV/mythtv/commit/b3a1f7e53de3037d89367eb8a6f8b171e78d5a2e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdstream.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/captions/cc708window.cpp
    M mythtv/libs/libmythtv/captions/teletextreader.cpp
    M mythtv/libs/libmythtv/captions/vbi608extractor.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/frequencytables.h
    M mythtv/libs/libmythtv/io/mythavformatwriter.cpp
    M mythtv/libs/libmythtv/io/mythfilebuffer.cpp
    M mythtv/libs/libmythtv/jitterometer.cpp
    M mythtv/libs/libmythtv/mpeg/atsc_huffman.cpp
    M mythtv/libs/libmythtv/mpeg/pespacket.cpp
    M mythtv/libs/libmythtv/mythdeinterlacer.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythtv (1).

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert a variable to the appropriate type.

3) Convert a couple of #define to typed static constexpr.

  Commit: 3665ceed84aa7ba1c6e7c24e9fcf7c3ce1ab47fa
      https://github.com/MythTV/mythtv/commit/3665ceed84aa7ba1c6e7c24e9fcf7c3ce1ab47fa
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/DeviceReadBuffer.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.h
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.h
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hlsstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/httptsstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/httptsstreamhandler.h
    M mythtv/libs/libmythtv/recorders/v4lrecorder.cpp
    M mythtv/libs/libmythtv/recorders/vbitext/lang.cpp
    M mythtv/libs/libmythtv/recorders/vbitext/vbi.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/visualisations/goom/ifs.cpp
    M mythtv/libs/libmythtv/visualisations/goom/surf3d.cpp
    M mythtv/libs/libmythtv/visualisations/videovisualmonoscope.h

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythtv (2).

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert variables to the appropriate type.

3) Convert a couple of #define to typed static constexpr.

  Commit: 95c147312e090d7cdd43e8305e055e3846cad6a2
      https://github.com/MythTV/mythtv/commit/95c147312e090d7cdd43e8305e055e3846cad6a2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/programs/mythcommflag/CannyEdgeDetector.cpp
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythcommflag/EdgeDetector.cpp
    M mythtv/programs/mythcommflag/Histogram.cpp
    M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
    M mythtv/programs/mythcommflag/LogoDetectorBase.h
    M mythtv/programs/mythcommflag/TemplateFinder.h
    M mythtv/programs/mythcommflag/TemplateMatcher.cpp
    M mythtv/programs/mythcommflag/pgm.cpp

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in mythcommflag.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Cast multiplication arguments to a larger type.

2) Convert variables to the appropriate type.

  Commit: 3b849cc809438b31984c8c8c7caed09836b6dd3f
      https://github.com/MythTV/mythtv/commit/3b849cc809438b31984c8c8c7caed09836b6dd3f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-06-18 (Sat, 18 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythmpeg2/decode.c

  Log Message:
  -----------
  tidy: Fix "multiplication implicit widening" in libmythmpeg.

Fix the clang-tidy "implicit widening of multiplication result"
warnings.  This check is looking for places where a multiplication
operation may have overflowed the smaller type before the result is
converted to the bigger type. This will give erroneous results.

1) Reorder multiplication terms so the largest term is first.

2) Convert a #define to typed static variable.

Compare: https://github.com/MythTV/mythtv/compare/43a57961de1b...3b849cc80943