[mythtv-commits] [MythTV/mythtv] f49697: replace internal ffmpeg headers with BitReader

Scott Theisen noreply at github.com
Wed Jun 15 13:09:12 UTC 2022


  Branch: refs/heads/devel/ffmpeg-resync
  Home:   https://github.com/MythTV/mythtv
  Commit: f49697bd106b21fb5b9446c9642bcbcf44e20a3e
      https://github.com/MythTV/mythtv/commit/f49697bd106b21fb5b9446c9642bcbcf44e20a3e
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.h
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.h

  Log Message:
  -----------
  replace internal ffmpeg headers with BitReader

This should have no functional change.

References https://github.com/MythTV/mythtv/issues/428

The hack is no longer necessary since internal FFmpeg headers are no longer
included by the parsers.

avformatdecoder.cpp needed the public FFmpeg header "libavutil/intreadwrite.h".


  Commit: 64a28f3bc87c3b81ed5d7965808d960b53ae1d92
      https://github.com/MythTV/mythtv/commit/64a28f3bc87c3b81ed5d7965808d960b53ae1d92
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h
    M mythtv/external/FFmpeg/libavcodec/golomb.h

  Log Message:
  -----------
  lavc/get_bits.h and golomb.h: revert MythTV changes

The changes were to defeat compiler warnings, but MythTV no longer includes
these internal headers.


  Commit: 6e9cb99fb68b7154cf47ffbf4ae74d200c0c7e97
      https://github.com/MythTV/mythtv/commit/6e9cb99fb68b7154cf47ffbf4ae74d200c0c7e97
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf/utils.c: remove unused extern declarations


  Commit: 2aab0e43e4855fb41085391292dd193c8209859a
      https://github.com/MythTV/mythtv/commit/2aab0e43e4855fb41085391292dd193c8209859a
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c

  Log Message:
  -----------
  lavf: move MythTV added define to the only file using it

this quiets a warning about it being redefined elsewhere in ffmpeg


  Commit: 47199b9e7c3a83fde48fb1ee05f4ac69cc5409f4
      https://github.com/MythTV/mythtv/commit/47199b9e7c3a83fde48fb1ee05f4ac69cc5409f4
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/postprocess.c

  Log Message:
  -----------
  lpp: revert unnecessary added include

seems to have been added during an ffmpeg merge, but is unused


  Commit: f097c60605972506810c7fbba79366783008ef03
      https://github.com/MythTV/mythtv/commit/f097c60605972506810c7fbba79366783008ef03
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/postprocess.c

  Log Message:
  -----------
  lpp: revert unnecessary MythTV cpu autodetect

This is from 2010-08-24:
detect available SIMD extensions when runtime-cpudetect is enabled
https://github.com/MythTV/mythtv/commit/206974153a539acd72451512ac6a7aae818d0fe9

but if you look at the following lines, ffmpeg has effectively the same since 2012-11-18:
pp: add auto detection cpu flag.
https://github.com/FFmpeg/FFmpeg/commit/59d686f100863d00b8f171dd891e893c2bfd951e


  Commit: 0647c6ddeffd9d60ec88425097eff19f058d510c
      https://github.com/MythTV/mythtv/commit/0647c6ddeffd9d60ec88425097eff19f058d510c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/Makefile

  Log Message:
  -----------
  lpp: revert change to Makefile

if ffmpeg doesn't need this, neither do we


  Commit: fdd6b147800523c1af347ed0a800c2f98e0ebf0c
      https://github.com/MythTV/mythtv/commit/fdd6b147800523c1af347ed0a800c2f98e0ebf0c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  lavc/dvbsubdec.c: remove redundant conditional statements

from: https://github.com/MythTV/mythtv/commit/68ca96cfa02b9df406de4ad233fdb395405f6b88

duplicates the condition on line 919, which will catch it and return


  Commit: dc24a38b5c67aa82dadd2490a8458af882d39efa
      https://github.com/MythTV/mythtv/commit/dc24a38b5c67aa82dadd2490a8458af882d39efa
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegvideo.h

  Log Message:
  -----------
  lavc/mpegvideo.h: revert unnecessary changes

class: C++ keyword, but MythTV does not include this file

removed parentheses resulted from a complier warning about
"unnecessary parentheses"


  Commit: 7562f38e95815b2dfbf99d4b66a1a5f88a1579b1
      https://github.com/MythTV/mythtv/commit/7562f38e95815b2dfbf99d4b66a1a5f88a1579b1
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.h

  Log Message:
  -----------
  Initial mpegts-mythtv.h harmonization

Note: most of the defines aren't actually used


  Commit: 2d8c8d948957fd198894f75cd1bb2267dae36190
      https://github.com/MythTV/mythtv/commit/2d8c8d948957fd198894f75cd1bb2267dae36190
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mov.c

  Log Message:
  -----------
  Revert "libavformat/mov.c: increase allowed time error"

This reverts commit 346d4dbbf0babc5b5bc4743afd26ee997667ea7c.

from:
changed: allow 4 second skew between streams in mov before attempting to seek https://github.com/MythTV/mythtv/commit/e4170c604e6a6af969e5de74ac740ac596686da8

No reason given for the change.


  Commit: 9e6c00ffd2a25b628695f7a5f6f6278a12ee4a6a
      https://github.com/MythTV/mythtv/commit/9e6c00ffd2a25b628695f7a5f6f6278a12ee4a6a
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpeg4videodec.c

  Log Message:
  -----------
  Revert "libavcodec/mpeg4videodec.c"

This reverts commit 9632275126d4e6a698569c9d4316a300fe98d18f.

I agree with stuartm’s decade old comment on MythTV ticket 3001: H.263 is not a commonly used codec and if these are still bugs, they should be (re-)opened upstream with FFmpeg.

For frame rate “fix” see: October 2005
Closes #509, by applying patch. https://github.com/MythTV/mythtv/commit/f851316ffc438d3570ee47ab87d4ad961d36bb4e

however, it has been wrong since October 2014:
Merge commit '7ea1b3472a61de4aa4d41b571e99418e4997ad41'
https://github.com/FFmpeg/FFmpeg/commit/17085a0251a1493f6447aa3d2ee06fda2c9402f0

lavc: deprecate the use of AVCodecContext.time_base for decoding
https://github.com/FFmpeg/FFmpeg/commit/7ea1b3472a61de4aa4d41b571e99418e4997ad41

-----
for not compiled section see:
Revert [25805], the fix for our workaround created playback problems https://github.com/MythTV/mythtv/commit/eaa8f0dd129ee1bc6b7be2ba76fb98460bf57ec3

nuv: fix mpeg4 decoding issue in #3001 properly https://github.com/MythTV/mythtv/commit/8082c91bba961af747ecc81a029c6d7bd7eadc4a

MPEG-4 decode errors as of [12645] https://code.mythtv.org/trac/ticket/3001

Trunk unable to playback MPEG4 files created by mythtranscode https://code.mythtv.org/trac/ticket/8927


  Commit: ef08e10f99e96c38fcb90640ffeceaddddef2c35
      https://github.com/MythTV/mythtv/commit/ef08e10f99e96c38fcb90640ffeceaddddef2c35
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegaudiodec_template.c

  Log Message:
  -----------
  Revert "MythTV: suppress errors from old .nuv files"

This reverts commit 6c8c3809732f9400293b0a5a82bf5f5db71d82c2.

from 2007-05-28: https://github.com/MythTV/mythtv/commit/ef017db37b842417d1a47131df34fbe4e1defd2b
references: https://code.mythtv.org/trac/ticket/2972


  Commit: 3877864a35731be57764d33c0864473a5b207a4d
      https://github.com/MythTV/mythtv/commit/3877864a35731be57764d33c0864473a5b207a4d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  silence mpegts-mythtv.c warning: mpegts_probe -Wincompatible-pointer-types


  Commit: 2261220a603a99b1ce9d1055201db865c3befbde
      https://github.com/MythTV/mythtv/commit/2261220a603a99b1ce9d1055201db865c3befbde
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup PMT patch lavf/utils.c


  Commit: 7c4e6dea4fb681c2ed6fa406706b8036f44dd0ab
      https://github.com/MythTV/mythtv/commit/7c4e6dea4fb681c2ed6fa406706b8036f44dd0ab
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  revert unnecessary null check in lavf/utils.c

st->codec is deprecated and appears to be unused in the guarded code

st should be non-null based on the for loop condition


  Commit: 9f5da59986b16e4d999e366b4af1d92fbdce705a
      https://github.com/MythTV/mythtv/commit/9f5da59986b16e4d999e366b4af1d92fbdce705a
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  Revert "lavf/utils.c: don't compile some debug log messages"

This reverts commit 1d3e96d200a035334eab79de0f4880453adf219e.

See https://trac.ffmpeg.org/ticket/1344
If this is still an issue, the FFmpeg ticket should be reopened with a sample.


  Commit: a880c0fbd550e34486c15cbb9e1acdf6eb5c466e
      https://github.com/MythTV/mythtv/commit/a880c0fbd550e34486c15cbb9e1acdf6eb5c466e
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  fixup dvbsubdec.c: remove unused variables


  Commit: 123583e07bf2d9bfa0d2916eb170da8f9fb16292
      https://github.com/MythTV/mythtv/commit/123583e07bf2d9bfa0d2916eb170da8f9fb16292
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup lavf MHEG changes: remove unused got_frame


  Commit: f5973adbf9b3c422ac01b98cef735f3e66fc94a6
      https://github.com/MythTV/mythtv/commit/f5973adbf9b3c422ac01b98cef735f3e66fc94a6
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/libavformat.v
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup lavf/utils-mythtv.c: remove unused code, don't expose unused symbols


  Commit: 47bc6352db7d4292636c3412236ca935cad3d68e
      https://github.com/MythTV/mythtv/commit/47bc6352db7d4292636c3412236ca935cad3d68e
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpeg.c

  Log Message:
  -----------
  ffmpeg lavf/mpeg.c: fix indentation


  Commit: ce40007d9719f57fed911e61a8caf33ce2443a5d
      https://github.com/MythTV/mythtv/commit/ce40007d9719f57fed911e61a8caf33ce2443a5d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  revert MythTV 'DVB Subtitles: Fix display of subs with no display segment.'

from https://github.com/MythTV/mythtv/commit/d27bedf5571bdb80c164ce5d11a8af55f0275b92

Fixed 6 months later in FFmpeg (a decade ago):
Fix dvb subtitle decoding when display segment is missing.
https://github.com/FFmpeg/FFmpeg/commit/7df9937fcc6a91ce4763dfa1ea6fc331f7e77295


  Commit: 716757b4e3e4468bd9964482f6a2db3bde8f3fc9
      https://github.com/MythTV/mythtv/commit/716757b4e3e4468bd9964482f6a2db3bde8f3fc9
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: remove unused MythTV addition build_index

originally from https://github.com/MythTV/mythtv/commit/3539d581feeb0cbb9d6b7a3a077b27b9ec7693b9

also fixup comment spacing


  Commit: b59d358fe2ebfa57a768137039c24064ea06b9bd
      https://github.com/MythTV/mythtv/commit/b59d358fe2ebfa57a768137039c24064ea06b9bd
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c
    M mythtv/external/FFmpeg/libavutil/frame.h

  Log Message:
  -----------
  ffmpeg: trim trailing whitespace


  Commit: 465afeecb461fa675cafeaebad48084f65f30269
      https://github.com/MythTV/mythtv/commit/465afeecb461fa675cafeaebad48084f65f30269
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/internal.h

  Log Message:
  -----------
  Revert "libavcodec/internal.h: fix compilation with MSVC"

This reverts commit 066a0866f3cccbde7b65cda0a4b24b3c95ebf3be.


  Commit: 20afdaa226c4009526e98e49ef655b732d102aa5
      https://github.com/MythTV/mythtv/commit/20afdaa226c4009526e98e49ef655b732d102aa5
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/isom.h

  Log Message:
  -----------
  revert 'MythTV: class is a reserved keyword in C++'

This change has been unnecessary since 3d21dadbc797298df112aa0838125c7b3ab384f9.


  Commit: 4fa3ce1b20ccbbd3c90fb10d911c24e07f4f9663
      https://github.com/MythTV/mythtv/commit/4fa3ce1b20ccbbd3c90fb10d911c24e07f4f9663
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegaudio_parser.c

  Log Message:
  -----------
  lavc/mpegaudio_parser.c: revert MythTV workaround

originally from https://github.com/MythTV/mythtv/commit/0bc16040176a1caf61068f42272b63698751d7dc
referencing https://code.mythtv.org/trac/ticket/8260

References https://github.com/MythTV/mythtv/issues/428

If this causes an issue, a new ticket with logs and a sample should be openned.


  Commit: aec092bd30a41a1449b1c361f184caa88404498d
      https://github.com/MythTV/mythtv/commit/aec092bd30a41a1449b1c361f184caa88404498d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.h
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c

  Log Message:
  -----------
  mpegts-mythtv.h: don't expose mpegts_remove_stream()

working toward merging utils-mythtv.c back into utils.c


  Commit: 4445b96285fe1208f74835075f4a45991e4d9c75
      https://github.com/MythTV/mythtv/commit/4445b96285fe1208f74835075f4a45991e4d9c75
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/Makefile
    R mythtv/external/FFmpeg/libavformat/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: merge utils-mythtv.c back into utils.c


  Commit: 22172eda3d425ff4eaed022b5f54c853458fb0e0
      https://github.com/MythTV/mythtv/commit/22172eda3d425ff4eaed022b5f54c853458fb0e0
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: export flush_packet_queue() as mythtv_flush_packet_queue()

FFmpeg 5.0 renames and exports this as ff_flush_packet_queue().

This change is intended to make transitioning to FFmpeg 5.0 easier.

Technically, this should be in libavformat/internal.h, but, since it is currently
unmodified, libavformat/avformat.h will work for now.  (MythTV does not directly use
this function.)


  Commit: 71e89916ce7d8aca169b2d62db8118b980095986
      https://github.com/MythTV/mythtv/commit/71e89916ce7d8aca169b2d62db8118b980095986
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf/utils.c: silence -Wdeclaration-after-statement


  Commit: 721fd5f67490afa5fcbe19970e85ec1eba5477ea
      https://github.com/MythTV/mythtv/commit/721fd5f67490afa5fcbe19970e85ec1eba5477ea
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpeg12dec.c

  Log Message:
  -----------
  libavcodec/mpeg12dec.c: silence -Wunused-variable from MythTV modification


  Commit: 91ef3cea22d852b8cb2f67b5b1b5721b1591686a
      https://github.com/MythTV/mythtv/commit/91ef3cea22d852b8cb2f67b5b1b5721b1591686a
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  lavf/mpegts-mythtv.c: silence -Wdeclaration-after-statement


  Commit: 97997caeb624dc33cade7cb1d54a4ec0fe66f80d
      https://github.com/MythTV/mythtv/commit/97997caeb624dc33cade7cb1d54a4ec0fe66f80d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wformat

st is a pointer not an unsigned int.


  Commit: de62b37b08d0c2dee50a7fbaffa116da0a3977da
      https://github.com/MythTV/mythtv/commit/de62b37b08d0c2dee50a7fbaffa116da0a3977da
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wunused-variable


  Commit: cf448e0049848b2f31d701d7cc0acf5e7837975d
      https://github.com/MythTV/mythtv/commit/cf448e0049848b2f31d701d7cc0acf5e7837975d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wundef


  Commit: df7cb9b0a3bf2a746f26e93386215aefbe8ef051
      https://github.com/MythTV/mythtv/commit/df7cb9b0a3bf2a746f26e93386215aefbe8ef051
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wunused-function


  Commit: f76dca56c9cdd999582832dfd4beb6cf0996db1e
      https://github.com/MythTV/mythtv/commit/f76dca56c9cdd999582832dfd4beb6cf0996db1e
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wdiscarded-qualifiers

The warning was:

libavformat/mpegts-mythtv.c: In function ‘pmt_cb’:
libavformat/mpegts-mythtv.c:1971:14: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1971 |         tmp0 = avctx->cur_pmt_sect;
      |              ^


  Commit: 9f2b5649ea9fdd3be985e3b0110d8a794074da9a
      https://github.com/MythTV/mythtv/commit/9f2b5649ea9fdd3be985e3b0110d8a794074da9a
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: move MythTV only stuff first

This is intended to make copying over the current FFmpeg mpegts.c produce a better diff.

No functional change.


  Commit: c4ff976d78d6b99ec023a22514930f80f40228b8
      https://github.com/MythTV/mythtv/commit/c4ff976d78d6b99ec023a22514930f80f40228b8
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    M mythtv/external/FFmpeg/libavformat/libavformat.v

  Log Message:
  -----------
  FFmpeg: remove now unecessary added exports


  Commit: 545d50976cfe7d942ff5ee9e3bfceb3fdc767500
      https://github.com/MythTV/mythtv/commit/545d50976cfe7d942ff5ee9e3bfceb3fdc767500
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  libavformat/utils.c: av_remove_stream() #if 0 the entire if else ladder

This was from https://github.com/MythTV/mythtv/commit/9cb02dee588127240fb8a843ed92347a33c7e0e1

when it was still part of utils.c.


  Commit: 610a6e579af95043e0649fa71d7ba354f3e5ebbc
      https://github.com/MythTV/mythtv/commit/610a6e579af95043e0649fa71d7ba354f3e5ebbc
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  libavformat/utils.c: silence final MythTV warning

No functional change, but AVStream.codec was removed in FFmpeg 5.0.

This should enable it to compile with FFmpeg 5.0, since it will then be
not compiled.


  Commit: 7bf54e5e8d1e0895ba6da6c9d31ecd333bec7029
      https://github.com/MythTV/mythtv/commit/7bf54e5e8d1e0895ba6da6c9d31ecd333bec7029
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/os_support.h

  Log Message:
  -----------
  lavf/os_support.h: remove MythTV customization

that silenced a compiler warning, but this file is no longer included
by MythTV, so the change is no longer necessary.


  Commit: 958bd77eaf9b3e298b7234e9a8a8cc5c87be4004
      https://github.com/MythTV/mythtv/commit/958bd77eaf9b3e298b7234e9a8a8cc5c87be4004
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.h

  Log Message:
  -----------
  mpegts-mythtv.h: harmonize with mpegts.h

Almost a superset.  Different function names and ff_parse_mpeg2_descriptor()
takes an extra parameter.


  Commit: 02441add5956a0eb1e2522120d6ee56fb2a396cc
      https://github.com/MythTV/mythtv/commit/02441add5956a0eb1e2522120d6ee56fb2a396cc
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-06-14 (Tue, 14 Jun 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  mpegts-mythtv.c: export disposition from ISO_639_LANGUAGE_DESCRIPTOR

This replaces the use of the MythTV added, exported PMT for detecting
these in AvFormatDecoder::GetAudioTrackType().

disposition is copied over to the AVStream in mpegts_add_stream().

language is only 4 bytes, so don't write past the end.
i.e. the loop is invalid.


Compare: https://github.com/MythTV/mythtv/compare/beba76345e97...02441add5956


More information about the mythtv-commits mailing list