[mythtv-commits] [MythTV/mythtv] 7cd9a3: Flip the ALLOWLASTPLAYPOS flag to become the IGNOR...

Sat Jan 15 13:31:01 UTC 2022

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 7cd9a3c376384d5a9cbd77f01effc55c7ec28b12
      https://github.com/MythTV/mythtv/commit/7cd9a3c376384d5a9cbd77f01effc55c7ec28b12
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmyth/programtypeflags.h
    M mythtv/libs/libmyth/test/test_programinfo/test_programinfo.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/programs/mythfrontend/playbackbox.cpp

  Log Message:
  -----------
  Flip the ALLOWLASTPLAYPOS flag to become the IGNORELASTPLAYPOS flag.

This brings the flag into line with the other IGNORExxx flags. Given
that the last play position is never set, this change should have no
effect on the code.

  Commit: c6569589a82d341f902cb30ddb3866c4f68a2924
      https://github.com/MythTV/mythtv/commit/c6569589a82d341f902cb30ddb3866c4f68a2924
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M mythtv/bindings/perl/MythTV.pm
    M mythtv/bindings/python/MythTV/static.py
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmyth/programtypeflags.h
    M mythtv/libs/libmythbase/mythversion.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayerui.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.h
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h

  Log Message:
  -----------
  Seperate the concepts of last play position and bookmarks.

The last play position is now always recorded on program exit (if
playback has been going for at least 30 sec).  The bookmark is now
solely set and cleared by the user. By default, playback now starts from:

  1) last played position, if present
  2) bookmark, if present
  3) program start mark, if present (recordings only)
  4) beginning of file

This is based on Roger Siddons work from 2015. See
https://code.mythtv.org/trac/ticket/12809 for the full details.

  Commit: 36c90f16adf0ebf7436d29f93c5cfa80b5c87fce
      https://github.com/MythTV/mythtv/commit/36c90f16adf0ebf7436d29f93c5cfa80b5c87fce
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythfrontend/viewscheduled.h

  Log Message:
  -----------
  Split part of ViewScheduled::FillList into a separate function.

  Commit: 64524d09710cd614740eda24586341827a39de57
      https://github.com/MythTV/mythtv/commit/64524d09710cd614740eda24586341827a39de57
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M mythtv/themes/MythCenter-wide/recordings-ui.xml
    M mythtv/themes/MythCenter/recordings-ui.xml

  Log Message:
  -----------
  Fix indentation of MythCenter* recordings-ui.xml.

  Commit: c0a56f6260b1172aff4091e2c3264d50ded6fad4
      https://github.com/MythTV/mythtv/commit/c0a56f6260b1172aff4091e2c3264d50ded6fad4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-14 (Fri, 14 Jan 2022)

  Changed paths:
    M mythtv/themes/MythCenter-wide/recordings-ui.xml
    M mythtv/themes/MythCenter/recordings-ui.xml

  Log Message:
  -----------
  Add missing "inactive states" to MythCenter* recordings-ui.xml.

These simply make the "inactive" state the same as the "active"
state. Given that the only difference from "selected inactive" to
"selected active" states is the latter has a font ending with
"_selected", this seems reasonable.

  Commit: 241d26d42ed625b069d9f8412030679429b14ca5
      https://github.com/MythTV/mythtv/commit/241d26d42ed625b069d9f8412030679429b14ca5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2022-01-15 (Sat, 15 Jan 2022)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmythbase/libmythbase.pro
    A mythtv/libs/libmythbase/mconcurrent.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.cpp
    M mythtv/libs/libmythui/mythuibuttonlist.h
    M mythtv/libs/libmythui/mythuiprogressbar.cpp
    M mythtv/libs/libmythui/mythuiprogressbar.h
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/programinfocache.cpp
    M mythtv/programs/mythfrontend/programinfocache.h
    M mythtv/programs/mythfrontend/programrecpriority.cpp
    M mythtv/programs/mythfrontend/viewscheduled.cpp
    M mythtv/programs/mythfrontend/viewscheduled.h
    M mythtv/themes/MythCenter-wide/base.xml
    M mythtv/themes/MythCenter-wide/recordings-ui.xml
    M mythtv/themes/MythCenter-wide/schedule-ui.xml
    M mythtv/themes/MythCenter-wide/themeinfo.xml
    M mythtv/themes/MythCenter/base.xml
    M mythtv/themes/MythCenter/recordings-ui.xml
    M mythtv/themes/MythCenter/schedule-ui.xml
    M mythtv/themes/MythCenter/themeinfo.xml

  Log Message:
  -----------
  Add percentage finished to "View Recordings" and "Upcoming Recordings".

Buttonlist buttons can now contain a progressbar, as an intuitive way
to show contextual "progress".  This is up to the theme.

"Watch Recordings" uses it to show playback position. Previews aren't
regenerated whilst a file is in use, so playback by another frontend
only updates the progress bar/counter, until playback ceases.

"Upcoming Recordings" uses the bar to show the progress of time for
recordings - it will progress to 100% for failing (0-byte)
recordings. Filesize is also available for "Upcoming Recordings" now
(although Scheduler Updates will reset it to 0.00 for 10 secs)

A percentage progress value is also provided that can be used for
sorting, or as a "depends" for a 'part-watched' icon. This can also be
used in text templates.

The modified MythCenter and MythCenter-Wide themes demonstrate the UI
changes by using putting a progress bar behind the show title in the
"View Recordings" and "Upcoming Recordings" pages.

Video Library has no UI indication of progress.

This is based on Roger Siddons work from 2015. See
https://code.mythtv.org/trac/ticket/12809 for the full details.

---

The MythUIButtonListItem now supports two progress bars called
"buttonprogress1" and "buttonprogress2" that may be used for any
purpose.

The ProgramInfo object now provides new "recordedpercent" and
"watchedpercent" strings, that can be use to display the percentage of
the program already recorded/watched at any place that other items can
be displayed from the result of ProgramInfo::ToMap. These values are
not continuously calculated, but must be set by the frontend code
before calling ProgramInfo::ToMap.

The "watchrecordings" screen described in the "recordings-ui.xml"
theme file supports two additional progressbars ("recordedprogressbar"
and "watchedprogressbar") anywhere on the screen that will graphically
display the the percentage of the program recorded/watched. The
recorded progress bar is only available while MythTV is actively
recording. It also updates the new button list item progress bars with
the watched and recorded percentages.

The "viewscheduled" screen described in the "schedule-ui.xml" theme
file can embed a progressbar named "recordedprogressbar" anywhere on
the screen that will graphically display the the percentage of the
program already recorded. Again, only available while MythTV is
actively recording. It also updates the second new button list item
progress bar with the recorded percent.

Note: MythTV does not currently remember the time of the last write of
video data, so the "percent recorded" timings are based on wall clock
time. A future enhancement could be to remember the time of the last
write of video data and compare that to the start/end times of the
recording.

Fixes #331.

Compare: https://github.com/MythTV/mythtv/compare/8aa146829b17...241d26d42ed6