[mythtv-commits] [MythTV/mythtv] 5918b9: H2645Parser.h: silence -Wundef

Scott Theisen noreply at github.com
Thu Feb 10 22:08:30 UTC 2022


  Branch: refs/heads/devel/ffmpeg-resync
  Home:   https://github.com/MythTV/mythtv
  Commit: 5918b95506070049811c1615ff3612a97c37ba03
      https://github.com/MythTV/mythtv/commit/5918b95506070049811c1615ff3612a97c37ba03
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h

  Log Message:
  -----------
  H2645Parser.h: silence -Wundef

1 instead of 0 because that is what is in FFmpeg/config.h


  Commit: e663ab4fcdc34f8f47d489c6e06a99d47c91e639
      https://github.com/MythTV/mythtv/commit/e663ab4fcdc34f8f47d489c6e06a99d47c91e639
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h

  Log Message:
  -----------
  H2645Parser.h: remove unused defines


  Commit: 138975dc35acd0d4173568fc56c6c66a8c85743d
      https://github.com/MythTV/mythtv/commit/138975dc35acd0d4173568fc56c6c66a8c85743d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

  Log Message:
  -----------
  Remove include libavcodec/get_bits.h from headers

Because of how FFmpeg has shoehorned OOP into C, almost everything is passed
as pointers.  Thus, a forward declaration of the struct will suffice.

Also, get_bits.h is a horrible, macro infested file.
std::bitset is a possible replacement; however, no further investigation
has been done at this time.

If necessary, the hack can be added to each .cpp file.


  Commit: b0705c8243d6909b0ad2f3e24c58a797d67f8f6b
      https://github.com/MythTV/mythtv/commit/b0705c8243d6909b0ad2f3e24c58a797d67f8f6b
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp

  Log Message:
  -----------
  H2645Parser.cpp: remove unnecessary float -> double casts


  Commit: 8e5977ef289792dca775346681f0505129463042
      https://github.com/MythTV/mythtv/commit/8e5977ef289792dca775346681f0505129463042
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  remove vestiges of ffmpeg addition build_index

The change to ffmpeg does nothing and is being removed to reduce MythTV's
downstream changes to FFmpeg, hopefully culminating in an unmodified FFmpeg.

avformatdecoder.cpp probably needs more cleanup, but this is the minimal change
required to enable the removal of build_index from FFmpeg.


  Commit: fbc2f844ea00d73ebf51c887cb421d8f7f83d823
      https://github.com/MythTV/mythtv/commit/fbc2f844ea00d73ebf51c887cb421d8f7f83d823
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

  Log Message:
  -----------
  Suppress warnings from internal FFmpeg headers

Do this in the .cpp files that use them, to enable removing the changes
to the FFmpeg headers themselves.


  Commit: 51a798c26737b25553ab4509ed209c3415f64c84
      https://github.com/MythTV/mythtv/commit/51a798c26737b25553ab4509ed209c3415f64c84
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp

  Log Message:
  -----------
  mpeg2fix.cpp: remove use of internal FFmpeg header

This file still needs to be completely rewritten to use only FFmpeg
and enable "lossless" cutting of other codecs.


  Commit: 139b5705a013e3584202a59892fe4ce476077b4b
      https://github.com/MythTV/mythtv/commit/139b5705a013e3584202a59892fe4ce476077b4b
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    M mythtv/external/FFmpeg/libavcodec/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  remove FFmpeg addition ff_codec_type_string()

replace with av_get_media_type_string in ffmpeg and copy to only
user: libs/libmythtv/decoders/avformatdecoder.cpp


  Commit: da654e7f2e60d6fac030e686decaedc67fcf8d34
      https://github.com/MythTV/mythtv/commit/da654e7f2e60d6fac030e686decaedc67fcf8d34
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  eliminate ffmpeg modification by including an internal header

Technically, libavcodec.v is still modified to expose the internal function.

Ideally, the use of the internal function would be eliminated, but that is
beyond the current scope of work.


  Commit: add5025ea62188a2b861120f9ae2e3bd8fe9c52c
      https://github.com/MythTV/mythtv/commit/add5025ea62188a2b861120f9ae2e3bd8fe9c52c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/codec_desc.c

  Log Message:
  -----------
  add MPEG2VBI and DVB_VBI to codec_desc.c

This enables removing libavcodec/utils-mythtv.c


  Commit: 1e3bcc840cf51bae78be4be58306b4c564433ce4
      https://github.com/MythTV/mythtv/commit/1e3bcc840cf51bae78be4be58306b4c564433ce4
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputdigitalencoder.cpp
    M mythtv/libs/libmyth/audio/spdifencoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.h
    M mythtv/libs/libmythtv/decoders/mythcodeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvtbcontext.cpp
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/recorders/recorderbase.cpp
    M mythtv/libs/libmythtv/recordingfile.h

  Log Message:
  -----------
  replace ff_codec_id_string() with avcodec_get_name()

This enables removing libavcodec/utils-mythtv.c

The returned string is now lower case, instead of all capital letters; however, I don't anticipate that being an issue.


  Commit: 93b6bc25cfed312a6cdbc33ea23c1c65bcd9fb93
      https://github.com/MythTV/mythtv/commit/93b6bc25cfed312a6cdbc33ea23c1c65bcd9fb93
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/Makefile
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    R mythtv/external/FFmpeg/libavcodec/utils-mythtv.c

  Log Message:
  -----------
  remove (now unused) FFmpeg/libavcodec/utils-mythtv.c


  Commit: 1073aa1601e6be223fd94755070741fc4167dcb6
      https://github.com/MythTV/mythtv/commit/1073aa1601e6be223fd94755070741fc4167dcb6
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf/utils.c: remove unused extern declarations


  Commit: b7f315baa26d8754ca3d83958e4d3902cf669185
      https://github.com/MythTV/mythtv/commit/b7f315baa26d8754ca3d83958e4d3902cf669185
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c

  Log Message:
  -----------
  lavf: move MythTV added define to the only file using it

this quiets a warning about it being redefined elsewhere in ffmpeg


  Commit: c114a31c7fd51bcdfa70a1a63c672821e0912f01
      https://github.com/MythTV/mythtv/commit/c114a31c7fd51bcdfa70a1a63c672821e0912f01
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h

  Log Message:
  -----------
  fix MythTV C++ change, register is still valid C


  Commit: 5f712716aefff94c4b8273556eedbc534c5c6c3f
      https://github.com/MythTV/mythtv/commit/5f712716aefff94c4b8273556eedbc534c5c6c3f
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h

  Log Message:
  -----------
  lavc/get_bits.h: revert unnecessary removal of register keyword


  Commit: 68c350aa9b11c8790ba10b3c91ebb958d2172bd1
      https://github.com/MythTV/mythtv/commit/68c350aa9b11c8790ba10b3c91ebb958d2172bd1
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/postprocess.c

  Log Message:
  -----------
  lpp: revert unnecessary added include

seems to have been added during an ffmpeg merge, but is unused


  Commit: 86709cf3fb64aa81dad2c4b70f8fdd29eb38c1fa
      https://github.com/MythTV/mythtv/commit/86709cf3fb64aa81dad2c4b70f8fdd29eb38c1fa
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/postprocess.c

  Log Message:
  -----------
  lpp: revert unnecessary MythTV cpu autodetect

This is from 2010-08-24:
detect available SIMD extensions when runtime-cpudetect is enabled
https://github.com/MythTV/mythtv/commit/206974153a539acd72451512ac6a7aae818d0fe9

but if you look at the following lines, ffmpeg has effectively the same since 2012-11-18:
pp: add auto detection cpu flag.
https://github.com/FFmpeg/FFmpeg/commit/59d686f100863d00b8f171dd891e893c2bfd951e


  Commit: 1a3eb84f3e1ca5e081d0fc69d35470236fa27abf
      https://github.com/MythTV/mythtv/commit/1a3eb84f3e1ca5e081d0fc69d35470236fa27abf
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libpostproc/Makefile

  Log Message:
  -----------
  lpp: revert change to Makefile

if ffmpeg doesn't need this, neither do we


  Commit: 2898113f9d5a9f357efe22c5220a2657faa120c8
      https://github.com/MythTV/mythtv/commit/2898113f9d5a9f357efe22c5220a2657faa120c8
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  lavc/dvbsubdec.c: remove redundant conditional statements

from: https://github.com/MythTV/mythtv/commit/68ca96cfa02b9df406de4ad233fdb395405f6b88

duplicates the condition on line 919, which will catch it and return


  Commit: 01082f25bc98af4ffa8ef9d68355f4c5be0339a3
      https://github.com/MythTV/mythtv/commit/01082f25bc98af4ffa8ef9d68355f4c5be0339a3
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegvideo.h

  Log Message:
  -----------
  lavc/mpegvideo.h: revert unnecessary changes

class: C++ keyword, but MythTV does not include this file

removed parentheses resulted from a complier warning about
"unnecessary parentheses"


  Commit: 5fc46d744e05c41fdff15c68d98ac75ccf381f4f
      https://github.com/MythTV/mythtv/commit/5fc46d744e05c41fdff15c68d98ac75ccf381f4f
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.h

  Log Message:
  -----------
  Initial mpegts-mythtv.h harmonization

Note: most of the defines aren't actually used


  Commit: 8d519f948e12fdb6160cc430e532fb563f6a9762
      https://github.com/MythTV/mythtv/commit/8d519f948e12fdb6160cc430e532fb563f6a9762
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h

  Log Message:
  -----------
  Revert "fix MythTV C++ change, register is still valid C"

This reverts commit 1711295940e756102498dc020f8bff5f8e2c05a3.

The warnings are now suppressed in the files that include the internal headers.


  Commit: fb19566ebcefe6c4a6a602edd44bd84989d714a8
      https://github.com/MythTV/mythtv/commit/fb19566ebcefe6c4a6a602edd44bd84989d714a8
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h
    M mythtv/external/FFmpeg/libavcodec/golomb.h

  Log Message:
  -----------
  Revert "Quiet a couple of "Null Dereference" warnings from clang-tidy."

This reverts commit 18cc06cc035d6d5964aa28cc7bf02cf0b6b5876f.


  Commit: 3bbd0cee28d12e40b4af4ea09a60f14aa51bf8f7
      https://github.com/MythTV/mythtv/commit/3bbd0cee28d12e40b4af4ea09a60f14aa51bf8f7
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h

  Log Message:
  -----------
  Revert "Fix compiler "storage class" and "unused parameter" warnings."

This reverts commit 26f1bbd2909c431988c65e6cfe22de32baa76fe0.


  Commit: 1d51c6eb2f297d19806538b0b64eb0fc486ab499
      https://github.com/MythTV/mythtv/commit/1d51c6eb2f297d19806538b0b64eb0fc486ab499
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h
    M mythtv/external/FFmpeg/libavcodec/golomb.h
    M mythtv/external/FFmpeg/libavformat/os_support.h

  Log Message:
  -----------
  Revert "MythTV: quiet compiler warnings"

This reverts commit e70a6c007d8a23e9a3690fd65f1bfd5ad1cb9027.


  Commit: d9db75362e2c1d5fd863ded2e147f1408f4ba714
      https://github.com/MythTV/mythtv/commit/d9db75362e2c1d5fd863ded2e147f1408f4ba714
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mov.c

  Log Message:
  -----------
  Revert "libavformat/mov.c: increase allowed time error"

This reverts commit 346d4dbbf0babc5b5bc4743afd26ee997667ea7c.

from:
changed: allow 4 second skew between streams in mov before attempting to seek https://github.com/MythTV/mythtv/commit/e4170c604e6a6af969e5de74ac740ac596686da8

No reason given for the change.


  Commit: c12513aa87bc403d4c4e79ad653fcbb76065afa7
      https://github.com/MythTV/mythtv/commit/c12513aa87bc403d4c4e79ad653fcbb76065afa7
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpeg4videodec.c

  Log Message:
  -----------
  Revert "libavcodec/mpeg4videodec.c"

This reverts commit 9632275126d4e6a698569c9d4316a300fe98d18f.

I agree with stuartm’s decade old comment on MythTV ticket 3001: H.263 is not a commonly used codec and if these are still bugs, they should be (re-)opened upstream with FFmpeg.

For frame rate “fix” see: October 2005
Closes #509, by applying patch. https://github.com/MythTV/mythtv/commit/f851316ffc438d3570ee47ab87d4ad961d36bb4e

however, it has been wrong since October 2014:
Merge commit '7ea1b3472a61de4aa4d41b571e99418e4997ad41'
https://github.com/FFmpeg/FFmpeg/commit/17085a0251a1493f6447aa3d2ee06fda2c9402f0

lavc: deprecate the use of AVCodecContext.time_base for decoding
https://github.com/FFmpeg/FFmpeg/commit/7ea1b3472a61de4aa4d41b571e99418e4997ad41

-----
for not compiled section see:
Revert [25805], the fix for our workaround created playback problems https://github.com/MythTV/mythtv/commit/eaa8f0dd129ee1bc6b7be2ba76fb98460bf57ec3

nuv: fix mpeg4 decoding issue in #3001 properly https://github.com/MythTV/mythtv/commit/8082c91bba961af747ecc81a029c6d7bd7eadc4a

MPEG-4 decode errors as of [12645] https://code.mythtv.org/trac/ticket/3001

Trunk unable to playback MPEG4 files created by mythtranscode https://code.mythtv.org/trac/ticket/8927


  Commit: d726c4569e877c1ee0ea748d760bc495478b8f69
      https://github.com/MythTV/mythtv/commit/d726c4569e877c1ee0ea748d760bc495478b8f69
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegaudiodec_template.c

  Log Message:
  -----------
  Revert "MythTV: suppress errors from old .nuv files"

This reverts commit 6c8c3809732f9400293b0a5a82bf5f5db71d82c2.

from 2007-05-28: https://github.com/MythTV/mythtv/commit/ef017db37b842417d1a47131df34fbe4e1defd2b
references: https://code.mythtv.org/trac/ticket/2972


  Commit: a65f997fe6fd94cd725ea789962245d434512e6c
      https://github.com/MythTV/mythtv/commit/a65f997fe6fd94cd725ea789962245d434512e6c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  silence mpegts-mythtv.c warning: mpegts_probe -Wincompatible-pointer-types


  Commit: 7db2ae0e290a9ba479b696fd9e856fb088342ab5
      https://github.com/MythTV/mythtv/commit/7db2ae0e290a9ba479b696fd9e856fb088342ab5
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup PMT patch lavf/utils.c


  Commit: 8651339e0d963aebb7e927ec9b6a200175b52458
      https://github.com/MythTV/mythtv/commit/8651339e0d963aebb7e927ec9b6a200175b52458
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  revert unnecessary null check in lavf/utils.c

st->codec is deprecated and appears to be unused in the guarded code

st should be non-null based on the for loop condition


  Commit: 7f8688cfc3b9da1927fc2458e510261104fa4d48
      https://github.com/MythTV/mythtv/commit/7f8688cfc3b9da1927fc2458e510261104fa4d48
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  Revert "lavf/utils.c: don't compile some debug log messages"

This reverts commit 1d3e96d200a035334eab79de0f4880453adf219e.

See https://trac.ffmpeg.org/ticket/1344
If this is still an issue, the FFmpeg ticket should be reopened with a sample.


  Commit: cc44ecc0042ea282353017498bfa665b99e0318f
      https://github.com/MythTV/mythtv/commit/cc44ecc0042ea282353017498bfa665b99e0318f
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  fixup dvbsubdec.c: remove unused variables


  Commit: b74b03c90a89f286df1699762304e37a44131dc0
      https://github.com/MythTV/mythtv/commit/b74b03c90a89f286df1699762304e37a44131dc0
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup lavf MHEG changes: remove unused got_frame


  Commit: 7f0e2a658d48b3dfea446ef2e7f9e48e30b55589
      https://github.com/MythTV/mythtv/commit/7f0e2a658d48b3dfea446ef2e7f9e48e30b55589
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/libavformat.v
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  fixup lavf/utils-mythtv.c: remove unused code, don't expose unused symbols


  Commit: db3a181d19684dc45a06af7e40893c00c77dda68
      https://github.com/MythTV/mythtv/commit/db3a181d19684dc45a06af7e40893c00c77dda68
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/codec_desc.c

  Log Message:
  -----------
  ffmpeg codec_desc.c: remove duplicate dvd nav packet


  Commit: 740ca9130cac7328e20fc7684f4a1c33eeb53176
      https://github.com/MythTV/mythtv/commit/740ca9130cac7328e20fc7684f4a1c33eeb53176
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpeg.c

  Log Message:
  -----------
  ffmpeg lavf/mpeg.c: fix indentation


  Commit: 27c7b266e43b2fb247d7f9dcb52b7e319596b1db
      https://github.com/MythTV/mythtv/commit/27c7b266e43b2fb247d7f9dcb52b7e319596b1db
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c

  Log Message:
  -----------
  revert MythTV 'DVB Subtitles: Fix display of subs with no display segment.'

from https://github.com/MythTV/mythtv/commit/d27bedf5571bdb80c164ce5d11a8af55f0275b92

Fixed 6 months later in FFmpeg (a decade ago):
Fix dvb subtitle decoding when display segment is missing.
https://github.com/FFmpeg/FFmpeg/commit/7df9937fcc6a91ce4763dfa1ea6fc331f7e77295


  Commit: a53364b458cade3273e680bcb363dc1482e35222
      https://github.com/MythTV/mythtv/commit/a53364b458cade3273e680bcb363dc1482e35222
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: remove unused MythTV addition build_index

originally from https://github.com/MythTV/mythtv/commit/3539d581feeb0cbb9d6b7a3a077b27b9ec7693b9

also fixup comment spacing


  Commit: f4d0b689447eba2398691dafc872b54c9114310c
      https://github.com/MythTV/mythtv/commit/f4d0b689447eba2398691dafc872b54c9114310c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  replace deprecated for decoding AVCodecContex::time_base

decprecated since 2014 https://github.com/FFmpeg/FFmpeg/commit/7ea1b3472a61de4aa4d41b571e99418e4997ad41


  Commit: c3d2a2856f43886f7bfdc9ad1f3c7c6325bd73f1
      https://github.com/MythTV/mythtv/commit/c3d2a2856f43886f7bfdc9ad1f3c7c6325bd73f1
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  AvFormatDecoder::GetVideoFrameRate initial refactor


  Commit: da7d087b7dad9512c54dbf1677b10751a88359d1
      https://github.com/MythTV/mythtv/commit/da7d087b7dad9512c54dbf1677b10751a88359d1
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  AvFormatDecoder::GetVideoFrameRate use std::set

working toward not converting framerates to doubles


  Commit: 9fbec28396660bfa95439b03c05daf6b49efc01b
      https://github.com/MythTV/mythtv/commit/9fbec28396660bfa95439b03c05daf6b49efc01b
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  AVFormatDecoder: fixup ffmpeg includes

Sort includes,
suppress warning from internal header, and
replace unused internal header "libavformat/isom.h" with the used non-internal header "libavutil/stereo3d.h"


  Commit: ecf2b80c7ab7b45fc6ea561e451c6e6f9183e85d
      https://github.com/MythTV/mythtv/commit/ecf2b80c7ab7b45fc6ea561e451c6e6f9183e85d
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
    M mythtv/libs/libmythtv/HLS/httplivestreambuffer.h

  Log Message:
  -----------
  HLSbuffer: fixup includes

working toward removing internal ffmpeg headers from mythtv headers
remove unused includes
reorder includes


  Commit: 3d0e1a1b03a8e8c3167987fb6d72179fa7f11e22
      https://github.com/MythTV/mythtv/commit/3d0e1a1b03a8e8c3167987fb6d72179fa7f11e22
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythmediabuffer.cpp

  Log Message:
  -----------
  mythmediabuffer.cpp: fixup includes

replace mythcontext.h with mythcorecontext.h
sort includes


  Commit: c177c31d0a10f2da9ff5e9b19397be1289429c49
      https://github.com/MythTV/mythtv/commit/c177c31d0a10f2da9ff5e9b19397be1289429c49
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythstreamingbuffer.cpp
    M mythtv/libs/libmythtv/io/mythstreamingbuffer.h

  Log Message:
  -----------
  mythstreamingbuffer: remove internal FFmpeg header from MythTV header


  Commit: b17a958e4011c1829f030c7bdd57ec077023165e
      https://github.com/MythTV/mythtv/commit/b17a958e4011c1829f030c7bdd57ec077023165e
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.h
    M mythtv/libs/libmythtv/io/mythavformatbuffer.cpp
    M mythtv/libs/libmythtv/io/mythavformatbuffer.h
    M mythtv/libs/libmythtv/io/mythavformatwriter.cpp

  Log Message:
  -----------
  remove libavformat/url.h from most headers

I'm not sure how to remove it from avformatdecoder.h since it is not a pointer.
It appears to only be used in avformatdecoder.cpp in one place.

mythavformatbuffer: convert private class static into file static.
Somewhat hack-y, but equivalent.


  Commit: 6c648abae471b7a7040801226465b94b24867c21
      https://github.com/MythTV/mythtv/commit/6c648abae471b7a7040801226465b94b24867c21
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythavformatbuffer.cpp

  Log Message:
  -----------
  mythavformatbuffer.cpp: remove unused include


  Commit: cd05c468acfa46cf934823235715c4c07b6a5fba
      https://github.com/MythTV/mythtv/commit/cd05c468acfa46cf934823235715c4c07b6a5fba
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/dvbsubdec.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c
    M mythtv/external/FFmpeg/libavutil/frame.h

  Log Message:
  -----------
  ffmpeg: trim trailing whitespace


  Commit: d7472bfff02c76ef55cada6a2bc48e9548ca4860
      https://github.com/MythTV/mythtv/commit/d7472bfff02c76ef55cada6a2bc48e9548ca4860
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/internal.h

  Log Message:
  -----------
  Revert "libavcodec/internal.h: fix compilation with MSVC"

This reverts commit 066a0866f3cccbde7b65cda0a4b24b3c95ebf3be.


  Commit: e7309b4f6194ef145e3cc0636dfa7ad3c4366e26
      https://github.com/MythTV/mythtv/commit/e7309b4f6194ef145e3cc0636dfa7ad3c4366e26
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

  Log Message:
  -----------
  remove use of internal FFmpeg header: libavutil/internal.h

references https://github.com/MythTV/mythtv/issues/428

libavutil/internal.h appears to be for
```
// This can be enabled to allow detection of additional integer overflows with ubsan
//#define CHECKED
...
// For debuging we use signed operations so overflows can be detected (by ubsan)
// For production we use unsigned so there are no undefined operations
ifdef CHECKED
define SUINT   int
define SUINT32 int32_t
else
define SUINT   unsigned
define SUINT32 uint32_t
endif
```

`SUINT` is conditionally used once in libavcodec/golomb.h in `get_ur_golomb_jpegls()`, which is itself not used in the MythTV code.


  Commit: b716dcd0d997391d8d4afb2846b02ff104816902
      https://github.com/MythTV/mythtv/commit/b716dcd0d997391d8d4afb2846b02ff104816902
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/isom.h

  Log Message:
  -----------
  revert 'MythTV: class is a reserved keyword in C++'

This change has been unnecessary since 3d21dadbc797298df112aa0838125c7b3ab384f9.


  Commit: 056adb7a6c956dc16b4519efeb1802ccfee58eca
      https://github.com/MythTV/mythtv/commit/056adb7a6c956dc16b4519efeb1802ccfee58eca
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpegaudio_parser.c

  Log Message:
  -----------
  lavc/mpegaudio_parser.c: revert MythTV workaround

originally from https://github.com/MythTV/mythtv/commit/0bc16040176a1caf61068f42272b63698751d7dc
referencing https://code.mythtv.org/trac/ticket/8260

References https://github.com/MythTV/mythtv/issues/428

If this causes an issue, a new ticket with logs and a sample should be openned.


  Commit: 0f4b8df1a2b8489b2e923ed4c2299f527f151550
      https://github.com/MythTV/mythtv/commit/0f4b8df1a2b8489b2e923ed4c2299f527f151550
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.h
    M mythtv/external/FFmpeg/libavformat/utils-mythtv.c

  Log Message:
  -----------
  mpegts-mythtv.h: don't expose mpegts_remove_stream()

working toward merging utils-mythtv.c back into utils.c


  Commit: 620b91a9e979d7418ae5adbe59b7c4098687a8f6
      https://github.com/MythTV/mythtv/commit/620b91a9e979d7418ae5adbe59b7c4098687a8f6
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/Makefile
    R mythtv/external/FFmpeg/libavformat/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: merge utils-mythtv.c back into utils.c


  Commit: 12f1aa3694883df4bd37febc2c4bc000719c37c8
      https://github.com/MythTV/mythtv/commit/12f1aa3694883df4bd37febc2c4bc000719c37c8
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf: export flush_packet_queue() as mythtv_flush_packet_queue()

FFmpeg 5.0 renames and exports this as ff_flush_packet_queue().

This change is intended to make transitioning to FFmpeg 5.0 easier.

Technically, this should be in libavformat/internal.h, but, since it is currently
unmodified, libavformat/avformat.h will work for now.  (MythTV does not directly use
this function.)


  Commit: 7f2e79bb211523494a33f8c68f6819fd18d912f2
      https://github.com/MythTV/mythtv/commit/7f2e79bb211523494a33f8c68f6819fd18d912f2
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf/utils.c: fix compilation error 'parameter name omitted'


  Commit: edc11040cbf58fa3b921c95ec8b5975ad351f931
      https://github.com/MythTV/mythtv/commit/edc11040cbf58fa3b921c95ec8b5975ad351f931
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/utils.c

  Log Message:
  -----------
  lavf/utils.c: silence -Wdeclaration-after-statement


  Commit: 472492cdb9576abe559ad08ef2d1d906c25cf1de
      https://github.com/MythTV/mythtv/commit/472492cdb9576abe559ad08ef2d1d906c25cf1de
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/mpeg12dec.c

  Log Message:
  -----------
  libavcodec/mpeg12dec.c: silence -Wunused-variable from MythTV modification


  Commit: 86603398bc382253a556c800c1d2233d6a930b0b
      https://github.com/MythTV/mythtv/commit/86603398bc382253a556c800c1d2233d6a930b0b
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  lavf/mpegts-mythtv.c: silence -Wdeclaration-after-statement


  Commit: 70623409cbe5750d9cd1583963e34508e610a007
      https://github.com/MythTV/mythtv/commit/70623409cbe5750d9cd1583963e34508e610a007
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wformat

st is a pointer not an unsigned int.


  Commit: e91d3a9d67014708ac117c715ad1d9834e2ccb2c
      https://github.com/MythTV/mythtv/commit/e91d3a9d67014708ac117c715ad1d9834e2ccb2c
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wunused-variable


  Commit: 551a3a8c51709447070e12d96276b301ee9a161b
      https://github.com/MythTV/mythtv/commit/551a3a8c51709447070e12d96276b301ee9a161b
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wundef


  Commit: e624912f214a8eccdd6c5b536a9810f02455a3fa
      https://github.com/MythTV/mythtv/commit/e624912f214a8eccdd6c5b536a9810f02455a3fa
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wunused-function


  Commit: e8c59d4b6ad525fd28df5a15678bd15fb6e93b41
      https://github.com/MythTV/mythtv/commit/e8c59d4b6ad525fd28df5a15678bd15fb6e93b41
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: silence -Wdiscarded-qualifiers

The warning was:

libavformat/mpegts-mythtv.c: In function ‘pmt_cb’:
libavformat/mpegts-mythtv.c:1971:14: warning: assignment discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
 1971 |         tmp0 = avctx->cur_pmt_sect;
      |              ^


  Commit: f1eda69c8e63785d281aaeff7ef3814402b53d25
      https://github.com/MythTV/mythtv/commit/f1eda69c8e63785d281aaeff7ef3814402b53d25
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c

  Log Message:
  -----------
  libavformat/mpegts-mythtv.c: move MythTV only stuff first

This is intended to make copying over the current FFmpeg mpegts.c produce a better diff.

No functional change.


  Commit: a0d374fa9e14b810ae83f86b902342b646ba85db
      https://github.com/MythTV/mythtv/commit/a0d374fa9e14b810ae83f86b902342b646ba85db
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.h

  Log Message:
  -----------
  mythtranscode/mpeg2fix: precompute inverse zigzag scan


  Commit: a9e5eee4bbefb74dd7b0a606ac555c7b37929ba8
      https://github.com/MythTV/mythtv/commit/a9e5eee4bbefb74dd7b0a606ac555c7b37929ba8
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    A mythtv/libs/libmythtv/bytereader.cpp
    A mythtv/libs/libmythtv/bytereader.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  Eliminate use of #include "libavcodec/internal.h"

by copying avpriv_find_start_code() into MythTV as ByteReader::find_start_code().

Refs: https://github.com/MythTV/mythtv/issues/428

Note: I have rewritten this function.  The only functional change is
00 00 01 00 01 XX no longer incorrectly returns a start code at
offset 7 that overlaps the start code at offset 4 if the start_code
input is not modified between the two calls.

The new parameter is always false in MythTV for no functional change.
Several uses are explicit about using the history in the comments
prior to the call.

However, FFmpeg only has one use that keeps the history,
(ff_)mpeg1_find_frame_end().


  Commit: af18107ad0005bb1844638fb9a69f26920d0bf57
      https://github.com/MythTV/mythtv/commit/af18107ad0005bb1844638fb9a69f26920d0bf57
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  avformatdecoder.cpp: remove '#include "libavformat/internal.h"'

refs: https://github.com/MythTV/mythtv/issues/428

ff_read_frame_flush() is an internal FFmpeg function.

However, in libavformat/utils.c:
int avformat_flush(AVFormatContext *s)
{
    ff_read_frame_flush(s);
    return 0;
}

avformat_flush() is exactly identical and is a public function,
so use it instead.

StreamHasRequiredParameters():
The audio check requiring the internal struct to be defined was disabled.
This should have no effect since these checks are *all* already done via
avformat_find_stream_info() in FindStreamInfo(), which should return < 0
if these checks fail.

This copy of an internal FFmpeg function feels unnecessary and like a bad idea
since FFmpeg already checks this itself.


  Commit: 25c6b7fe87871915cf264cf63ba8ae86cf2a9199
      https://github.com/MythTV/mythtv/commit/25c6b7fe87871915cf264cf63ba8ae86cf2a9199
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  avformatdecoder.cpp: remove duplicate checks

FFmpeg already checks these in avformat_find_stream_info()
(called via FindStreamInfo() just prior).  FFmpeg should return
<0 if these checks fail, which causes the function to return
before the removed lines are executed.

These checks are copied from libavformat/utils.c and use internal
FFmpeg information (if those checks were enabled).  This is bad
pratice.  Since FFmpeg already checks these, remove our copies.


  Commit: 5798640c1c9b5488aec21606663dbaab78d98827
      https://github.com/MythTV/mythtv/commit/5798640c1c9b5488aec21606663dbaab78d98827
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    M mythtv/external/FFmpeg/libavformat/libavformat.v

  Log Message:
  -----------
  FFmpeg: remove now unecessary added exports


  Commit: 8e9d84b4c6cb02c2c10575f78a7d0259ad056985
      https://github.com/MythTV/mythtv/commit/8e9d84b4c6cb02c2c10575f78a7d0259ad056985
  Author: Scott Theisen <scott.the.elm at gmail.com>
  Date:   2022-02-09 (Wed, 09 Feb 2022)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/avformat.h
    M mythtv/external/FFmpeg/libavformat/utils.c
    M mythtv/libs/libmythmetadata/metaiomp4.cpp
    M mythtv/libs/libmythmetadata/metaiomp4.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  av_estimate_timings(): remove MythTV customization to FFmpeg

This calls the now static estimate_timings(); however
avformat_find_stream_info(), which is called prior to all
calls of av_estimate_timings(), already calls estimate_timings()
since AVFormatContext.probesize defaults to 5 000 000 bytes.

Thus, these calls are redundant duplicates of the call in
avformat_find_stream_info().

This was removed from avformatdecoder.cpp in 3924df87c7691852741b596f50311eac46f930ab
and added back in ebf194444c30eb6c7d1d6d272045674fc45a2e65 .

I'm not sure why it was added back.  If it is necessary, calling
avformat_find_stream_info() again with possibly a larger
probsize or max_analyze_duration, should work as a replacement.


Compare: https://github.com/MythTV/mythtv/compare/d282a209cb8b...8e9d84b4c6cb



More information about the mythtv-commits mailing list