[mythtv-commits] [MythTV/mythtv] 24669b: Fix clang-tidy warnings from mingw commit.

David Hampton noreply at github.com
Wed Sep 15 15:36:31 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 24669b269a8cc4c1a27a0d91bdb5244905522e60
      https://github.com/MythTV/mythtv/commit/24669b269a8cc4c1a27a0d91bdb5244905522e60
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-07 (Tue, 07 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythsystemlegacy.cpp
    M mythtv/programs/mythbackend/services/channel.cpp

  Log Message:
  -----------
  Fix clang-tidy warnings from mingw commit.


  Commit: 446bd70a566e50982dfaa73ce01965c35cf926de
      https://github.com/MythTV/mythtv/commit/446bd70a566e50982dfaa73ce01965c35cf926de
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-07 (Tue, 07 Sep 2021)

  Changed paths:
    M mythtv/programs/mythbackend/scheduler.cpp

  Log Message:
  -----------
  Fix alignment on scheduler debug output.


  Commit: 53f841f61cd32d8bdbd9a220226bbe84a0a5c565
      https://github.com/MythTV/mythtv/commit/53f841f61cd32d8bdbd9a220226bbe84a0a5c565
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-07 (Tue, 07 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  Display user track names during audio and subtitle selection.


  Commit: cab50bf77d6d5181d7ffd1383ade51b7cd41d3eb
      https://github.com/MythTV/mythtv/commit/cab50bf77d6d5181d7ffd1383ade51b7cd41d3eb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    A mythtv/libs/libmythui/test/test.pro
    A mythtv/libs/libmythui/test/test_mythgenerictree/.gitignore
    A mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.cpp
    A mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.h
    A mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.pro
    M mythtv/libs/libs.pro

  Log Message:
  -----------
  Add some test cases for the MythGenericTree class.


  Commit: baec807baf0183b8a8b8c15a0b149802fefd6084
      https://github.com/MythTV/mythtv/commit/baec807baf0183b8a8b8c15a0b149802fefd6084
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/Makefile
    A mythtv/programs/mythfrontend/test/test.pro
    A mythtv/programs/mythfrontend/test/test_videolist/.gitignore
    A mythtv/programs/mythfrontend/test/test_videolist/test_videolist.cpp
    A mythtv/programs/mythfrontend/test/test_videolist/test_videolist.h
    A mythtv/programs/mythfrontend/test/test_videolist/test_videolist.pro
    M mythtv/programs/mythfrontend/videolist.cpp
    M mythtv/programs/mythfrontend/videolist.h
    M mythtv/programs/programs.pro

  Log Message:
  -----------
  Add a test to check VideoList use of MythGenericTree.


  Commit: 48c16d0c0c6f9de722b7b7b9877b970775bfec97
      https://github.com/MythTV/mythtv/commit/48c16d0c0c6f9de722b7b7b9877b970775bfec97
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/videometadata.cpp
    M mythtv/libs/libmythmetadata/videometadata.h
    M mythtv/libs/libmythui/mythgenerictree.cpp
    M mythtv/libs/libmythui/mythgenerictree.h
    M mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.cpp
    M mythtv/libs/libmythui/test/test_mythgenerictree/test_mythgenerictree.h
    M mythtv/programs/mythfrontend/videolist.cpp

  Log Message:
  -----------
  perf: Add callbacks as an option to read data from MythGenericTree.

Convert the video list code to use these callbacks instead of
pre-populating all of the data from all of the VideoMetadata nodes
into the MythGenericTree. On my systems, this saves 41% of the time
required to build the video dialog.


  Commit: d1656f343aeb7ede824205c01378d8c1e40fe7db
      https://github.com/MythTV/mythtv/commit/d1656f343aeb7ede824205c01378d8c1e40fe7db
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythmetadata/videometadata.cpp

  Log Message:
  -----------
  perf: Convert ascii strings to utf16 QStringLiterals.


  Commit: 2f8749b5520f2160297f9e7f9fc6dce4d293bfc3
      https://github.com/MythTV/mythtv/commit/2f8749b5520f2160297f9e7f9fc6dce4d293bfc3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/backendsettings.h

  Log Message:
  -----------
  perf: Optimize call to get backend server port.

When building the "Videos" dialog, the calls to
gCoreContext->GetBackendServerPort consume 3% of the total time to
build the window. Given that this value will probably never change
once it is set, cache the result to save time.


  Commit: 2205521d46d07d2634e31356b635a8bd28548847
      https://github.com/MythTV/mythtv/commit/2205521d46d07d2634e31356b635a8bd28548847
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/videolist.cpp

  Log Message:
  -----------
  perf: No need to sort metadata items twice.

The code currently: 1) builds a list of VideoMetadata items, 2) sorts
the list, 3) filters the items in this list to create a second list,
and 4) sorts the second list.

The first sort isn't necessary.  On my systems, removing it saves
about 22% of the time required to build the video dialog.


  Commit: 0ba41200b7931d36f3b357b68daef0b1aea69877
      https://github.com/MythTV/mythtv/commit/0ba41200b7931d36f3b357b68daef0b1aea69877
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
    M mythtv/libs/libmythui/opengl/mythpainteropengl.h

  Log Message:
  -----------
  Extend opengl lock to cover images as well as textures.


  Commit: 4fe9c217f273128595475a5bcf7d84a021289430
      https://github.com/MythTV/mythtv/commit/4fe9c217f273128595475a5bcf7d84a021289430
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-10 (Fri, 10 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recordingrule.cpp

  Log Message:
  -----------
  In RecordingRule::Load, show value offset numbers in comments.


  Commit: 7e53df27331874b9b8e0bd52eba06ca0f6db84c2
      https://github.com/MythTV/mythtv/commit/7e53df27331874b9b8e0bd52eba06ca0f6db84c2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M mythtv/settings.pro

  Log Message:
  -----------
  qt6: Make tests work again.

When compiling libraries, the qt6 qmake adds "-Wl,-rpath,/usr/lib64"
to the end of the link line for the library. This has the result of
embedding a RUNPATH=/usr/lib64 entry into the dynamic section of the
shared library. This overrides the RPATH in the test executable, and
prevents any of the transitively dependent libraries from being
found. (I.E. test_foo loads libmythmetadata which is found via RPATH,
but libmythmetadata needs libmythbase which can't be found because
RUNPATH overrides RPATH and only specifies /usr/lib64.)

Make the tests work on Qt by telling it not to set any RPATH
variables.


  Commit: efa51132b307826e18503a0086981ae68abe7c41
      https://github.com/MythTV/mythtv/commit/efa51132b307826e18503a0086981ae68abe7c41
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythtv/deletemap.cpp

  Log Message:
  -----------
  Fix OSX compile warning in DeleteMap::CleanMap.


  Commit: 3590a463af19f13e3c169e99768bbff09c1c6e05
      https://github.com/MythTV/mythtv/commit/3590a463af19f13e3c169e99768bbff09c1c6e05
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-09-14 (Tue, 14 Sep 2021)

  Changed paths:
    M mythtv/libs/libmythui/devices/lirc.cpp

  Log Message:
  -----------
  Fix OSX compile warning in LIRC::Init.


Compare: https://github.com/MythTV/mythtv/compare/8899ca5fd6a1...3590a463af19


More information about the mythtv-commits mailing list