[mythtv-commits] [MythTV/mythtv] 6106c5: TheTVDB v4: update grabber to the latest api defin...

Sun Oct 31 21:22:52 UTC 2021

  Branch: refs/heads/devel/http
  Home:   https://github.com/MythTV/mythtv
  Commit: 6106c5b884662bab679006d630fb9b2fb739b5ab
      https://github.com/MythTV/mythtv/commit/6106c5b884662bab679006d630fb9b2fb739b5ab
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/bindings/python/ttvdbv4/definitions.py
    M mythtv/bindings/python/ttvdbv4/myth4ttvdbv4.py
    M mythtv/bindings/python/ttvdbv4/ttvdbv4_api.py
    M mythtv/programs/scripts/metadata/Television/ttvdb4.py

  Log Message:
  -----------
  TheTVDB v4: update grabber to the latest api definitions.

 - The grabber option `-D inetref season episode` uses now a direct call
   including season and episode number.

 - Removed the combined call to get translations for `getSeriesExtended`,
   (with `meta=translations`), because this does not work in a reliable way:
   The 'overview' and 'name' entries were not included in the same object,
   therefore, the xml output lacks the essential 'description' tag.
   Bug reports on thetvdb github indicate, that the response for this call
   will change, anyway.

  Commit: 334303cf89fac38dfabe91971c82f1623f0f103d
      https://github.com/MythTV/mythtv/commit/334303cf89fac38dfabe91971c82f1623f0f103d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/splicedescriptors.h

  Log Message:
  -----------
  cppcheck: Fix a couple of warnings in mpeg code.

These aren't problems in the code. The just appear to be cppcheck
getting confused by the types and their references. Splitting the code
into two lines eliminates the warning without changing functionality.

  Commit: 03a0b3766596bed1af6256960ea6bcb327837daa
      https://github.com/MythTV/mythtv/commit/03a0b3766596bed1af6256960ea6bcb327837daa
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideogpu.cpp
    M mythtv/libs/libmythtv/mythvideogpu.h

  Log Message:
  -----------
  cppcheck: Fix "call of pure virtual function in constructor" warning.

The line this error points to is not wrong because its not an actual
call to the pure virtual function, only setting up a callback for
later.  However, it does point out a potential problem. If someone
instantiates an object of this class and the callback is called,
there is no function there to handle the callback and the program will
crash.

Fix this by marking the constructor as "protected" so its not possible
to instantiate an object of this class. Since all sub-classes must
provide a ColourSpaceUpdate function, it shouldn't be possible to get
into a situation where the callback crashes.  Tag the code to suppress
this warning since its now been handled.

  Commit: 0dac914b1c7fa7d2b473bf1f55aad7f13f1c9b86
      https://github.com/MythTV/mythtv/commit/0dac914b1c7fa7d2b473bf1f55aad7f13f1c9b86
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythui/platforms/mythnvcontrol.cpp

  Log Message:
  -----------
  coverity: Fix resource leak 1473228 in mythnvcontrol.cpp.

Its theoretically possible for MythXDisplay::OpenMythXDisplay to
return an object but for xdisplay->GetDisplay() to fail. In this case
the memory for the display is leaked. Move the "delete" statement to
handle this case.

  Commit: 9cc4e0f84396febad67418dc2280f06173c2ae6b
      https://github.com/MythTV/mythtv/commit/9cc4e0f84396febad67418dc2280f06173c2ae6b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  coverity: Fix resource leak 1460438 in xmltvparser.cpp.

Need to delete "pginfo" before exiting the function.

  Commit: 617190afb341a0e3575b48f1116c2a75c360acfc
      https://github.com/MythTV/mythtv/commit/617190afb341a0e3575b48f1116c2a75c360acfc
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/programs/mythutil/musicmetautils.cpp

  Log Message:
  -----------
  coverity: Fix resource leak 1456182 in musicmetautils.cpp.

Need to delete "tagger" before exiting the function.

  Commit: 62eaae7815177bb78d102b88be211dedb7b6d979
      https://github.com/MythTV/mythtv/commit/62eaae7815177bb78d102b88be211dedb7b6d979
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/programs/mythbackend/services/dvr.cpp

  Log Message:
  -----------
  coverity: Fix resource leak 1476279 in dvr.cpp.

Need to delete "credits" before exiting the function.

  Commit: 81ad572de3fcab79a450c04ffeb4e1a75c438bb8
      https://github.com/MythTV/mythtv/commit/81ad572de3fcab79a450c04ffeb4e1a75c438bb8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythcoreutil.cpp

  Log Message:
  -----------
  coverity: Fix uninitialized variable in mythcoreutil.cpp.

Add an initializer for the "strm" structure. Should fix 1473212.

  Commit: 75b13f6a4471ac91cac68c13ccea916e5c5cccf0
      https://github.com/MythTV/mythtv/commit/75b13f6a4471ac91cac68c13ccea916e5c5cccf0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.h

  Log Message:
  -----------
  tidy: Fix "container size empty" warnings.

Replace two instances of size() with !empty(). The latter shows the
intent more clearly and should operate in constant time.

  Commit: ea20d4828f0f8c8ce2371f092e429c2cd2de9c83
      https://github.com/MythTV/mythtv/commit/ea20d4828f0f8c8ce2371f092e429c2cd2de9c83
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythtvmenu.h

  Log Message:
  -----------
  tidy: Fix "inconsistent declaration parameter name" warning.

  Commit: 508c9835781220fcc704e62610c4b56032b96c79
      https://github.com/MythTV/mythtv/commit/508c9835781220fcc704e62610c4b56032b96c79
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythrect.cpp
    M mythtv/libs/libmythui/mythrect.h
    M mythtv/libs/libmythui/mythrender.cpp
    M mythtv/libs/libmythupnp/upnpsubscription.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp

  Log Message:
  -----------
  tidy: Remove redundant member initialization.

  Commit: fd0aab2b580c8a79271a589d2cfd6693ceb31541
      https://github.com/MythTV/mythtv/commit/fd0aab2b580c8a79271a589d2cfd6693ceb31541
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythplugins/mythweather/mythweather/weatherUtils.cpp

  Log Message:
  -----------
  tidy: Fix "redundant boolean literal in conditional assignment" warning.

  Commit: 29c3eb13fe1eb7f89fc5b65d59b3bb8b661f9baf
      https://github.com/MythTV/mythtv/commit/29c3eb13fe1eb7f89fc5b65d59b3bb8b661f9baf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/DeviceReadBuffer.cpp

  Log Message:
  -----------
  Fix "suspicious call argument" warning in DeviceReadBuffer.

Tidy thinks that the first two arguments of this function might be
swapped because the declaration of the function being called has
"read_len" as its first parameter, and the second parameter to the
function is "read_size". This commit changes the first argument from
"len" to "read_len" to eliminate the warning.

  Commit: d09a2f94b4fb51a8b25348c7350107c764bae148
      https://github.com/MythTV/mythtv/commit/d09a2f94b4fb51a8b25348c7350107c764bae148
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M .clang-tidy

  Log Message:
  -----------
  Quiet a couple of the new clang-tidy warnings (for now).

  Commit: b9832e7e0735ad4e46be1f91c6c82ab7e25f2360
      https://github.com/MythTV/mythtv/commit/b9832e7e0735ad4e46be1f91c6c82ab7e25f2360
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/panedvbs2.h
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp

  Log Message:
  -----------
  tidy: Fix possible "one definition rule" violation.

Move function definition from header file to source file. Function
definitions in header files can lead to ODR violations.

  Commit: 8ebfeb3bbf2ed192bc42213b2a3645df4bfa6685
      https://github.com/MythTV/mythtv/commit/8ebfeb3bbf2ed192bc42213b2a3645df4bfa6685
  Author: David Engel <dengel at mythtv.org>
  Date:   2021-10-28 (Thu, 28 Oct 2021)

  Changed paths:
    M mythtv/programs/mythbackend/scheduler.cpp

  Log Message:
  -----------
  Fix boolean conversion issue with new MySQL 8.

MySQL 8.0.27 changed something with how it handles the implicit
conversions of booleans when used with arithmetic operators.  The
change caused the power, priority calculations in the scheduler to
fail due to mixed signed and unsigned values.  Fix the issue by
explicitly converting to 1 or 0.

  Commit: 240030126de07fe109ea1791a0ff03ebf712cd40
      https://github.com/MythTV/mythtv/commit/240030126de07fe109ea1791a0ff03ebf712cd40
  Author: Roland Ernst <rcrernst at gmail.com>
  Date:   2021-10-29 (Fri, 29 Oct 2021)

  Changed paths:
    M mythplugins/mythgame/mythgame/scripts/giantbomb.py
    M mythplugins/mythgame/mythgame/scripts/giantbomb/giantbomb_api.py

  Log Message:
  -----------
  MythGames: Upgrade giantbomb.py to new API and python3

 - Switched to new API definition at
   https://www.giantbomb.com/api/documentation/
   Added reqiured unique 'User-Agent'.

 - Added python3 compatibility:
   It uses now python 'requests' instead of 'urllib'.

Fixes #360

  Commit: 8e60ae7617eb943b38a723658af8a0fa7f8517fb
      https://github.com/MythTV/mythtv/commit/8e60ae7617eb943b38a723658af8a0fa7f8517fb
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-10-31 (Sun, 31 Oct 2021)

  Changed paths:
    M .clang-tidy
    M mythplugins/mythgame/mythgame/scripts/giantbomb.py
    M mythplugins/mythgame/mythgame/scripts/giantbomb/giantbomb_api.py
    M mythplugins/mythweather/mythweather/weatherUtils.cpp
    M mythtv/bindings/python/ttvdbv4/definitions.py
    M mythtv/bindings/python/ttvdbv4/myth4ttvdbv4.py
    M mythtv/bindings/python/ttvdbv4/ttvdbv4_api.py
    M mythtv/libs/libmythbase/mythcoreutil.cpp
    M mythtv/libs/libmythtv/channelscan/panedvbs2.h
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mpeg/splicedescriptors.h
    M mythtv/libs/libmythtv/mythtvmenu.h
    M mythtv/libs/libmythtv/mythvideogpu.cpp
    M mythtv/libs/libmythtv/mythvideogpu.h
    M mythtv/libs/libmythtv/recorders/DeviceReadBuffer.cpp
    M mythtv/libs/libmythui/mythrect.cpp
    M mythtv/libs/libmythui/mythrect.h
    M mythtv/libs/libmythui/mythrender.cpp
    M mythtv/libs/libmythui/platforms/mythnvcontrol.cpp
    M mythtv/libs/libmythupnp/upnpsubscription.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythutil/musicmetautils.cpp
    M mythtv/programs/scripts/metadata/Television/ttvdb4.py

  Log Message:
  -----------
  Merge branch 'master' into devel/http

Compare: https://github.com/MythTV/mythtv/compare/45d6678019d9...8e60ae7617eb