[mythtv-commits] [MythTV/mythtv] 6d1bf6: cppcheck: Mark some function arguments as const.

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 6d1bf6af6c0402aafa2bbeebd12b14df242f6656
      https://github.com/MythTV/mythtv/commit/6d1bf6af6c0402aafa2bbeebd12b14df242f6656
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.h
    M mythtv/libs/libmyth/audio/audiosettings.cpp
    M mythtv/libs/libmyth/audio/audiosettings.h
    M mythtv/libs/libmythfreemheg/ParseNode.h
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.h
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.h
    M mythtv/libs/libmythui/platforms/mythdisplayrpi.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h
    M mythtv/programs/mythwelcome/main.cpp

  Log Message:
  -----------
  cppcheck: Mark some function arguments as const.


  Commit: 4c54b97a40da0c254b2d81cd5db2d805f6bed22e
      https://github.com/MythTV/mythtv/commit/4c54b97a40da0c254b2d81cd5db2d805f6bed22e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp

  Log Message:
  -----------
  cppcheck: Fix 'condition is always true' warning in dtvrecorder.cpp

The rawRating vaiable is an unsigned 8 bit integer, and can hold a
value of 0-255. Given that the prior 'if' clause handles the zero
case, there is no need for an explicit test for a value >= 1.


  Commit: cbcaecd8cc07ed7f48556c8a2a72cce12ee34310
      https://github.com/MythTV/mythtv/commit/cbcaecd8cc07ed7f48556c8a2a72cce12ee34310
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h

  Log Message:
  -----------
  cppcheck: Fix 'condition is always true' warning in dvbdescriptors.h

Given that the prior 'if' clause handles the case where
m_videoBytesRemaining is non-zero, it is redundant for this 'if'
clause to test if m_videoBytesRemaining is zero.


  Commit: 4b00a78cdf99e87975c584f43d8dd2d7abaf131c
      https://github.com/MythTV/mythtv/commit/4b00a78cdf99e87975c584f43d8dd2d7abaf131c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/playbackbox.cpp

  Log Message:
  -----------
  cppcheck: Fix 'condition is always true' warning in playbackbox.cpp

An outer 'if' clause has already validated that 'tmpItem' is not null
and the value is never changed, so there is no need to retest it in
the inner 'if' clause.


  Commit: 4f9f6546b42f1ffc1aae342812e6753d70befaac
      https://github.com/MythTV/mythtv/commit/4f9f6546b42f1ffc1aae342812e6753d70befaac
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp

  Log Message:
  -----------
  cppcheck: Suppress 'condition is always true' warning in mythvideooutgpu.cpp

There is conditionally compiled code that cppcheck isn't seeing that
could set this variable.


  Commit: 531ffd00ae19c9fc1c6152354b2da7caed52a116
      https://github.com/MythTV/mythtv/commit/531ffd00ae19c9fc1c6152354b2da7caed52a116
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp

  Log Message:
  -----------
  cppcheck: Fix 'memory allocated but not initialized' warnings in ClassicCommDetector.cpp

Check if any frames are present before allocating memory.


  Commit: 1034f0ecba5a9771d04e8af86b4f67739c66a840
      https://github.com/MythTV/mythtv/commit/1034f0ecba5a9771d04e8af86b4f67739c66a840
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-23 (Sat, 23 Oct 2021)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp

  Log Message:
  -----------
  cppcheck: Reduce the scope of a variable.


  Commit: 2e12c0785c6d0b4b8df5d9bc080e522f25358d8a
      https://github.com/MythTV/mythtv/commit/2e12c0785c6d0b4b8df5d9bc080e522f25358d8a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-24 (Sun, 24 Oct 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/upnpscanner.cpp
    M mythtv/programs/mythfrontend/upnpscanner.h

  Log Message:
  -----------
  cppcheck: Fix class name collision for MediaServer.


  Commit: 0374b68ac874483311416f76a758d18546c575c9
      https://github.com/MythTV/mythtv/commit/0374b68ac874483311416f76a758d18546c575c9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-10-24 (Sun, 24 Oct 2021)

  Changed paths:
    M mythtv/libs/libmythbase/mythchrono.h
    M mythtv/libs/libmythtv/AirPlay/mythraopconnection.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythupnp/taskqueue.cpp

  Log Message:
  -----------
  Fix comments so doxygen reads them properly.


Compare: https://github.com/MythTV/mythtv/compare/d050f713f7c9...0374b68ac874