[mythtv-commits] [MythTV/mythtv] 8f8a30: H2645Parser.h: remove unused defines

Scott Theisen noreply at github.com
Fri Nov 26 21:42:04 UTC 2021


  Branch: refs/heads/devel/ffmpeg-resync
  Home:   https://github.com/MythTV/mythtv
  Commit: 8f8a308a326a3c66cafca78e1fdf5c19f1525ab5
      https://github.com/MythTV/mythtv/commit/8f8a308a326a3c66cafca78e1fdf5c19f1525ab5
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h

  Log Message:
  -----------
  H2645Parser.h: remove unused defines


  Commit: 01343d721889f490a813246bb2154996e82906c6
      https://github.com/MythTV/mythtv/commit/01343d721889f490a813246bb2154996e82906c6
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.h
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

  Log Message:
  -----------
  Remove include libavcodec/get_bits.h from headers

Because of how FFmpeg has shoehorned OOP into C, almost everything is passed
as pointers.  Thus, a forward declaration of the struct will suffice.

Also, get_bits.h is a horrible, macro infested file.
std::bitset is a possible replacement; however, no further investigation
has been done at this time.

If necessary, the hack can be added to each .cpp file.


  Commit: d098c6074b69a1a65af90c9a494215a51ac7e5cf
      https://github.com/MythTV/mythtv/commit/d098c6074b69a1a65af90c9a494215a51ac7e5cf
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp

  Log Message:
  -----------
  H2645Parser.cpp: remove unnecessary float -> double casts


  Commit: 440aeccea223ec657c7a50d712de1a03255769b8
      https://github.com/MythTV/mythtv/commit/440aeccea223ec657c7a50d712de1a03255769b8
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  remove vestiges of ffmpeg addition build_index

The change to ffmpeg does nothing and is being removed to reduce MythTV's
downstream changes to FFmpeg, hopefully culminating in an unmodified FFmpeg.

avformatdecoder.cpp probably needs more cleanup, but this is the minimal change
required to enable the removal of build_index from FFmpeg.


  Commit: 29f17fb6532962b198a4fd60472cab835870d409
      https://github.com/MythTV/mythtv/commit/29f17fb6532962b198a4fd60472cab835870d409
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/H2645Parser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp

  Log Message:
  -----------
  Suppress warnings from internal FFmpeg headers

Do this in the .cpp files that use them, to enable removing the changes
to the FFmpeg headers themselves.


  Commit: ce6393d5730ee656fc454192ca289df2c675ca68
      https://github.com/MythTV/mythtv/commit/ce6393d5730ee656fc454192ca289df2c675ca68
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp

  Log Message:
  -----------
  mpeg2fix.cpp: remove use of internal FFmpeg header

This file still needs to be completely rewritten to use only FFmpeg
and enable "lossless" cutting of other codecs.


  Commit: 42284db6edb899e8bf4d5305d626500d8040c7a8
      https://github.com/MythTV/mythtv/commit/42284db6edb899e8bf4d5305d626500d8040c7a8
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    M mythtv/external/FFmpeg/libavcodec/utils-mythtv.c
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  remove FFmpeg addition ff_codec_type_string()

replace with av_get_media_type_string in ffmpeg and copy to only
user: libs/libmythtv/decoders/avformatdecoder.cpp


  Commit: c552a73f31fee5b867dc08e119f8d0117769d514
      https://github.com/MythTV/mythtv/commit/c552a73f31fee5b867dc08e119f8d0117769d514
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mpeg/AVCParser.cpp
    M mythtv/libs/libmythtv/mpeg/HEVCParser.cpp
    M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
    M mythtv/programs/mythutil/mpegutils.cpp

  Log Message:
  -----------
  eliminate ffmpeg modification by including an internal header

Technically, libavcodec.v is still modified to expose the internal function.

Ideally, the use of the internal function would be eliminated, but that is
beyond the current scope of work.


  Commit: 650498d0352cc2a35a0a4a7a638811c1406591ff
      https://github.com/MythTV/mythtv/commit/650498d0352cc2a35a0a4a7a638811c1406591ff
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/codec_desc.c

  Log Message:
  -----------
  add MPEG2VBI and DVB_VBI to codec_desc.c

This enables removing libavcodec/utils-mythtv.c


  Commit: 5c984dae4a1d8ecf54368df76919c30960b43b71
      https://github.com/MythTV/mythtv/commit/5c984dae4a1d8ecf54368df76919c30960b43b71
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/external/FFmpeg/libavformat/mpegts-mythtv.c
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputdigitalencoder.cpp
    M mythtv/libs/libmyth/audio/spdifencoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.h
    M mythtv/libs/libmythtv/decoders/mythcodeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythnvdeccontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvtbcontext.cpp
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/recorders/recorderbase.cpp
    M mythtv/libs/libmythtv/recordingfile.h

  Log Message:
  -----------
  replace ff_codec_id_string() with avcodec_get_name()

This enables removing libavcodec/utils-mythtv.c


  Commit: ab6449f0b84eaf8d27d436445f68704093554f20
      https://github.com/MythTV/mythtv/commit/ab6449f0b84eaf8d27d436445f68704093554f20
  Author: ulmus-scott <scott.the.elm at gmail.com>
  Date:   2021-11-26 (Fri, 26 Nov 2021)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/Makefile
    M mythtv/external/FFmpeg/libavcodec/avcodec.h
    M mythtv/external/FFmpeg/libavcodec/libavcodec.v
    R mythtv/external/FFmpeg/libavcodec/utils-mythtv.c

  Log Message:
  -----------
  remove (now unused) FFmpeg/libavcodec/utils-mythtv.c


Compare: https://github.com/MythTV/mythtv/compare/09c2c7718fa8...ab6449f0b84e


More information about the mythtv-commits mailing list