[mythtv-commits] [MythTV/mythtv] e52e3f: Use system library function to byte swap VCT short...

David Hampton noreply at github.com
Sun May 16 13:03:30 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: e52e3ff7499703eec33b41ba5c9e069998c0e712
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-05-14 (Fri, 14 May 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/atsctables.h

  Log Message:
  Use system library function to byte swap VCT short channel name.

Qt 6.1 added overloads to the QChar constructor that catch an int or
uint argument, and use an assert to validate that the passed value
fits in 16 bits. The current implementation calls the uint version of
the constructor, and will crash if it is ever passed a number outside
of the range 0-65535, which means passing the number -1 will cause a

Converting the exiting manual byte swap to use be16toh() serves two
purposes. First it guarantees that the result is a uint16_t and
therefore can't trigger the assert. Second, it should result in
correct values if this code is ever compiled on a big-endian system.

  Commit: a7a40e9f9d868f17532d85ad1c31d6ff4148c4bf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-05-16 (Sun, 16 May 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp

  Log Message:
  Fix resource leak in iconv_helper function.

Coverity #1484881.

Compare: https://github.com/MythTV/mythtv/compare/5ad3029aec23...a7a40e9f9d86

More information about the mythtv-commits mailing list