[mythtv-commits] [MythTV/mythtv] e78764: Crash in libCEC on mythfrontend GUI rebuild (#2)

kmdewaal noreply at github.com
Mon Feb 15 18:26:00 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: e787645fd974bbed6b02ed45ae3530477bb49c58
      https://github.com/MythTV/mythtv/commit/e787645fd974bbed6b02ed45ae3530477bb49c58
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M mythtv/libs/libmythui/devices/mythcecadapter.cpp

  Log Message:
  -----------
  Crash in libCEC on mythfrontend GUI rebuild (#2)

Fix mythfrontend crash in GUI rebuild due to a theme change or due
to a change in the window size. This happens only when mythfrontend
is used with a monitor or a TV that does not support CEC.
In that case the CEC library is closed after startup but due
to a bug in libcec/cecloader.h the handle to libcec.so is not cleared.
On theme change or window resize the GUI is rebuilt and the CEC
library is opened a second time. This uses the now-invalid handle
and this causes the crash.
The real solution is to fix libcec.
For now the problem is solved by zeroing the handle ourselves, but this
requires accessing the handle which should be internal to the CEC library.
See also Pulse-Eight/libcec issue #555 on Github.
This fix replaces the first fix in which the library was never closed.
See commit 10b5291b832bc89ce726c5b53ac87ef738c2c3cd

Refs #299




More information about the mythtv-commits mailing list