[mythtv-commits] [MythTV/mythtv] af4a9a: tidy: Remove redundant and default initializers.

[David Hampton]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: af4a9a22641d95693fa0e52f0a4bb1782a92766b
      https://github.com/MythTV/mythtv/commit/af4a9a22641d95693fa0e52f0a4bb1782a92766b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2backendInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2backendStatus.h
    M mythtv/programs/mythbackend/servicesv2/v2blurayInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2buildInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2captureCard.h
    M mythtv/programs/mythbackend/servicesv2/v2channelGroup.h
    M mythtv/programs/mythbackend/servicesv2/v2channelInfoList.h
    M mythtv/programs/mythbackend/servicesv2/v2connectionInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2cutting.h
    M mythtv/programs/mythbackend/servicesv2/v2databaseInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2encoder.h
    M mythtv/programs/mythbackend/servicesv2/v2frontend.h
    M mythtv/programs/mythbackend/servicesv2/v2input.h
    M mythtv/programs/mythbackend/servicesv2/v2labelValue.h
    M mythtv/programs/mythbackend/servicesv2/v2logMessage.h
    M mythtv/programs/mythbackend/servicesv2/v2markup.h
    M mythtv/programs/mythbackend/servicesv2/v2musicMetadataInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2musicMetadataInfoList.h
    M mythtv/programs/mythbackend/servicesv2/v2programAndChannel.h
    M mythtv/programs/mythbackend/servicesv2/v2programGuide.h
    M mythtv/programs/mythbackend/servicesv2/v2programList.h
    M mythtv/programs/mythbackend/servicesv2/v2recRule.h
    M mythtv/programs/mythbackend/servicesv2/v2recRuleFilter.h
    M mythtv/programs/mythbackend/servicesv2/v2recRuleFilterList.h
    M mythtv/programs/mythbackend/servicesv2/v2recRuleList.h
    M mythtv/programs/mythbackend/servicesv2/v2recording.h
    M mythtv/programs/mythbackend/servicesv2/v2storageGroupDir.h
    M mythtv/programs/mythbackend/servicesv2/v2timeZoneInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2titleInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2videoLookupInfoList.h
    M mythtv/programs/mythbackend/servicesv2/v2videoMetadataInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2videoMetadataInfoList.h
    M mythtv/programs/mythbackend/servicesv2/v2videoMultiplex.h
    M mythtv/programs/mythbackend/servicesv2/v2videoMultiplexList.h
    M mythtv/programs/mythbackend/servicesv2/v2videoSource.h
    M mythtv/programs/mythbackend/servicesv2/v2videoStreamInfo.h
    M mythtv/programs/mythbackend/servicesv2/v2videoStreamInfoList.h
    M mythtv/programs/mythbackend/servicesv2/v2wolInfo.h

  Log Message:
  -----------
  tidy: Remove redundant and default initializers.

This simplifies the code and highlights any non-default values.

https://clang.llvm.org/extra/clang-tidy/checks/readability-redundant-member-init.html
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-default-member-init.html


  Commit: 8a815bf7d0237f1897c3827030b6e2c417c4eea7
      https://github.com/MythTV/mythtv/commit/8a815bf7d0237f1897c3827030b6e2c417c4eea7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttprequest.cpp
    M mythtv/libs/libmythbase/http/mythhttprequest.h
    M mythtv/libs/libmythbase/http/mythmimetype.cpp
    M mythtv/libs/libmythbase/http/mythmimetype.h
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.h

  Log Message:
  -----------
  tidy: Fix most "pass by value and use std::move" warnings.

This commit fixes all of the "use std::move" warnings for basic Qt
types. There are a couple remaining warnings for arguments using
shared pointers that need further evaluation.


  Commit: c8e49a12c0153729e99f7203518df6bfe429164a
      https://github.com/MythTV/mythtv/commit/c8e49a12c0153729e99f7203518df6bfe429164a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmyth/audio/spdifencoder.cpp

  Log Message:
  -----------
  Replace av_init_packet in spdifencoder.

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: b6f1eff2904720bc11ba071f04f538f46f2b3c02
      https://github.com/MythTV/mythtv/commit/b6f1eff2904720bc11ba071f04f538f46f2b3c02
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputdigitalencoder.cpp

  Log Message:
  -----------
  Replace av_init_packet in audiooutputdigitalencoder.

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: 826ab4808ecd4b88c62fdefe4f0d621e8082f2a5
      https://github.com/MythTV/mythtv/commit/826ab4808ecd4b88c62fdefe4f0d621e8082f2a5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythtv/io/mythavformatwriter.cpp

  Log Message:
  -----------
  Replace av_init_packet in mythavformatwriter. (2)

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: b96148b4ba54f4f9ec959bd015fb662aaf98147f
      https://github.com/MythTV/mythtv/commit/b96148b4ba54f4f9ec959bd015fb662aaf98147f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp

  Log Message:
  -----------
  Replace av_init_packet in NuppelVideoRecorder.

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: da1889754422d345a5579e497d802ce984db6a85
      https://github.com/MythTV/mythtv/commit/da1889754422d345a5579e497d802ce984db6a85
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/external/replex/replex.cpp

  Log Message:
  -----------
  Replace av_init_packet in mythtranscode replex.

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: b8b1d0ff526dbf43c57ccb0c8e580c04e2b46390
      https://github.com/MythTV/mythtv/commit/b8b1d0ff526dbf43c57ccb0c8e580c04e2b46390
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp

  Log Message:
  -----------
  Replace av_init_packet in mythtranscode mpeg2fix (4).

This fix has not been specifically tested, but is the same as the
prior av_init_packet -> av_packet_alloc changes.


  Commit: 282eb327a31149de32349d9dfb4468005b8cbfd5
      https://github.com/MythTV/mythtv/commit/282eb327a31149de32349d9dfb4468005b8cbfd5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.h

  Log Message:
  -----------
  tidy: Fix new warnings in mpeg2fix.cpp.


  Commit: 0b54017cba6cbfab3c1b619c4e7c829776c7cf72
      https://github.com/MythTV/mythtv/commit/0b54017cba6cbfab3c1b619c4e7c829776c7cf72
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2status.cpp

  Log Message:
  -----------
  tidy: Fix "method called on moved-from object" warning.


  Commit: 6d3c8feb21c2e1a6bd396120a4cbfe5854fc0f06
      https://github.com/MythTV/mythtv/commit/6d3c8feb21c2e1a6bd396120a4cbfe5854fc0f06
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/main.cpp

  Log Message:
  -----------
  Complete "to do" for post 0.28 release.


  Commit: b0a6357c74a233dae96f1699a40110fb82e80f50
      https://github.com/MythTV/mythtv/commit/b0a6357c74a233dae96f1699a40110fb82e80f50
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythupnp/eventing.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/upnpcmgr.cpp
    M mythtv/libs/libmythupnp/upnpdevice.cpp
    M mythtv/libs/libmythupnp/upnpmsrr.cpp
    M mythtv/libs/libmythupnp/upnptasknotify.cpp
    M mythtv/libs/libmythupnp/upnptasksearch.cpp
    M mythtv/libs/libmythupnp/upnputil.cpp
    M mythtv/programs/mythbackend/mediaserver.cpp
    M mythtv/programs/mythfrontend/mediarenderer.cpp
    M mythtv/programs/mythfrontend/mythfexml.cpp

  Log Message:
  -----------
  tidy: Fix "static member accessed through instance" warnings.


  Commit: 7479fff5a9305da598d31666c5ab33e82af8803f
      https://github.com/MythTV/mythtv/commit/7479fff5a9305da598d31666c5ab33e82af8803f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpresponse.cpp
    M mythtv/libs/libmythbase/http/mythhttpresponse.h

  Log Message:
  -----------
  tidy: Fix "top level const-qualification only has effect in definition" warning.

Convert this to a const reference to eliminate the warning.

https://clang.llvm.org/extra/clang-tidy/checks/readability-avoid-const-params-in-decls.html


  Commit: befa034b04d8449e0b1d41b0a28905cd9847dc37
      https://github.com/MythTV/mythtv/commit/befa034b04d8449e0b1d41b0a28905cd9847dc37
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-28 (Tue, 28 Dec 2021)

  Changed paths:
    M mythtv/programs/mythtranscode/mpeg2fix.cpp

  Log Message:
  -----------
  Missed a couple of av_packet_free calls in mpeg2fixup.cpp.


Compare: https://github.com/MythTV/mythtv/compare/e7269d2fd521...befa034b04d8