[mythtv-commits] [MythTV/mythtv] ebe0f6: tidy: Fix null pointer dereference warnings.

David Hampton noreply at github.com
Wed Dec 15 21:57:54 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: ebe0f6d926c581c648fedee5c09377fab7fd74ce
      https://github.com/MythTV/mythtv/commit/ebe0f6d926c581c648fedee5c09377fab7fd74ce
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h

  Log Message:
  -----------
  tidy: Fix null pointer dereference warnings.

The MPEGDescriptor constructor can leave an object with a null m_data
pointer. Any child class constructor that references this pointer
(even indirectly through calling the DescriptorTag function) needs to
validate the pointer first. Not doing so can generate a SIGSEGV
instead of the expected assert.


  Commit: 08dc2bbf680197003687d4465375403691360899
      https://github.com/MythTV/mythtv/commit/08dc2bbf680197003687d4465375403691360899
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpsocket.cpp

  Log Message:
  -----------
  tidy: Fix "stored value is never read" warnings.


  Commit: 19d619f6e4b936ffad701082a1cacf023a0660e8
      https://github.com/MythTV/mythtv/commit/19d619f6e4b936ffad701082a1cacf023a0660e8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/programrecpriority.cpp
    M mythtv/programs/mythfrontend/programrecpriority.h

  Log Message:
  -----------
  Populate Recording/Storage Group information on the Manage Recording Rules page.

Fixes #431.


  Commit: 19f69603297897176ce4a435d97f400f176f3adb
      https://github.com/MythTV/mythtv/commit/19f69603297897176ce4a435d97f400f176f3adb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-15 (Wed, 15 Dec 2021)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputopensles.cpp
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/io/mythfifowriter.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythscreenstack.cpp

  Log Message:
  -----------
  Remove unnecessary includes of cassert.


Compare: https://github.com/MythTV/mythtv/compare/1e6246da6845...19f696032978


More information about the mythtv-commits mailing list