[mythtv-commits] [MythTV/mythtv] 085436: tidy: Fix warnings in new procedural texture support.

Tue Dec 14 15:54:03 UTC 2021

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 08543681e7141432ef83ababb715ec43979b7d4a
      https://github.com/MythTV/mythtv/commit/08543681e7141432ef83ababb715ec43979b7d4a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythpainter.h
    M mythtv/libs/libmythui/mythuiprocedural.h
    M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
    M mythtv/libs/libmythui/opengl/mythpainteropengl.h

  Log Message:
  -----------
  tidy: Fix warnings in new procedural texture support.

  Commit: 7fd63529d773fd3500b254423b04a9528e7ab16b
      https://github.com/MythTV/mythtv/commit/7fd63529d773fd3500b254423b04a9528e7ab16b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpcommon.h
    M mythtv/libs/libmythbase/http/mythhttpsocket.cpp

  Log Message:
  -----------
  tidy: Fix "else after return" warnings in http server.

  Commit: c0ee9cd6c8ebaf7c29791c651f6d469d0c0ac5c4
      https://github.com/MythTV/mythtv/commit/c0ee9cd6c8ebaf7c29791c651f6d469d0c0ac5c4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpserver.cpp
    M mythtv/libs/libmythbase/http/mythhttpservice.cpp
    M mythtv/libs/libmythbase/http/mythhttpsocket.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp

  Log Message:
  -----------
  tidy: Fix "auto readability" warnings in http server.

  Commit: 0e56fe7fb60098a873de04ff11dda8182efbaea1
      https://github.com/MythTV/mythtv/commit/0e56fe7fb60098a873de04ff11dda8182efbaea1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.cpp

  Log Message:
  -----------
  tidy: Fix "use the empty() method" warnings in http server.

  Commit: 251ba2c0d9864e75df974c8f073e86cae9f18d3d
      https://github.com/MythTV/mythtv/commit/251ba2c0d9864e75df974c8f073e86cae9f18d3d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpmetamethod.h
    M mythtv/libs/libmythbase/http/mythhttpserver.h
    M mythtv/libs/libmythbase/http/mythhttpsocket.h
    M mythtv/libs/libmythbase/http/serialisers/mythxmlplistserialiser.h
    M mythtv/libs/libmythbase/http/serialisers/mythxmlserialiser.h
    M mythtv/programs/mythbackend/servicesv2/v2dvr.h
    M mythtv/programs/mythbackend/servicesv2/v2guide.h
    M mythtv/programs/mythfrontend/services/mythfrontendservice.h

  Log Message:
  -----------
  tidy: Fix "convert member function to static" warnings in http server.

  Commit: 995a48b6ad3e79ea00019ca2137a61ccca07a544
      https://github.com/MythTV/mythtv/commit/995a48b6ad3e79ea00019ca2137a61ccca07a544
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h

  Log Message:
  -----------
  Fix compiler "variable shadows a global declaration" warning.

  Commit: 30140cac57f22f937bbb4c58537e5ca4baf279f0
      https://github.com/MythTV/mythtv/commit/30140cac57f22f937bbb4c58537e5ca4baf279f0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythmimedatabase.cpp
    M mythtv/libs/libmythbase/http/mythmimedatabase.h
    M mythtv/libs/libmythbase/http/mythxsd.h
    M mythtv/programs/mythbackend/servicesv2/v2capture.h
    M mythtv/programs/mythbackend/servicesv2/v2channel.h
    M mythtv/programs/mythbackend/servicesv2/v2content.h
    M mythtv/programs/mythbackend/servicesv2/v2music.h
    M mythtv/programs/mythbackend/servicesv2/v2myth.h
    M mythtv/programs/mythbackend/servicesv2/v2video.h

  Log Message:
  -----------
  tidy: Fix "convert member functions to static" warnings.

  Commit: da2c5e50c564d3536038674b26e045e3e2ac6253
      https://github.com/MythTV/mythtv/commit/da2c5e50c564d3536038674b26e045e3e2ac6253
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttprequest.cpp
    M mythtv/libs/libmythbase/http/mythhttpsocket.cpp
    M mythtv/libs/libmythbase/http/mythhttptypes.h

  Log Message:
  -----------
  tidy: Fix "move const argument" warnings.

If the move was in a header file that could be inlined by the
compiler, keep it and remove the 'const&'. Otherwise remove the
std::move.

  Commit: 6d3b3ad6bc01cfa37cfe777e4c79114de00c216d
      https://github.com/MythTV/mythtv/commit/6d3b3ad6bc01cfa37cfe777e4c79114de00c216d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpdata.cpp

  Log Message:
  -----------
  tidy: Fix "redundant member initialization" warning.

  Commit: 9732994cad5bf6ed1ef90ab9d84a4ea9372a350b
      https://github.com/MythTV/mythtv/commit/9732994cad5bf6ed1ef90ab9d84a4ea9372a350b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythmimedatabase.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp

  Log Message:
  -----------
  tidy: Quiesce "redundant member initialization" warnings.

  Commit: 7190a924804029f5d2dc2ac15593781c703a399f
      https://github.com/MythTV/mythtv/commit/7190a924804029f5d2dc2ac15593781c703a399f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpranges.cpp
    M mythtv/libs/libmythbase/http/mythhttpservice.cpp
    M mythtv/libs/libmythbase/http/mythhttpsocket.cpp
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp
    M mythtv/libs/libmythbase/http/mythwebsockettypes.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythcborserialiser.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythjsonserialiser.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythserialiser.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythxmlplistserialiser.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythxmlserialiser.cpp
    M mythtv/programs/mythbackend/servicesv2/v2serviceUtil.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp

  Log Message:
  -----------
  tidy: Fix "modernize use auto" warnings.

  Commit: b6befde6b0d60490d0b512111bb751c58fb9a00a
      https://github.com/MythTV/mythtv/commit/b6befde6b0d60490d0b512111bb751c58fb9a00a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpcache.cpp
    M mythtv/libs/libmythbase/http/mythhttpencoding.cpp
    M mythtv/libs/libmythbase/http/mythhttpranges.cpp
    M mythtv/libs/libmythbase/http/mythhttpresponse.cpp
    M mythtv/libs/libmythbase/http/mythhttproot.cpp
    M mythtv/libs/libmythbase/http/mythmimedatabase.cpp
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp

  Log Message:
  -----------
  tidy: Fix "use qualified auto" warnings.

  Commit: 54dc4574e0104165ba04e46dd15ec6d5726cf9e3
      https://github.com/MythTV/mythtv/commit/54dc4574e0104165ba04e46dd15ec6d5726cf9e3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2content.cpp
    M mythtv/programs/mythbackend/servicesv2/v2dvr.cpp
    M mythtv/programs/mythbackend/servicesv2/v2myth.cpp

  Log Message:
  -----------
  tidy: Fix "inconsistent declaration parameter name" warnings.

An earlier commit (ce1441115bc) hanged the names of these variables in
the header file, so this commit makes the same variable name changes
in the source files.

  Commit: dd5d3cc9039195dd3a1554371af4170b4e914ee8
      https://github.com/MythTV/mythtv/commit/dd5d3cc9039195dd3a1554371af4170b4e914ee8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythmimedatabase.cpp

  Log Message:
  -----------
  tidy: Fix "method can be const" warning.

  Commit: 4411a1ad3eab03c20a76616dadafb7457a7b0ca9
      https://github.com/MythTV/mythtv/commit/4411a1ad3eab03c20a76616dadafb7457a7b0ca9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpencoding.cpp
    M mythtv/libs/libmythbase/http/mythwsdl.cpp
    M mythtv/libs/libmythbase/http/mythxsd.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythserialiser.cpp

  Log Message:
  -----------
  tidy: Fix "static member accessed through instance" warnings.

  Commit: 8c011a6a1f1623c7d5d24b9d52dc9c8879382b09
      https://github.com/MythTV/mythtv/commit/8c011a6a1f1623c7d5d24b9d52dc9c8879382b09
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythwebsocketevent.h
    M mythtv/programs/mythbackend/servicesv2/v2capture.h
    M mythtv/programs/mythbackend/servicesv2/v2content.h
    M mythtv/programs/mythbackend/servicesv2/v2dvr.h
    M mythtv/programs/mythbackend/servicesv2/v2guide.h
    M mythtv/programs/mythbackend/servicesv2/v2music.h
    M mythtv/programs/mythbackend/servicesv2/v2status.h

  Log Message:
  -----------
  tidy: Fix "use override" warnings.

  Commit: 12a680b773d8b88e9582a26960134ac6b69ea777
      https://github.com/MythTV/mythtv/commit/12a680b773d8b88e9582a26960134ac6b69ea777
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.cpp
    M mythtv/libs/libmythbase/http/mythhttpservice.h

  Log Message:
  -----------
  tidy: Fix "use =default" warnings.

  Commit: 3725429d18317726d341694523b0b89858ffe080
      https://github.com/MythTV/mythtv/commit/3725429d18317726d341694523b0b89858ffe080
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Raspian needs extra glslang libraries.

  Commit: d201202a6a8e09fdadb78151de95a971a27f8922
      https://github.com/MythTV/mythtv/commit/d201202a6a8e09fdadb78151de95a971a27f8922
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttps.cpp
    M mythtv/programs/mythbackend/main_helpers.cpp
    M mythtv/programs/mythfrontend/main.cpp

  Log Message:
  -----------
  tidy: Use lambda functions instead of std::bind.

These replacements were suggested by clang-tidy.

  Commit: 29c3b728cceef6c7023100636377ed8cf4debe89
      https://github.com/MythTV/mythtv/commit/29c3b728cceef6c7023100636377ed8cf4debe89
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2capture.cpp
    M mythtv/programs/mythbackend/servicesv2/v2channel.cpp
    M mythtv/programs/mythbackend/servicesv2/v2content.cpp
    M mythtv/programs/mythbackend/servicesv2/v2dvr.cpp
    M mythtv/programs/mythbackend/servicesv2/v2guide.cpp
    M mythtv/programs/mythbackend/servicesv2/v2music.cpp
    M mythtv/programs/mythbackend/servicesv2/v2myth.cpp
    M mythtv/programs/mythbackend/servicesv2/v2status.cpp
    M mythtv/programs/mythbackend/servicesv2/v2video.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp

  Log Message:
  -----------
  tidy: Remove unnecessary use of std::bind.

  Commit: 65c9f73ba166aedff158dacd317a527ca08dbadb
      https://github.com/MythTV/mythtv/commit/65c9f73ba166aedff158dacd317a527ca08dbadb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.h
    M mythtv/programs/mythfrontend/services/mythfrontendservice.cpp
    M mythtv/programs/mythfrontend/services/mythfrontendservice.h

  Log Message:
  -----------
  Convert frontend services to use SERVICE_PROPERTY2 macro.

Remove the now unused SERVICE_PROPERTY macro.

  Commit: 3a7556b6f478183a82176ac14c6231571dc3e665
      https://github.com/MythTV/mythtv/commit/3a7556b6f478183a82176ac14c6231571dc3e665
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.h

  Log Message:
  -----------
  tidy: Fix "unnecessary value param" warnings in new services.

Provide templated setter functions that can handle taking complex type
by reference and moving them into a variable.

  Commit: 5e865b03b606b6e9dfc24fecd7125e628fb712ee
      https://github.com/MythTV/mythtv/commit/5e865b03b606b6e9dfc24fecd7125e628fb712ee
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttprequest.cpp

  Log Message:
  -----------
  clazy: Use !isEmpty() instead of size().

  Commit: 57c58636e9cc94aed272a385854d3adeb99317ec
      https://github.com/MythTV/mythtv/commit/57c58636e9cc94aed272a385854d3adeb99317ec
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp

  Log Message:
  -----------
  tidy: Remove unused variable.

  Commit: ad49830dd36e12c5ebdf5df0a91e18abeb1fdd58
      https://github.com/MythTV/mythtv/commit/ad49830dd36e12c5ebdf5df0a91e18abeb1fdd58
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttproot.cpp

  Log Message:
  -----------
  tidy: Remove redundant operand.

  Commit: 461046123f2cb2eca2efdc275ac8a05d4294c56a
      https://github.com/MythTV/mythtv/commit/461046123f2cb2eca2efdc275ac8a05d4294c56a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythwebsocket.cpp

  Log Message:
  -----------
  tidy: Fix "use the empty() method" warnings in http server.

  Commit: aadd10663074bdd323198ab61b190d14b1205a97
      https://github.com/MythTV/mythtv/commit/aadd10663074bdd323198ab61b190d14b1205a97
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpranges.cpp
    M mythtv/libs/libmythbase/http/mythhttps.cpp

  Log Message:
  -----------
  tidy: Fix "modernize loop convert" warnings.

  Commit: 23d03c9eaf76f8a86bec503ff2b39348451df701
      https://github.com/MythTV/mythtv/commit/23d03c9eaf76f8a86bec503ff2b39348451df701
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpencoding.cpp
    M mythtv/programs/mythbackend/servicesv2/v2status.cpp

  Log Message:
  -----------
  tidy: Fix "unitialized variable" warnings.

  Commit: 2e967ab7e23ac3aef48e2356806d1913e70b4091
      https://github.com/MythTV/mythtv/commit/2e967ab7e23ac3aef48e2356806d1913e70b4091
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/libs/libmythbase/http/mythhttpservice.cpp
    M mythtv/libs/libmythbase/http/serialisers/mythserialiser.cpp

  Log Message:
  -----------
  tidy: Fix "statment should be in braces" warnings.

  Commit: 1581433b51912b4fba5208235b3e48627e22f71c
      https://github.com/MythTV/mythtv/commit/1581433b51912b4fba5208235b3e48627e22f71c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-12-13 (Mon, 13 Dec 2021)

  Changed paths:
    M mythtv/programs/mythbackend/servicesv2/v2content.cpp

  Log Message:
  -----------
  tidy: Fix unnecessary float->double conversion before converting to int.

Compare: https://github.com/MythTV/mythtv/compare/95682924e955...1581433b5191