[mythtv-commits] [MythTV/mythtv] 7e3147: Fix QString arguments when searching for remote co...

Stuart Auchterlonie noreply at github.com
Thu Aug 26 16:08:35 UTC 2021 

  Branch: refs/heads/devel/http
  Home:   https://github.com/MythTV/mythtv
  Commit: 7e3147e772d5e9ed115937e594db704d63cc8940
      https://github.com/MythTV/mythtv/commit/7e3147e772d5e9ed115937e594db704d63cc8940
  Author: naf <naf at sdf.org>
  Date:   2021-08-10 (Tue, 10 Aug 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  Fix QString arguments when searching for remote coverart files

Results in warning "Qt: QString::arg: 1 argument(s) missing in %2.%3"
and failure to retrieve coverart files


  Commit: 597e5505cdb003413130f312d13c609eff7b07c6
      https://github.com/MythTV/mythtv/commit/597e5505cdb003413130f312d13c609eff7b07c6
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-08-18 (Wed, 18 Aug 2021)

  Changed paths:
    M .github/workflows/buildmaster.yml

  Log Message:
  -----------
  Enable workflow builds on ubuntu-20.04 and macos-11


  Commit: f8a45f9700777aaedb0ca09d5bfe8e63d0c29283
      https://github.com/MythTV/mythtv/commit/f8a45f9700777aaedb0ca09d5bfe8e63d0c29283
  Author: Gary Buhrmaster <gary.buhrmaster at gmail.com>
  Date:   2021-08-19 (Thu, 19 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h

  Log Message:
  -----------
  HDHomeRun recorder repeatedly setting PID filter

As reported in ticket #trac-11475:
After the reports on list, irc, and the SD forums indicated that there was an issue with the
MythTV HDHomeRun recorder repeatedly issuing set filter, I have performed a git bisect of MythTV,
and the result is that the first commit that is causing the problem appears to be
9b22460f53bf6313516f33987e4260897c6076a3 which is "Merge of various recorder changes from mythtv-rec2".
This seems to generate new filter updates hundreds (or more) times per second.
The second commit 0542a100237dd26bcbc60212c443f4619586f15b "Refs #10414. Lower HDHomeRun recorder
CPU usage a tiny bit more." sets a timer to only update the filters about 10 times per second (the
currently observed rate). For testing purposes, I have created a patch against fixes/0.26 which
updates the filter on the hdhomerun only when the code indicates that the filter list has been
changed (attached). It should not be considered complete, but simply as a proof of concept.
In particular, I have not looked at EIT filter changes, nor other recorders.

Update 20210819 by kmdewaal:
Patch updated for today's master with only minor modifications
and tested extensively with HDHomeRun on DVB-C and DVB-T2 with EIT.
An alternative implementation would be to create the new PID filter string,
compare this with the previously sent PID filter string and send the
new string only if it is different from the old string.
This is how it is done in the SatIP streamhandler.
The chosen implementation also changes streamhandler base class. This is
however more efficient as it now only requires creating the PID filter
string when it is needed. Also, the changes in the streamhandler base
class now also enable the same solution in the SatIP streamhandler.

Signed-off-by: Klaas de Waal <kdewaal at mythtv.org>


  Commit: 25e59a72d4daa3be393f49793bded973882bbd8f
      https://github.com/MythTV/mythtv/commit/25e59a72d4daa3be393f49793bded973882bbd8f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-08-20 (Fri, 20 Aug 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/galleryconfig.cpp
    M mythtv/programs/mythfrontend/galleryconfig.h
    M mythtv/programs/mythfrontend/main.cpp

  Log Message:
  -----------
  qt6: Fix image loading problem in gallery.

Qt6 added memory limit to the code that loads images, and the limit
defaults to 128M of memory. If this limit is reached and the image
loader aborts, an error message is displayed in the frontend log. Add
a setting so users can adjust this limit if necessary.


  Commit: 3f174ec1fd12b1d1c758d3902696a2f192db765d
      https://github.com/MythTV/mythtv/commit/3f174ec1fd12b1d1c758d3902696a2f192db765d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-08-20 (Fri, 20 Aug 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  clazy: Fix qstring-arg warning.


  Commit: 65fd5474ba6267fb0b291b410aede8fde1f479b9
      https://github.com/MythTV/mythtv/commit/65fd5474ba6267fb0b291b410aede8fde1f479b9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-08-20 (Fri, 20 Aug 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/exitprompt.cpp

  Log Message:
  -----------
  qt6: Fix compilation error in std::min.

Qt6 has changed the return type of size() functions from "int" to
"qsizetype". This causes the std::min template function to fail, as it
can't be used on two different types. Cast the size value to an "int"
so that std::min can be used.


  Commit: 4e306c2b0c86700d20a48f9f104a52d0b2c73d48
      https://github.com/MythTV/mythtv/commit/4e306c2b0c86700d20a48f9f104a52d0b2c73d48
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-08-20 (Fri, 20 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recordinginfo.cpp

  Log Message:
  -----------
  Tweak setting of original airdate in recordings.

If the TV listings don't provide an original airdate, add a step when
computing an original airdate from the provided year.  Instead of
always using Jan 1st of the provided year for the original airdate, if
the year is the current year then use the recording start date for the
original airdate.


  Commit: 8233fe0f3f96f5390b6253984bbaca4c706e7998
      https://github.com/MythTV/mythtv/commit/8233fe0f3f96f5390b6253984bbaca4c706e7998
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-08-20 (Fri, 20 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/rtp/rtpdatapacket.h

  Log Message:
  -----------
  Use a Qt function for converting byte order.


  Commit: aa683a9e5931c54941251fbef8495f20727373a1
      https://github.com/MythTV/mythtv/commit/aa683a9e5931c54941251fbef8495f20727373a1
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2021-08-24 (Tue, 24 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp

  Log Message:
  -----------
  CI/CAM: Connection establishment for not spec compliant CAMs broken

This is for MythTV 0.27.1.

I do have a CAM that unconditionally sends T_SB for tcid 2 on connection open which is not spec compliant.
MythTV basically provisions for such cases in cCiTransportConnection::CreateConnection?().
However, cCiTransportConnection::RecvTPDU() breaks this as it unconditionally calls Init() on
any "error", thus resetting the processing state from CREATION to IDLE.
The attached patch fixes this for my case and should be seen as a sample workaround.
Actually some interworking between CreateConnection?() and RecvTPDU() is required to handle
the retry cases in state CREATION properly.

20210824 Tested on today's master.

Fixes #trac-12184


  Commit: a2cdb9047a68d0d36c8be1493b68a88f6dfe6af0
      https://github.com/MythTV/mythtv/commit/a2cdb9047a68d0d36c8be1493b68a88f6dfe6af0
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-08-25 (Wed, 25 Aug 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  Merge pull request #379 from naf419/master

Fix QString arguments when searching for remote coverart files


  Commit: 46a14024b27b880461dad6362b5e7992ca193d41
      https://github.com/MythTV/mythtv/commit/46a14024b27b880461dad6362b5e7992ca193d41
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-08-26 (Thu, 26 Aug 2021)

  Changed paths:
    M .github/workflows/buildmaster.yml
    M mythtv/libs/libmythtv/recorders/dvbdev/dvbci.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtpdatapacket.h
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/programs/mythfrontend/galleryconfig.cpp
    M mythtv/programs/mythfrontend/galleryconfig.h
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp
    M mythtv/programs/mythtv-setup/exitprompt.cpp

  Log Message:
  -----------
  Merge branch 'master' into devel/http


Compare: https://github.com/MythTV/mythtv/compare/dd3fa60edfbc...46a14024b27b

More information about the mythtv-commits mailing list