[mythtv-commits] [MythTV/mythtv] 4d899b: Fix error messages to use the right setting names.

Stuart Auchterlonie noreply at github.com
Tue Aug 17 07:48:21 UTC 2021


  Branch: refs/heads/devel/http
  Home:   https://github.com/MythTV/mythtv
  Commit: 4d899b94bfd258f64533b2dc883bf26ed968ec1b
      https://github.com/MythTV/mythtv/commit/4d899b94bfd258f64533b2dc883bf26ed968ec1b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2021-07-29 (Thu, 29 Jul 2021)

  Changed paths:
    M mythtv/bindings/perl/MythTV.pm
    M mythtv/bindings/php/MythBackend.php

  Log Message:
  -----------
  Fix error messages to use the right setting names.


  Commit: 18922a7a1dc45e3621672b9cfcee54d54aabb9aa
      https://github.com/MythTV/mythtv/commit/18922a7a1dc45e3621672b9cfcee54d54aabb9aa
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/exitprompt.cpp

  Log Message:
  -----------
  MythFrontend: Fix valgrind error in ExitPrompter

In the destructor of the ExitPrompter of mythfrontend the MythDialogBox is
reconfigured with a SetReturnEvent call so that it does not respond to
keypresses anymore after the ExitPrompter is deleted.
According to the description in commit 9f1005638a34e2a2b20632e09fe093adfddbe1b,
where this functionality was introduced, this is a fix for a crash which can
happen if the ExitPrompter is deleted before the MythDialogBox.
The problem with this fix is that it, as reported by valgrind, accesses the
MythDialogBox via m_dialog after the MythDialogBox is deleted.
The delete of MythDialogBox does not clear m_dialog.
The delete of MythDialogBox is triggered by qApp->exit() in ExitPrompter::DoQuit.
Fixed by moving the SetReturnEvent call to DoQuit, before qApp->exit() is called.


  Commit: 70d90a68de1c3b9011ea26b7f0ddc630604ca77d
      https://github.com/MythTV/mythtv/commit/70d90a68de1c3b9011ea26b7f0ddc630604ca77d
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythfrontend/viewschedulediff.cpp

  Log Message:
  -----------
  Information pages for conflicting recordings

In the program guide of mythfrontend, pressing "R" does schedule a recording
of the program that is currently highlighted. If it is not possible to schedule
the recording the status message "Single Record 0 Conflicting" is shown.
In theme MythCenter-wide this message appears somewhere in the right-top corner.

Pressing "R" again now gives an information page with the title and subtitle
of the selected program, followed by some text and then a list of the programs
that are recorded instead. Each conflicting program is presented with starttime,
endtime, title and subtitle. This allows you to make a decision on which of the
programs you do want to record.

A similar page can be shown as "Preview" for the "Edit Recording Rule" page
to evaluate changes in the "Schedule Options".

The following changes have been made:

- The selected program is now shown also with starttime and endtime.
This makes it easer to see the overlap between the selected program
and the conflicting programs.

- Only conflicting programs from the same video source are shown.
Previously, all programs from all video sources that overlapped in time with
the selected program were shown. This is not correct because a program from
another video source will be recorded using another tuner. Cancelling that
recording will not make any difference for recording the selected program.

- No limit on the maximum number of conflicting programs shown.
The actual number shown does depend on the theme; for MythCenter-wide the limit is 3,
for MythCenter the limit is 4 but Terra can show 8 conflicting programs.
Previously there was a limit of 4 in first described conflicting recordings page
but there was no limit in the "Preview" conflicting recordings page.

- The code is somewhat simplified.
Although also for C++ code the old saying "Beauty is in the eye of the beholder" is
more valid than ever. Valgrind is not angry but other tools might be....


  Commit: 9437fcc1ad47cc512cf3f9f5f1c9211f7a338b14
      https://github.com/MythTV/mythtv/commit/9437fcc1ad47cc512cf3f9f5f1c9211f7a338b14
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h

  Log Message:
  -----------
  Remove non-const TV play lock functions

The lock functions in tv_play.cpp are now all const.
For two lock functions there was both a const and a non-const variant
with identical function bodies.
It appears that there is no need for the non-const variants; all code
compiles without warnings against the const variants.
Therefore the non-const variants have been removed.


  Commit: 598f1b9f397bb8a8c6434e3395fd158403a5ccff
      https://github.com/MythTV/mythtv/commit/598f1b9f397bb8a8c6434e3395fd158403a5ccff
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythui/mythdialogbox.cpp

  Log Message:
  -----------
  Title for full-screen MythDialogBox

A popup window, name MythPopupBox, does not have a title but a full screen
window, name MythDialogBox, does have the capability to show a title.
The MythDialogBox is used when the dialog is to be shown full screen.
Commit 935863469bbfc36963bd389b07e62883a2cae361 does remove the title for
both variants of the dialog box because the code in MythDialogBox::Create
is used for both.
This commit restores the title but only for the full-screen MythDialogBox.
Note that the default and the MythCenter themes do have a "title" textarea
defined for the MythDialogBox but the Terra theme does not have a "title" textarea.


  Commit: 7f89299b2d7d277d1ed619923cbb8b19dbeec983
      https://github.com/MythTV/mythtv/commit/7f89299b2d7d277d1ed619923cbb8b19dbeec983
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recordinginfo.cpp

  Log Message:
  -----------
  Pathname for InsertRecording

The warning message that is given if a path is present
for InsertRecording has been changed into a debug message.
The paths that have been given so far are always valid
storage group paths and the code does not have known issues.


  Commit: c6826accfb5bb350764ac3257b4475590fd4a1b1
      https://github.com/MythTV/mythtv/commit/c6826accfb5bb350764ac3257b4475590fd4a1b1
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-07-31 (Sat, 31 Jul 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/themechooser.cpp

  Log Message:
  -----------
  Fix error message in theme download

When changing to another theme and this theme needs to be downloaded
then the following message can be shown:
2021-07-31 14:45:47.892239 I  Qt: QFile::remove: Empty or null file name
This is fixed by testing if the filename is not empty.
Note that mythfrontend also incidentally crashes when changing to another
theme and this might also be fixed now.


  Commit: b41309b21d5490e9ac0ab8997d1050d82773117c
      https://github.com/MythTV/mythtv/commit/b41309b21d5490e9ac0ab8997d1050d82773117c
  Author: Bill Meek <billmeek at mythtv.org>
  Date:   2021-07-31 (Sat, 31 Jul 2021)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmythservicecontracts/services/dvrServices.h
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/dvr.h

  Log Message:
  -----------
  Services API: Add IgnoreLiveTV/IgnoreDeleted to GetRecordedList

Add optional boolean IgnoreLiveTV and IgnoreDeleted
parameters to Dvr/GetRecordedList.

Error checking added in case RecGroup is set to either
LiveTV or Deleted. In case this is backported to v31,
set the Ignore* parameter to false and log the error.
Better than throwing an error because that could change
the existing response (unlikely, but true).

Also modifies LoadFromRecorded() that does the actual SQL.

Will be manually added to the V2 API later.


  Commit: 4b6a3a7b8b027f7df2b65117bd3ca9b14413a442
      https://github.com/MythTV/mythtv/commit/4b6a3a7b8b027f7df2b65117bd3ca9b14413a442
  Author: Gary Buhrmaster <gary.buhrmaster at gmail.com>
  Date:   2021-07-31 (Sat, 31 Jul 2021)

  Changed paths:
    M mythtv/bindings/python/MythTV/utility/dicttoxml.py
    M mythtv/bindings/python/tmdb3/tmdb3/pager.py

  Log Message:
  -----------
  Adjust for the removal of the ABCs from the python collections module

Python 3.10 will finally remove the long deprecated aliases to the
Abstract Base Classes from the collections module.

    https://docs.python.org/3.10/whatsnew/3.10.html#removed

Fixes #374


  Commit: a4c55ca9afc71967c1a4112a590e1c7fe91ce78b
      https://github.com/MythTV/mythtv/commit/a4c55ca9afc71967c1a4112a590e1c7fe91ce78b
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M mythtv/programs/mythbackend/main.cpp

  Log Message:
  -----------
  Fix typo in notify message


  Commit: 483f29c0c90c438e9f6b3383d250b1f309d60872
      https://github.com/MythTV/mythtv/commit/483f29c0c90c438e9f6b3383d250b1f309d60872
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp

  Log Message:
  -----------
  Log message types of GetChanID changed

Change the log messages in DVBChannel::GetChanID from INFO to
WARNING or DEBUG. This does reduce the amount of log output
with "-v channel" considerably when recording using multirec.


  Commit: a9d8ff53427309a32a1d0e663fdd972cc4ab1149
      https://github.com/MythTV/mythtv/commit/a9d8ff53427309a32a1d0e663fdd972cc4ab1149
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/transporteditor.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h

  Log Message:
  -----------
  Remove leading underscore from parameter names

Remove the leading underscore from a few parameter names.
Since the class members now have the "m_" prefix there is
no need anymore for a leading underscore to differentiate
the parameter name from the class instance name.


  Commit: 5f8934294ee7f4b6c30523d624c67a1638b0853d
      https://github.com/MythTV/mythtv/commit/5f8934294ee7f4b6c30523d624c67a1638b0853d
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/cardutil.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tv_rec.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  Handle Live TV start channel invalid value

Column startchan in table capturecard contains a channel number,
format as in table channum, that is used as the channel to tune
into when "Watch TV" is selected on the main menu.
The value is also used at the start of mythbackend, to verify
that the capture card is actually working.
Every Live TV channel change, including Live TV selected from
the program guide, results in an update of startchan.
Only Live TV does this; the value is not updated for recordings.

The "happy flow" in which startchan has a valid channum value
has not been changed.
When the startchan does not have a valid channum value the
following is now done:
- Check if the value of startchan is indeed a valid channel;
  a channel is only valid if it is also visible.
- If the value of startchan is not valid channel then get the first
  visible channel from the channel list of the associated video source.

This fixes the problem of "Watch TV" not being able to start
due to an incorrect startchan value.

This is implemented in CardUtil.cpp function GetStartChannel.
There was similar but less effective code in tv_rec.cpp function
GetStartChannel; this function is now removed and the function
in CardUtil is called instead.


  Commit: bd58a47a1c91637653e4a74c2dd81e3560acbe68
      https://github.com/MythTV/mythtv/commit/bd58a47a1c91637653e4a74c2dd81e3560acbe68
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-05 (Thu, 05 Aug 2021)

  Changed paths:
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  Default value for Starting Channel in mythtv-setup

In mythtv-setup page 'Input Connections" the Live TV start channel
can be selected. This value is later stored in the database.
Before storing the value check if it is valid and if not, replace
it with a suitable default value which can be any visible channel
of the video source connected to that capture card.
An invalid starting channel is therefore now no longer mentioned
in the mythtv-setup exit popup dialog.
This supports a workflow where the 'Input Connections'
are defined before the channel scan is done.
Updated the help text of the "Starting Channel" item in mythtv-setup.
Updated the message texts in the mythtv-setup exit popup dialog so
that more messages do fit in the box.


  Commit: 2026896393da7024b0367c97b56f64c550a36154
      https://github.com/MythTV/mythtv/commit/2026896393da7024b0367c97b56f64c550a36154
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M mythtv/programs/mythfrontend/exitprompt.cpp

  Log Message:
  -----------
  Revert "MythFrontend: Fix valgrind error in ExitPrompter"

This reverts commit 18922a7a1dc45e3621672b9cfcee54d54aabb9aa.


  Commit: c2cece010ab37b61d537bc41ea577d06f24bb446
      https://github.com/MythTV/mythtv/commit/c2cece010ab37b61d537bc41ea577d06f24bb446
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/checksetup.cpp

  Log Message:
  -----------
  Fix clang-tidy warnings


  Commit: 0a1fb2c380d4e7dfcfbdf9bda0efb52bb6d5713e
      https://github.com/MythTV/mythtv/commit/0a1fb2c380d4e7dfcfbdf9bda0efb52bb6d5713e
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M mythtv/libs/libmyth/programinfo.cpp

  Log Message:
  -----------
  Fix clang-tidy warnings


  Commit: cbb5fdcfc548497c128348107e762a16c74c8146
      https://github.com/MythTV/mythtv/commit/cbb5fdcfc548497c128348107e762a16c74c8146
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-06 (Fri, 06 Aug 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/exitprompt.cpp

  Log Message:
  -----------
  Dialogbox at exit of mythtv-setup for configuration problems

When mythtv-setup exits there is a check done on the configuration.
If one or more problems are found then a dialog box is shown with all
the problems and confirmation is asked before exiting.
This dialog has the following limitations:
- Only a limited number of problems do fit in the message area of the
  dialog box; the actual number that can be shown depends on the theme.
- With too many problems, the last visible problem pushes the confirmation
  question out of the message area. This makes the dialog confusing.
This has been changed in the following manner:
- Change the dialog box from a MythPopupBox to a MythDialogBox; this box is
  considerably bigger and in MythCenter-wide and at least a number of other
  themes it is now big enough to show four problems plus the confirmation question.
- Limit the number of problems shown to four and give an indication when there are
  more problems. This leaves always room for the confirmation question.
- Add the title "Configuration Problems" to the dialog box. This title is shown
  in MythCenter-wide but not in all themes.


  Commit: fdee91cd73f63c68daa7b87f914fb01fbd2002c9
      https://github.com/MythTV/mythtv/commit/fdee91cd73f63c68daa7b87f914fb01fbd2002c9
  Author: Gary Buhrmaster <gary.buhrmaster at gmail.com>
  Date:   2021-08-07 (Sat, 07 Aug 2021)

  Changed paths:
    M mythtv/libs/libmyth/audio/eldutils.h
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.h
    M mythtv/libs/libmythtv/recorders/ExternalRecorder.cpp

  Log Message:
  -----------
  Correct FSF address

Correct FSF address (low hanging fruit) in a few files that seem to have been added/updated
since the last pass was performed to correct the FSF address (initially identified by rpmlint).

Fixes #trac-13496

Signed-off-by: Klaas de Waal <klaas at kldo.nl>


  Commit: 9433789661845a7b92c50054fb00449ada12045b
      https://github.com/MythTV/mythtv/commit/9433789661845a7b92c50054fb00449ada12045b
  Author: Klaas de Waal <klaas at kldo.nl>
  Date:   2021-08-08 (Sun, 08 Aug 2021)

  Changed paths:
    M mythtv/programs/mythtv-setup/backendsettings.cpp

  Log Message:
  -----------
  HD ringbuffer size spinbox maximum value

Decrease the maximum value as shown in the spinbox from 96256 to 94000.
In mythtv-setup, 1. General, Miscellaneous Settings, File Management
Settings, the HD Ringbuffer Size can be configured.
The spinbox description is "Values from 4700 to 96256 in increments of 4700".
However, the maximum value that actually can be entered is 94000 which is
the highest multiple of 4700 below 96256.


  Commit: dbbdbbfecc49044d4b14d919229a3a887351c7d7
      https://github.com/MythTV/mythtv/commit/dbbdbbfecc49044d4b14d919229a3a887351c7d7
  Author: David Engel <dengel at mythtv.org>
  Date:   2021-08-09 (Mon, 09 Aug 2021)

  Changed paths:
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  Fix reported, file sizes in mythutil --checkrecordings.

formatSize() assumed its input was in kilobytes.  It is actually in
bytes.


  Commit: 1e626e134e47e2159a29f21fd7cb921e233dd261
      https://github.com/MythTV/mythtv/commit/1e626e134e47e2159a29f21fd7cb921e233dd261
  Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  Date:   2021-08-16 (Mon, 16 Aug 2021)

  Changed paths:
    M mythtv/html/frontend/package-lock.json

  Log Message:
  -----------
  Bump path-parse from 1.0.6 to 1.0.7 in /mythtv/html/frontend

Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support at github.com>


  Commit: a7cd2a03adfd44ef6ec08bb78f6cbbb9c4a3a0c0
      https://github.com/MythTV/mythtv/commit/a7cd2a03adfd44ef6ec08bb78f6cbbb9c4a3a0c0
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2021-08-17 (Tue, 17 Aug 2021)

  Changed paths:
    M mythtv/bindings/perl/MythTV.pm
    M mythtv/bindings/php/MythBackend.php
    M mythtv/bindings/python/MythTV/utility/dicttoxml.py
    M mythtv/bindings/python/tmdb3/tmdb3/pager.py
    M mythtv/html/frontend/package-lock.json
    M mythtv/libs/libmyth/audio/eldutils.h
    M mythtv/libs/libmyth/programinfo.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmythservicecontracts/services/dvrServices.h
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/cardutil.h
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.cpp
    M mythtv/libs/libmythtv/recorders/ExternalRecChannelFetcher.h
    M mythtv/libs/libmythtv/recorders/ExternalRecorder.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
    M mythtv/libs/libmythtv/recordinginfo.cpp
    M mythtv/libs/libmythtv/transporteditor.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tv_rec.h
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/libs/libmythui/mythdialogbox.cpp
    M mythtv/programs/mythbackend/main.cpp
    M mythtv/programs/mythbackend/services/dvr.cpp
    M mythtv/programs/mythbackend/services/dvr.h
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/schedulecommon.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/viewschedulediff.cpp
    M mythtv/programs/mythtv-setup/backendsettings.cpp
    M mythtv/programs/mythtv-setup/checksetup.cpp
    M mythtv/programs/mythtv-setup/exitprompt.cpp
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  Merge branch 'master' into devel/http


Compare: https://github.com/MythTV/mythtv/compare/69c7bb052dbe...a7cd2a03adfd


More information about the mythtv-commits mailing list