[mythtv-commits] [MythTV/mythtv] 62ca85: clazy: Use fully qualified type names in slot decl...

David Hampton noreply at github.com
Mon Sep 7 23:30:44 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 62ca858c28014b167ee370a6015a7b250af7c382
      https://github.com/MythTV/mythtv/commit/62ca858c28014b167ee370a6015a7b250af7c382
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythtv-setup/importicons.h

  Log Message:
  -----------
  clazy: Use fully qualified type names in slot declarations.


  Commit: e63006c8f8bb567210b542f4ac385169fb381ba2
      https://github.com/MythTV/mythtv/commit/e63006c8f8bb567210b542f4ac385169fb381ba2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythpainterwindow.cpp

  Log Message:
  -----------
  clazy: No need to cast to the current type.


  Commit: 5185262efb585d561958925f1ab9c842a4fe34f9
      https://github.com/MythTV/mythtv/commit/5185262efb585d561958925f1ab9c842a4fe34f9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
    M mythtv/programs/mythbackend/mainserver.cpp

  Log Message:
  -----------
  clazy: Use faster QFileInfo::exists(foo) instead of QFileInfo(foo).exists().


  Commit: 302fcc0c651226da0a8baa0c9afca2cec14e7d26
      https://github.com/MythTV/mythtv/commit/302fcc0c651226da0a8baa0c9afca2cec14e7d26
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/scanstreamdata.cpp
    M mythtv/libs/libmythtv/recorders/satiputils.cpp
    M mythtv/libs/libmythupnp/upnpcdsobjects.cpp

  Log Message:
  -----------
  clazy: Use qAsConst() when using C++11 range-for loops.


  Commit: 3609846a98e5ca2ad7eb17ebb1b28efdcd3121f0
      https://github.com/MythTV/mythtv/commit/3609846a98e5ca2ad7eb17ebb1b28efdcd3121f0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythplugins/mythnetvision/mythnetvision/netbase.cpp
    M mythtv/libs/libmythmetadata/metadataimagedownload.cpp
    M mythtv/libs/libmythmetadata/mythuiimageresults.cpp
    M mythtv/libs/libmythmetadata/mythuimetadataresults.cpp

  Log Message:
  -----------
  clazy: Fix using a const iterator with non-const functions.

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end instead of constBegin/constEnd. If the container detaches
while running it in the method it will result in a crash.

These locations were manually running the list in reverse.  Use the Qt
supplied "const reverse" functions to handle this.


  Commit: 95b0b1baae48572f7ec3ab132c4618402e72cecf
      https://github.com/MythTV/mythtv/commit/95b0b1baae48572f7ec3ab132c4618402e72cecf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/thumbfinder.cpp
    M mythplugins/mytharchive/mytharchivehelper/main.cpp
    M mythplugins/mythmusic/mythmusic/cddb.cpp
    M mythplugins/mythmusic/mythmusic/cddecoder.cpp
    M mythplugins/mythnews/mythnews/mythnews.cpp

  Log Message:
  -----------
  clazy: Fix using a const iterator with non-const functions. (plugins)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by using the const versions of these functions.


  Commit: edf89038765b772a1d087bce977d4ec9f1569950
      https://github.com/MythTV/mythtv/commit/edf89038765b772a1d087bce977d4ec9f1569950
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/httpstatus.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/mythsettings.cpp
    M mythtv/programs/mythbackend/playbacksock.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythbackend/services/serviceUtil.cpp
    M mythtv/programs/mythcommflag/CommDetector2.cpp
    M mythtv/programs/mythcommflag/main.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/progdetails.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythtranscode/main.cpp
    M mythtv/programs/mythtranscode/transcode.cpp
    M mythtv/programs/mythutil/markuputils.cpp
    M mythtv/programs/mythutil/messageutils.cpp

  Log Message:
  -----------
  clazy: Fix using a const iterator with non-const functions. (programs)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by using the const versions of these functions.


  Commit: 4f6c44ec0f0bcabee9ead1f09afc966334573687
      https://github.com/MythTV/mythtv/commit/4f6c44ec0f0bcabee9ead1f09afc966334573687
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.cpp
    M mythtv/libs/libmyth/programinfo.h
    M mythtv/libs/libmyth/remoteutil.cpp
    M mythtv/libs/libmythbase/filesysteminfo.cpp
    M mythtv/libs/libmythbase/housekeeper.cpp
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythdb.cpp
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/messagehandler.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.cpp
    M mythtv/libs/libmythtv/channelscan/vboxchannelfetcher.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.cpp
    M mythtv/libs/libmythtv/diseqc.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/dtvconfparserhelpers.cpp
    M mythtv/libs/libmythtv/eithelper.cpp
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/dishdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/satipstreamhandler.cpp
    M mythtv/libs/libmythtv/remoteencoder.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tvremoteutil.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythui/mythnotification.cpp
    M mythtv/libs/libmythui/mythnotificationcenter.cpp
    M mythtv/libs/libmythui/x11colors.cpp
    M mythtv/libs/libmythupnp/serverSideScripting.cpp

  Log Message:
  -----------
  clazy: Fix using a const iterator with non-const functions. (libs)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by using the const versions of these functions.


  Commit: 77c952df29f55f12af82ec6b78b69df821ae8f81
      https://github.com/MythTV/mythtv/commit/77c952df29f55f12af82ec6b78b69df821ae8f81
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/programs/mythbackend/internetContent.cpp
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/services/myth.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/grabbersettings.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/setupwizard_video.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videolist.cpp
    M mythtv/programs/mythtv-setup/importicons.cpp
    M mythtv/programs/mythutil/musicmetautils.cpp

  Log Message:
  -----------
  clazy: Convert const iterator with non-const functions to range-for. (programs)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by converting the loop to a c++11 range-for loop and use the
qAsConst function to prevent the Qt data structure from detaching.


  Commit: cd98d76d8559e7e8fa6e0392516ba04d2258edb0
      https://github.com/MythTV/mythtv/commit/cd98d76d8559e7e8fa6e0392516ba04d2258edb0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythplugins/mythgame/mythgame/gamehandler.cpp
    M mythplugins/mythgame/mythgame/gamescan.cpp
    M mythplugins/mythgame/mythgame/gameui.cpp
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/cddb.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.cpp
    M mythplugins/mythmusic/mythmusic/main.cpp
    M mythplugins/mythnetvision/mythnetvision/nettree.cpp

  Log Message:
  -----------
  clazy: Convert const iterator with non-const functions to range-for. (plugins)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by converting the loop to a c++11 range-for loop and use the
qAsConst function to prevent the Qt data structure from detaching.


  Commit: c4e149d42725294d4abf7f6ff2bd5a2ad03b80c3
      https://github.com/MythTV/mythtv/commit/c4e149d42725294d4abf7f6ff2bd5a2ad03b80c3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmyth/backendselect.cpp
    M mythtv/libs/libmythbase/mthread.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythobservable.cpp
    M mythtv/libs/libmythbase/serverpool.cpp
    M mythtv/libs/libmythmetadata/metadatacommon.cpp
    M mythtv/libs/libmythmetadata/metadatadownload.cpp
    M mythtv/libs/libmythmetadata/metadatafactory.cpp
    M mythtv/libs/libmythmetadata/musicfilescanner.cpp
    M mythtv/libs/libmythmetadata/mythuiimageresults.cpp
    M mythtv/libs/libmythmetadata/videoscan.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/recorders/dvbcam.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videometadatautil.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythui/mythfontmanager.cpp
    M mythtv/libs/libmythui/mythuifilebrowser.cpp
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/libs/libmythupnp/httprequest.cpp

  Log Message:
  -----------
  clazy: Convert const iterator with non-const functions to range-for. (libs)

The clazy "strict iterator" check pointed out a number of places where
a const iterator was declared, and then used with the results of
begin/end/find instead of constBegin/constEnd/constFind. If the
container detaches while running it in the method it will result in a
crash.

Fix these by converting the loop to a c++11 range-for loop and use the
qAsConst function to prevent the Qt data structure from detaching.


  Commit: 10a3e6d29957892e1f3a7a4090bc81dcc47e6055
      https://github.com/MythTV/mythtv/commit/10a3e6d29957892e1f3a7a4090bc81dcc47e6055
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp

  Log Message:
  -----------
  clazy: Fix "c++11 range-loop might detach Qt container" warning.


  Commit: f593ecc8dc0092b14c254c9871e19f6fee1dbead
      https://github.com/MythTV/mythtv/commit/f593ecc8dc0092b14c254c9871e19f6fee1dbead
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythuitype.h

  Log Message:
  -----------
  clazy: Remove overloaded signal.

Remove unused duplicate RequestUpdate signal declaration.  The also
unused RequestRegionUpdate seems like a better named signal.


  Commit: a4108dfd7d989a25aa651ba0678d8fc062a2e2e8
      https://github.com/MythTV/mythtv/commit/a4108dfd7d989a25aa651ba0678d8fc062a2e2e8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythsocket.cpp
    M mythtv/libs/libmythmetadata/musicutils.cpp
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/dtvconfparserhelpers.h
    M mythtv/programs/mythavtest/main.cpp
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp

  Log Message:
  -----------
  clazy: Fix "don't call xxx on a temporary variable" warnings.

This checker finds places where you're calling non-const member
functions on temporaries.  Replace these calls with their const
versions or with equivalent const functions.


  Commit: e71d4541cd31a2e52eb0bb92694cadf39999920b
      https://github.com/MythTV/mythtv/commit/e71d4541cd31a2e52eb0bb92694cadf39999920b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythbase/lcddevice.cpp
    M mythtv/libs/libmythtv/recorders/satiprtsp.cpp
    M mythtv/libs/libmythupnp/websocket_extensions/websocket_mythevent.cpp
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.cpp
    M mythtv/programs/mythexternrecorder/MythExternRecApp.h

  Log Message:
  -----------
  clazy: Fix "incorrect emit" warnings.

For readability purposes you should always use emit (or Q_EMIT) when
calling a signal. Add this keyword where necessary, or change it from
a function call to a keyword.


  Commit: 321ba59c142e29ee256a556bc7f7e3634ea02529
      https://github.com/MythTV/mythtv/commit/321ba59c142e29ee256a556bc7f7e3634ea02529
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythsystemevent.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythui/mythuitext.cpp

  Log Message:
  -----------
  clazy: Fix "qstring left" warnings.

Finds places where you're using `QString::left(1)` instead of `QString::at(0)`.
The later form is cheaper, as it doesn't deep-copy the string.


  Commit: a2b3313c6af11d0c2cc3e8ce4500810b6263b74e
      https://github.com/MythTV/mythtv/commit/a2b3313c6af11d0c2cc3e8ce4500810b6263b74e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmyth/mythmediamonitor.cpp
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/imagescanner.cpp
    M mythtv/libs/libmythmetadata/imagetypes.h
    M mythtv/libs/libmythmetadata/metadatacommon.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.h
    M mythtv/libs/libmythtv/opengl/mythvaapiglxinterop.cpp
    M mythtv/libs/libmythtv/recorders/HLS/HLSReader.h
    M mythtv/programs/mythfrontend/progdetails.cpp

  Log Message:
  -----------
  clazy: Fix "inefficient qlist" warnings.

Finds `QList<T>` where `sizeof(T) > sizeof(void*)`. `QVector<T>`
should be used instead.


  Commit: 42b58b557d81afc4f199992d8ec71975b60729f8
      https://github.com/MythTV/mythtv/commit/42b58b557d81afc4f199992d8ec71975b60729f8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.cpp
    M mythtv/libs/libmyth/standardsettings.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/platforms/mythpowerdbus.cpp
    M mythtv/libs/libmythbase/plist.cpp
    M mythtv/libs/libmythmetadata/imagemanager.cpp
    M mythtv/libs/libmythmetadata/imagescanner.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythfontmanager.cpp
    M mythtv/libs/libmythui/mythfontproperties.cpp
    M mythtv/libs/libmythui/mythuihelper.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/galleryinfo.cpp
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp

  Log Message:
  -----------
  clazy: Fix "range-for" warnings about detaching containers.

Finds places where you're using C++11 range-loops with non-const Qt
containers (potential detach).  These are all cases where the
container is a temporary returned from a function, and the qAsConst()
function doesn't work on temporary lists.  Fix these by using a local
variable to hold the returned list thereby making it non-temporary,
and then using the qAsConst() function.


  Commit: eb405a4c72d87f616adc73b69066126e95893ac4
      https://github.com/MythTV/mythtv/commit/eb405a4c72d87f616adc73b69066126e95893ac4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmyth/rssparse.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/channelbase.cpp
    M mythtv/libs/libmythtv/recorders/firewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/importrecorder.cpp
    M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/videosource.cpp

  Log Message:
  -----------
  clazy: Fix "qstring insensitive allocation" warnings.

Don't do a case insensitive string comparison by using the form:

    str.toLower().contains("foo")

This causes an unnecessary temporary memory allocation. The comparison
is better performed this way:

    str.contains("foo", Qt::CaseInsensitive).


  Commit: a44a7ab8f1c7e9a10f8fe12901d79e6c1205d219
      https://github.com/MythTV/mythtv/commit/a44a7ab8f1c7e9a10f8fe12901d79e6c1205d219
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythbase/test/test_mythsorthelper/test_mythsorthelper.cpp

  Log Message:
  -----------
  clazy: Remove unused variables.


  Commit: 978fcd25ef178acb7074b2709b8b7ff4c127284e
      https://github.com/MythTV/mythtv/commit/978fcd25ef178acb7074b2709b8b7ff4c127284e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/progdetails.cpp

  Log Message:
  -----------
  Convert loop to range-for.


  Commit: 3cbacc934fb3d744bba89ac7a623e21b7cb705d7
      https://github.com/MythTV/mythtv/commit/3cbacc934fb3d744bba89ac7a623e21b7cb705d7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpauhelper.h

  Log Message:
  -----------
  clazy: Fix "inefficient qlist" warning by converting to std::vector.

Finds 'QList<T>' where 'sizeof(T) > sizeof(void*)'. Clazy recommends
using 'QVector<T>' used instead, but that doesn't work in this
case. Switch to std::vector instead.


  Commit: 5c4c4f4c5a56edb49d8f2149a8ec32e137117d75
      https://github.com/MythTV/mythtv/commit/5c4c4f4c5a56edb49d8f2149a8ec32e137117d75
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-09-07 (Mon, 07 Sep 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp
    M mythtv/programs/mythfrontend/videolist.cpp

  Log Message:
  -----------
  Fix two shadowed variable warnings.


Compare: https://github.com/MythTV/mythtv/compare/727751123df0...5c4c4f4c5a56


More information about the mythtv-commits mailing list