[mythtv-commits] [MythTV/mythtv] e9bd4c: OSD: Use defines for default window names

Mark Kendall noreply at github.com
Tue Oct 27 17:19:28 UTC 2020 

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: e9bd4c36b6e1ff3bc16df7c15000467cf81c43bc
      https://github.com/MythTV/mythtv/commit/e9bd4c36b6e1ff3bc16df7c15000467cf81c43bc
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/deletemap.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp

  Log Message:
  -----------
  OSD: Use defines for default window names


  Commit: 2407aa48f38882d57467b4abdd0763c79a6df654
      https://github.com/MythTV/mythtv/commit/2407aa48f38882d57467b4abdd0763c79a6df654
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/audioplayer.cpp
    M mythtv/libs/libmythtv/audioplayer.h
    M mythtv/libs/libmythtv/mythplayeraudioui.cpp
    M mythtv/libs/libmythtv/mythplayerstate.cpp
    M mythtv/libs/libmythtv/mythplayerstate.h
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    M mythtv/libs/libmythtv/mythplayervisualiserui.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h
    M mythtv/libs/libmythtv/visualisations/videovisual.cpp
    M mythtv/libs/libmythtv/visualisations/videovisual.h

  Log Message:
  -----------
  MythPlayerVisualiserUI: Add state feedback

- as for audio etc, start feeding back state to the TV object
- again, simplifies the API by removing the need for public 'getters'
and encapsulates logic within MythPlayerVisualiserUI, leaving, for the
most part, simple signalling from the parent TV object
- also adds MythAudioPlayerState, tracking AudioPlayer channels, formats
etc which, for the time being, is just used to update visualiser support


  Commit: a4ff6ab74c9f833de2ab8965366012cb57ae401d
      https://github.com/MythTV/mythtv/commit/a4ff6ab74c9f833de2ab8965366012cb57ae401d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythtvmenu.cpp
    M mythtv/libs/libmythtv/mythtvmenu.h
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h

  Log Message:
  -----------
  MythTVMenu: Convert to using MythOSDDialogData to build menus


  Commit: 39461b24ee9f2ec5df810a1d4f6a0f47e6f507e7
      https://github.com/MythTV/mythtv/commit/39461b24ee9f2ec5df810a1d4f6a0f47e6f507e7
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp

  Log Message:
  -----------
  OSD: Fix missing back actions in dialog menus


  Commit: fcef1668db453135858c962022be641efbb02e5a
      https://github.com/MythTV/mythtv/commit/fcef1668db453135858c962022be641efbb02e5a
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  OSD: Doxygen


  Commit: d63f7d8a22a63536e535bb34d88b407d3057e46b
      https://github.com/MythTV/mythtv/commit/d63f7d8a22a63536e535bb34d88b407d3057e46b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideoout.cpp
    M mythtv/libs/libmythtv/mythvideoout.h
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h

  Log Message:
  -----------
  OSD: Simplify Draw

- remove optimisations that were previously required for blended OSDs


  Commit: 207da1777ad8cfac8b5e3513fe1572d71328e3ed
      https://github.com/MythTV/mythtv/commit/207da1777ad8cfac8b5e3513fe1572d71328e3ed
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  OSD: Remove unnecessary IsVisible method

- IsVisible is only called from one place, that seeks to presumably
optimise away the clearing of the OSD - but the same checks are in place
in the HideAll method, with no real penalty.
- subtitle/interactive screens are still preserved.


  Commit: 66b059c952eec90fb71b19b000a3964ef248fda1
      https://github.com/MythTV/mythtv/commit/66b059c952eec90fb71b19b000a3964ef248fda1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h

  Log Message:
  -----------
  OSD: Fix OSD rendering

- an optimisation too far...


  Commit: e1e8bf8fbe9fc068f1db7880352cfab8498bd585
      https://github.com/MythTV/mythtv/commit/e1e8bf8fbe9fc068f1db7880352cfab8498bd585
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/libmythtv.pro
    A mythtv/libs/libmythtv/mythcaptionsoverlay.cpp
    A mythtv/libs/libmythtv/mythcaptionsoverlay.h
    A mythtv/libs/libmythtv/mythmediaoverlay.cpp
    A mythtv/libs/libmythtv/mythmediaoverlay.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h

  Log Message:
  -----------
  OSD: Start refactor of OSD

- initially this breaks out the existing OSD class into MythMediaOverlay
(base class/shared functionality), MythCaptionsOverlay and OSD sitting
on top (dialogs and info overlays.
- no functionality changes

Refs #240


  Commit: 1f5e064cb7889a39033618dd3cf01e36e41efb59
      https://github.com/MythTV/mythtv/commit/1f5e064cb7889a39033618dd3cf01e36e41efb59
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    A mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp
    A mythtv/libs/libmythtv/overlays/mythnavigationoverlay.h

  Log Message:
  -----------
  OSD: Move and rename OSDNavigation

- create a new sub-directory for overlays
- rename OSDNavigation to MythNavigationOverlay and move into new
directory in a new file...

Refs #240


  Commit: 261831feff06d48e6129b771633719b73da13112
      https://github.com/MythTV/mythtv/commit/261831feff06d48e6129b771633719b73da13112
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythmediaoverlay.cpp
    M mythtv/libs/libmythtv/mythmediaoverlay.h
    M mythtv/libs/libmythtv/osd.cpp

  Log Message:
  -----------
  OSD: Rename MythOSDWindow->MythOverlayWindow

Refs #240


  Commit: b3b46ebe71a8d6c12410d60100c2664627961d02
      https://github.com/MythTV/mythtv/commit/b3b46ebe71a8d6c12410d60100c2664627961d02
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h
    A mythtv/libs/libmythtv/overlays/mythchanneloverlay.cpp
    A mythtv/libs/libmythtv/overlays/mythchanneloverlay.h

  Log Message:
  -----------
  OSD: Move and rename ChannelEditor screen


  Commit: 7b99b5af6e15b19e04327792e9155c76048df45d
      https://github.com/MythTV/mythtv/commit/7b99b5af6e15b19e04327792e9155c76048df45d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DetectLetterbox.cpp
    M mythtv/libs/libmythtv/DetectLetterbox.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayerstate.cpp
    M mythtv/libs/libmythtv/mythplayerstate.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayerui.h
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.h
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/mythvideobounds.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvplaybackstate.cpp
    M mythtv/libs/libmythtv/tvplaybackstate.h

  Log Message:
  -----------
  MythPlayerVideoUI: Start tracking some video state

- initially track aspect override and fill adjustments and setup
appropriate signals and slots between TV, MythPlayerVideoUI and
MythVideoBounds
- move DetectLetterbox ownership into MythPlayerVideoUI
- additional complexity comes from DetectLetterbox - which also
interacts with fill adjustments
- I hadn't realised before that DetectLetterbox actually operates in 2
threads but is owned by the player object
- to simplify matters for the time being, move its operation entirely
into the main thread, remove the internal locking (no longer needed),
pass necessary parameters in rather than referrring back to the parent
player object and amalgamate Detect and Switch methods into one.
- while it would be preferrable to operate DetectLetterbox in the
decoder thread, this does at least simplify its operation and ensures
that frame switches are actually synchronous between detection and
adjustments
- going forward I will probably try and move it fully into the decoder
thread - but that is not currently possible


  Commit: e78895ec3c6ef0273d75dd8689061e4e44675f75
      https://github.com/MythTV/mythtv/commit/e78895ec3c6ef0273d75dd8689061e4e44675f75
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/mythvideobounds.h

  Log Message:
  -----------
  MythVideoBounds: Add RefreshVideoBoundsState slot

- this allows the player to request the latest state after the
MythVideoOutput object has been created - as various updates based on
database settings etc will need to be reflected in the UI


  Commit: 6fe073ecb51c4399eda39d466f469fc3829bfdd6
      https://github.com/MythTV/mythtv/commit/6fe073ecb51c4399eda39d466f469fc3829bfdd6
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayeraudioui.cpp
    M mythtv/libs/libmythtv/mythplayeraudioui.h
    M mythtv/libs/libmythtv/overlays/mythnavigationoverlay.cpp

  Log Message:
  -----------
  MythNavigationOverlay: Better initial audio state handling

- as for MythVideoBounds state, add a RefreshAudioState slot to
MythPlayerAudioUI and use this to retrieve the initial audio state when
setting up the mute buttons


  Commit: 1675fad5a70f915d61ce4b023e33147d11342a35
      https://github.com/MythTV/mythtv/commit/1675fad5a70f915d61ce4b023e33147d11342a35
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayerui.h

  Log Message:
  -----------
  MythPlayer: Move JumpToProgram, JumpToProgram and SwitchToProgram

- into MythPlayerUI

Refs #240 #264


  Commit: bca1b4a506e1c925bb454bf5e23bcea34eac0c01
      https://github.com/MythTV/mythtv/commit/bca1b4a506e1c925bb454bf5e23bcea34eac0c01
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.h
    M mythtv/libs/libmythtv/libmythtv.pro
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    A mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    A mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.h
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.h
    M mythtv/libs/libmythtv/mythplayervisualiserui.cpp
    M mythtv/libs/libmythtv/mythplayervisualiserui.h

  Log Message:
  -----------
  MythPlayer: Move large chunks of captions code into new class

- MythPlayerCaptionsUI now handles captions stuff
- first pass is just a rough shift with very little actual update/
cleanup
- also moved a couple more methods into MythPlayerVideoUI

Refs #240 #264


  Commit: 817e7c010aee9a75c40f29471909f6cb6daa9d68
      https://github.com/MythTV/mythtv/commit/817e7c010aee9a75c40f29471909f6cb6daa9d68
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/interactivetv.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.h

  Log Message:
  -----------
  MythPlayer: Initial move of InteractiveTV into MythPlayerCaptionsUI

- a number of calls are retained in MythPlayer until a couple of
associated class (MHI, interactive screen) are converted to use
MythPlayerUI
- there are now no remaining uses of OSD in the base MythPlayer class :)

Refs #240 #264


  Commit: 5ab8069b21f801de1e1e079a3b12194e70f31942
      https://github.com/MythTV/mythtv/commit/5ab8069b21f801de1e1e079a3b12194e70f31942
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythvideobounds.cpp

  Log Message:
  -----------
  MythVideoBounds: Fix a logging message


  Commit: 347626ae386fa1edd4531d35b0aa694ec6139ff2
      https://github.com/MythTV/mythtv/commit/347626ae386fa1edd4531d35b0aa694ec6139ff2
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdoverlayscreen.cpp
    M mythtv/libs/libmythtv/Bluray/mythbdoverlayscreen.h

  Log Message:
  -----------
  MythBDOverlayScreen: Convert to using MythPlayerUI


  Commit: 1de041f40cd5a302819fdd52e3a8ddf9e93c1de3
      https://github.com/MythTV/mythtv/commit/1de041f40cd5a302819fdd52e3a8ddf9e93c1de3
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/interactivescreen.cpp
    M mythtv/libs/libmythtv/mheg/interactivescreen.h
    M mythtv/libs/libmythtv/mheg/interactivetv.cpp
    M mythtv/libs/libmythtv/mheg/interactivetv.h
    M mythtv/libs/libmythtv/mheg/mhi.cpp

  Log Message:
  -----------
  InteractiveTV: Convert interactive classes to use MythPlayerUI


  Commit: e76e8d0a719868ec57761fcb68cc1c08f46e5ae1
      https://github.com/MythTV/mythtv/commit/e76e8d0a719868ec57761fcb68cc1c08f46e5ae1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h
    M mythtv/libs/libmythtv/mythplayerui.cpp

  Log Message:
  -----------
  MythPlayer: Move remaining interactive TV code into MythPlayerCaptionsUI

- there are some significant threading issues that need to be resolved
in the short term (pre-existing)

Refs #240 #264


  Commit: edf6ac5401db5070f296f0af8d33fef89eed03a5
      https://github.com/MythTV/mythtv/commit/edf6ac5401db5070f296f0af8d33fef89eed03a5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.h
    M mythtv/libs/libmythtv/playercontext.cpp
    M mythtv/libs/libmythtv/playercontext.h
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  MythPlayer: Move OSD instance into MythPlayerOverlayUI

Refs #240 #264


  Commit: c9cb5bca431e5c0e094706abf4e11171a1dcff03
      https://github.com/MythTV/mythtv/commit/c9cb5bca431e5c0e094706abf4e11171a1dcff03
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdplayer.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdplayer.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.cpp
    M mythtv/libs/libmythtv/mythplayeroverlayui.h
    M mythtv/libs/libmythtv/mythplayerui.cpp
    M mythtv/libs/libmythtv/mythplayervideoui.cpp
    M mythtv/libs/libmythtv/mythvideoout.h
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/mythvideooutgpu.h
    M mythtv/libs/libmythtv/mythvideooutnull.h
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/osd.h

  Log Message:
  -----------
  MythPlayerOverlayUI: Allocate OSD overlay on the stack

Refs #240 #264


  Commit: 2da8036ee74e7644a054ad2228eec0d3417a32e5
      https://github.com/MythTV/mythtv/commit/2da8036ee74e7644a054ad2228eec0d3417a32e5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-10-27 (Tue, 27 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/interactivescreen.cpp
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.cpp
    M mythtv/libs/libmythtv/mythplayercaptionsui.h

  Log Message:
  -----------
  MythPlayerCaptionsUI: Start cleaning up interactive tv threading

Refs #264


Compare: https://github.com/MythTV/mythtv/compare/7d206c998467...2da8036ee74e

More information about the mythtv-commits mailing list