[mythtv-commits] [MythTV/mythtv] b7370c: Add two additional libs for vulkan to compile on F33.

David Hampton noreply at github.com
Sat Oct 3 04:06:16 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: b7370c12cfe4c55b7bf61eaa7b774081a64a7cd0
      https://github.com/MythTV/mythtv/commit/b7370c12cfe4c55b7bf61eaa7b774081a64a7cd0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Add two additional libs for vulkan to compile on F33.


  Commit: 6aaaaa55fb99c2885f8e8d98b164ed3a3a0057f5
      https://github.com/MythTV/mythtv/commit/6aaaaa55fb99c2885f8e8d98b164ed3a3a0057f5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/unzip.cpp
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythui/devices/lirc_client.cpp
    M mythtv/programs/mythtv-setup/main.cpp

  Log Message:
  -----------
  cppcheck: Fix redundant initialization of variables.


  Commit: 79e13bd53215f1c29c777bbea1c5a2544a3670e6
      https://github.com/MythTV/mythtv/commit/79e13bd53215f1c29c777bbea1c5a2544a3670e6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputdx.cpp

  Log Message:
  -----------
  cppcheck: Fix invalid argument to log10().


  Commit: b0df2c2e488a897136f1a1040beccf27b9fef9e8
      https://github.com/MythTV/mythtv/commit/b0df2c2e488a897136f1a1040beccf27b9fef9e8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.cpp

  Log Message:
  -----------
  cppcheck: Fix knownConditionTrueFalse warning in CardUtil::GetScanableInputTypes.

Don't add the list separators by hand. Add all the items to a
QStringList, and then call QStringList::join() to add the separators.


  Commit: 386248631a8825664d57143d3cf6a444de68c6d6
      https://github.com/MythTV/mythtv/commit/386248631a8825664d57143d3cf6a444de68c6d6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/unzip.cpp

  Log Message:
  -----------
  cppcheck: Fix knownConditionTrueFalse warning in unzip.cpp


  Commit: 7ce2724d9a4f7ea21cccf372741d48d84a85c686
      https://github.com/MythTV/mythtv/commit/7ce2724d9a4f7ea21cccf372741d48d84a85c686
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp

  Log Message:
  -----------
  cppcheck: Fix knownConditionTrueFalse warning in MythBDBuffer::PressButton.

When a hack was added to pin the Pts=1, a test for 'Pts <= 0' wasn't
removed.


  Commit: 6fac6846b8dc4a74dc0f33632917fbe3f26bf3bc
      https://github.com/MythTV/mythtv/commit/6fac6846b8dc4a74dc0f33632917fbe3f26bf3bc
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  cppcheck: Remove knownConditionTrueFalse warning in AvFormatDecoder::ProcessVideoFrame.

The value of "frame" has already been checked for validity. There is
no need to check it a second time.


  Commit: a5fa9aea4e87873bc2a0080db72584a6a7452886
      https://github.com/MythTV/mythtv/commit/a5fa9aea4e87873bc2a0080db72584a6a7452886
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutput.cpp
    M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp
    M mythtv/libs/libmyth/audio/audiooutputdx.cpp
    M mythtv/libs/libmyth/audio/audiooutputjack.cpp
    M mythtv/libs/libmyth/audio/audiooutputnull.cpp
    M mythtv/libs/libmyth/audio/audiooutputopensles.cpp
    M mythtv/libs/libmyth/audio/audiooutputoss.cpp
    M mythtv/libs/libmyth/audio/audiooutputsettings.cpp
    M mythtv/libs/libmyth/audio/audiooutputwin.cpp
    M mythtv/libs/libmyth/audio/volumebase.cpp
    M mythtv/libs/libmyth/mediamonitor-unix.cpp
    M mythtv/libs/libmyth/mythcontext.cpp
    M mythtv/libs/libmyth/mythmediamonitor.cpp
    M mythtv/libs/libmyth/mythrssmanager.cpp
    M mythtv/libs/libmyth/netgrabbermanager.cpp
    M mythtv/libs/libmyth/output.cpp
    M mythtv/libs/libmyth/rssparse.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmyth)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 6d7a5ddf580d7d9079966480fc11d9669e8d1c28
      https://github.com/MythTV/mythtv/commit/6d7a5ddf580d7d9079966480fc11d9669e8d1c28
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/dbcheckcommon.cpp
    M mythtv/libs/libmythbase/filesysteminfo.cpp
    M mythtv/libs/libmythbase/iso639.cpp
    M mythtv/libs/libmythbase/logging.cpp
    M mythtv/libs/libmythbase/loggingserver.cpp
    M mythtv/libs/libmythbase/mthread.cpp
    M mythtv/libs/libmythbase/mthreadpool.cpp
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythdb.cpp
    M mythtv/libs/libmythbase/mythdownloadmanager.cpp
    M mythtv/libs/libmythbase/mythmedia.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythbase/mythplugin.cpp
    M mythtv/libs/libmythbase/mythsystem.cpp
    M mythtv/libs/libmythbase/mythsystemunix.cpp
    M mythtv/libs/libmythbase/remotefile.cpp
    M mythtv/libs/libmythbase/signalhandling.cpp
    M mythtv/libs/libmythbase/test/test_mythsystem/test_mythsystem.h
    M mythtv/libs/libmythbase/test/test_mythsystemlegacy/test_mythsystemlegacy.h
    M mythtv/libs/libmythbase/threadedfilewriter.h
    M mythtv/libs/libmythtv/io/mythfilebuffer.cpp
    M mythtv/libs/libmythtv/io/mythmediabuffer.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythbase)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: f6bfd69cda9e2d514199f973efcf50890ea80f9e
      https://github.com/MythTV/mythtv/commit/f6bfd69cda9e2d514199f973efcf50890ea80f9e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythfreesurround/freesurround.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythfreesurround)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 83f9b0b68e500a562081744e0bec7934efa491bf
      https://github.com/MythTV/mythtv/commit/83f9b0b68e500a562081744e0bec7934efa491bf
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/videometadata.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythmetadata)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: e5ef88a2ab29fadb71cd1ab64b765a6d120520b9
      https://github.com/MythTV/mythtv/commit/e5ef88a2ab29fadb71cd1ab64b765a6d120520b9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythprotoserver/requesthandler/deletethread.cpp
    M mythtv/libs/libmythprotoserver/requesthandler/fileserverutil.h
    M mythtv/libs/libmythprotoserver/sockethandler/filetransfer.cpp
    M mythtv/libs/libmythprotoserver/sockethandler/filetransfer.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythprotoserver)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: fd2410291f2d86aeb51bd8a35286d4a5d636eba1
      https://github.com/MythTV/mythtv/commit/fd2410291f2d86aeb51bd8a35286d4a5d636eba1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.h
    M mythtv/libs/libmythtv/captions/cc608reader.cpp
    M mythtv/libs/libmythtv/captions/cc608reader.h
    M mythtv/libs/libmythtv/captions/cc708window.cpp
    M mythtv/libs/libmythtv/captions/cc708window.h
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/teletextdecoder.cpp
    M mythtv/libs/libmythtv/captions/teletextreader.h
    M mythtv/libs/libmythtv/captions/textsubtitleparser.h
    M mythtv/libs/libmythtv/captions/vbi608extractor.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/captions)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 40559153380c8c186d08d473b0ceb92034f64665
      https://github.com/MythTV/mythtv/commit/40559153380c8c186d08d473b0ceb92034f64665
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.h
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp
    M mythtv/libs/libmythtv/channelscan/externrecscanner.cpp
    M mythtv/libs/libmythtv/channelscan/paneatsc.h
    M mythtv/libs/libmythtv/channelscan/paneexistingscanimport.h
    M mythtv/libs/libmythtv/channelscan/scaninfo.cpp
    M mythtv/libs/libmythtv/channelscan/scaninfo.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/channelscan)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 990c37b78d02d1c82fe3c74c75617f9e36e65f27
      https://github.com/MythTV/mythtv/commit/990c37b78d02d1c82fe3c74c75617f9e36e65f27
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.cpp
    M mythtv/libs/libmythtv/decoders/decoderbase.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/decoders)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: d4bef561bf064a05ff55cf15b17f16040e99ed63
      https://github.com/MythTV/mythtv/commit/d4bef561bf064a05ff55cf15b17f16040e99ed63
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/dsmcc.cpp
    M mythtv/libs/libmythtv/mheg/dsmccobjcarousel.h
    M mythtv/libs/libmythtv/mheg/mhi.cpp
    M mythtv/libs/libmythtv/mheg/mhi.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/mheg)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 6949d3b9943862cba1ac8659d6a10b2ca859554d
      https://github.com/MythTV/mythtv/commit/6949d3b9943862cba1ac8659d6a10b2ca859554d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/atscdescriptors.h
    M mythtv/libs/libmythtv/mpeg/atscstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/atscstreamdata.h
    M mythtv/libs/libmythtv/mpeg/atsctables.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.h
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/dvbstreamdata.h
    M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
    M mythtv/libs/libmythtv/mpeg/dvbtables.h
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
    M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
    M mythtv/libs/libmythtv/mpeg/mpegstreamdata.cpp
    M mythtv/libs/libmythtv/mpeg/mpegstreamdata.h
    M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
    M mythtv/libs/libmythtv/mpeg/mpegtables.h
    M mythtv/libs/libmythtv/mpeg/pespacket.cpp
    M mythtv/libs/libmythtv/mpeg/pespacket.h
    M mythtv/libs/libmythtv/mpeg/premieredescriptors.h
    M mythtv/libs/libmythtv/mpeg/premieretables.h
    M mythtv/libs/libmythtv/mpeg/sctetables.cpp
    M mythtv/libs/libmythtv/mpeg/sctetables.h
    M mythtv/libs/libmythtv/mpeg/tablestatus.h
    M mythtv/libs/libmythtv/test/test_mpegtables/test_mpegtables.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/mpeg)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: b0f4c3d0184e2803162b9fc346b0f35d0d38d4c0
      https://github.com/MythTV/mythtv/commit/b0f4c3d0184e2803162b9fc346b0f35d0d38d4c0
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythegldmabuf.cpp
    M mythtv/libs/libmythtv/opengl/mythegldmabuf.h
    M mythtv/libs/libmythtv/opengl/mythopengltonemap.cpp
    M mythtv/libs/libmythtv/opengl/mythopengltonemap.h
    M mythtv/libs/libmythtv/opengl/mythvaapiglxinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvideotexture.cpp
    M mythtv/libs/libmythtv/opengl/mythvideotexture.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/opengl)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 91b31026eb3561f696937edc16121b79c8f5921a
      https://github.com/MythTV/mythtv/commit/91b31026eb3561f696937edc16121b79c8f5921a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/DeviceReadBuffer.cpp
    M mythtv/libs/libmythtv/recorders/ExternalChannel.h
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.h
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
    M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.h
    M mythtv/libs/libmythtv/recorders/asichannel.h
    M mythtv/libs/libmythtv/recorders/asistreamhandler.h
    M mythtv/libs/libmythtv/recorders/avcinfo.cpp
    M mythtv/libs/libmythtv/recorders/avcinfo.h
    M mythtv/libs/libmythtv/recorders/cetonchannel.h
    M mythtv/libs/libmythtv/recorders/channelbase.cpp
    M mythtv/libs/libmythtv/recorders/darwinavcinfo.cpp
    M mythtv/libs/libmythtv/recorders/darwinavcinfo.h
    M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/darwinfirewiredevice.h
    M mythtv/libs/libmythtv/recorders/dtvchannel.cpp
    M mythtv/libs/libmythtv/recorders/dtvchannel.h
    M mythtv/libs/libmythtv/recorders/dtvrecorder.h
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.h
    M mythtv/libs/libmythtv/recorders/dummychannel.h
    M mythtv/libs/libmythtv/recorders/dvbcam.cpp
    M mythtv/libs/libmythtv/recorders/dvbcam.h
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/dvbstreamhandler.h
    M mythtv/libs/libmythtv/recorders/firewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/firewiredevice.h
    M mythtv/libs/libmythtv/recorders/firewirerecorder.h
    M mythtv/libs/libmythtv/recorders/firewiresignalmonitor.h
    M mythtv/libs/libmythtv/recorders/hdhrchannel.cpp
    M mythtv/libs/libmythtv/recorders/hdhrchannel.h
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/hdhrstreamhandler.h
    M mythtv/libs/libmythtv/recorders/hlsstreamhandler.h
    M mythtv/libs/libmythtv/recorders/httptsstreamhandler.h
    M mythtv/libs/libmythtv/recorders/iptvstreamhandler.cpp
    M mythtv/libs/libmythtv/recorders/iptvstreamhandler.h
    M mythtv/libs/libmythtv/recorders/linuxavcinfo.cpp
    M mythtv/libs/libmythtv/recorders/linuxavcinfo.h
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.cpp
    M mythtv/libs/libmythtv/recorders/linuxfirewiredevice.h
    M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
    M mythtv/libs/libmythtv/recorders/recorderbase.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtppacketbuffer.cpp
    M mythtv/libs/libmythtv/recorders/rtp/rtptsdatapacket.h
    M mythtv/libs/libmythtv/recorders/signalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/signalmonitor.h
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h
    M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.h
    M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
    M mythtv/libs/libmythtv/recorders/v4lchannel.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv/recorders)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: fa37950264af5bb254f55ad87562e8298f727801
      https://github.com/MythTV/mythtv/commit/fa37950264af5bb254f55ad87562e8298f727801
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/mythdvddecoder.cpp
    M mythtv/libs/libmythtv/DetectLetterbox.cpp
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/cardutil.h
    M mythtv/libs/libmythtv/channelgroup.cpp
    M mythtv/libs/libmythtv/channelgroup.h
    M mythtv/libs/libmythtv/channelinfo.h
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/channelutil.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/diseqc.h
    M mythtv/libs/libmythtv/dtvconfparser.h
    M mythtv/libs/libmythtv/dtvmultiplex.h
    M mythtv/libs/libmythtv/eitfixup.cpp
    M mythtv/libs/libmythtv/eithelper.cpp
    M mythtv/libs/libmythtv/frequencytables.h
    M mythtv/libs/libmythtv/io/mythfifowriter.cpp
    M mythtv/libs/libmythtv/io/mythfifowriter.h
    M mythtv/libs/libmythtv/jobqueue.cpp
    M mythtv/libs/libmythtv/jobqueue.h
    M mythtv/libs/libmythtv/mythccextractorplayer.cpp
    M mythtv/libs/libmythtv/mythcommflagplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythvideobounds.cpp
    M mythtv/libs/libmythtv/mythvideocolourspace.cpp
    M mythtv/libs/libmythtv/mythvideoout.h
    M mythtv/libs/libmythtv/mythvideooutnull.cpp
    M mythtv/libs/libmythtv/playercontext.h
    M mythtv/libs/libmythtv/previewgenerator.cpp
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/programdata.h
    M mythtv/libs/libmythtv/recordingprofile.cpp
    M mythtv/libs/libmythtv/recordingquality.cpp
    M mythtv/libs/libmythtv/remoteencoder.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.cpp
    M mythtv/libs/libmythtv/signalmonitorvalue.h
    M mythtv/libs/libmythtv/sourceutil.cpp
    M mythtv/libs/libmythtv/sourceutil.h
    M mythtv/libs/libmythtv/test/test_avcinfo/test_avcinfo.cpp
    M mythtv/libs/libmythtv/test/test_mythiowrapper/test_mythiowrapper.cpp
    M mythtv/libs/libmythtv/transporteditor.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythtv/tv_rec.h
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp
    M mythtv/libs/libmythtv/tvremoteutil.cpp
    M mythtv/libs/libmythtv/tvremoteutil.h
    M mythtv/libs/libmythtv/videobuffers.cpp
    M mythtv/libs/libmythtv/videobuffers.h
    M mythtv/libs/libmythtv/videodisplayprofile.h
    M mythtv/libs/libmythtv/videoout_d3d.cpp
    M mythtv/libs/libmythtv/videosource.cpp
    M mythtv/libs/libmythtv/videosource.h
    M mythtv/programs/mythbackend/services/channel.cpp
    M mythtv/programs/mythbackend/services/guide.cpp
    M mythtv/programs/mythbackend/services/music.cpp
    M mythtv/programs/mythbackend/services/video.cpp
    M mythtv/programs/mythcommflag/CannyEdgeDetector.cpp
    M mythtv/programs/mythfilldatabase/channeldata.cpp
    M mythtv/programs/mythfrontend/globalsettings.h
    M mythtv/programs/mythfrontend/manualschedule.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.cpp
    M mythtv/programs/mythlcdserver/lcdprocclient.h
    M mythtv/programs/mythtranscode/transcode.cpp
    M mythtv/programs/mythtranscode/transcode.h
    M mythtv/programs/mythutil/jobutils.cpp
    M mythtv/programs/mythwelcome/welcomedialog.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythtv)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: b231fd9ac0a22742d8d5adcaf41a8df61264206b
      https://github.com/MythTV/mythtv/commit/b231fd9ac0a22742d8d5adcaf41a8df61264206b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/devices/lirc.cpp
    M mythtv/libs/libmythui/devices/mythcecadapter.h
    M mythtv/libs/libmythui/mythdisplay.cpp
    M mythtv/libs/libmythui/mythdisplay.h
    M mythtv/libs/libmythui/mythdisplaymode.cpp
    M mythtv/libs/libmythui/mythdisplaymode.h
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/libs/libmythui/mythuishape.cpp
    M mythtv/libs/libmythui/opengl/mythpainteropengl.cpp
    M mythtv/libs/libmythui/platforms/mythdisplaymutter.cpp
    M mythtv/libs/libmythui/platforms/mythdisplaymutter.h
    M mythtv/libs/libmythui/platforms/mythdisplayrpi.cpp
    M mythtv/libs/libmythui/platforms/mythdisplayrpi.h

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythui)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: b62f5204df4ad8713271563f1d6cdc3c135c6a5c
      https://github.com/MythTV/mythtv/commit/b62f5204df4ad8713271563f1d6cdc3c135c6a5c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythupnp/bufferedsocketdevice.h
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/ssdp.cpp
    M mythtv/libs/libmythupnp/upnpcds.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (libmythupnp)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 4beae8ec552daba0b3e4ab635eefb8219ded4ded
      https://github.com/MythTV/mythtv/commit/4beae8ec552daba0b3e4ab635eefb8219ded4ded
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythbackend/autoexpire.h
    M mythtv/programs/mythbackend/filetransfer.cpp
    M mythtv/programs/mythbackend/filetransfer.h
    M mythtv/programs/mythbackend/main_helpers.cpp
    M mythtv/programs/mythbackend/main_helpers.h
    M mythtv/programs/mythbackend/mainserver.cpp
    M mythtv/programs/mythbackend/mainserver.h
    M mythtv/programs/mythbackend/playbacksock.cpp
    M mythtv/programs/mythbackend/playbacksock.h
    M mythtv/programs/mythbackend/scheduler.cpp
    M mythtv/programs/mythbackend/scheduler.h
    M mythtv/programs/mythbackend/services/dvr.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (mythbackend)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: b233bfbbccbe6cfee3b4fb93ffcd66168dfc8077
      https://github.com/MythTV/mythtv/commit/b233bfbbccbe6cfee3b4fb93ffcd66168dfc8077
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
    M mythtv/programs/mythcommflag/BorderDetector.cpp
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythcommflag/ClassicCommDetector.h
    M mythtv/programs/mythcommflag/ClassicLogoDetector.cpp
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.cpp
    M mythtv/programs/mythcommflag/CommDetector2.cpp
    M mythtv/programs/mythcommflag/CommDetector2.h
    M mythtv/programs/mythcommflag/CommDetectorBase.h
    M mythtv/programs/mythcommflag/EdgeDetector.cpp
    M mythtv/programs/mythcommflag/PrePostRollFlagger.cpp
    M mythtv/programs/mythcommflag/TemplateFinder.cpp
    M mythtv/programs/mythcommflag/TemplateMatcher.cpp
    M mythtv/programs/mythcommflag/main.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (mythcommflag)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 49779fb73b8dd7eb18728223932bab9c420fea22
      https://github.com/MythTV/mythtv/commit/49779fb73b8dd7eb18728223932bab9c420fea22
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/channelrecpriority.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/grabbersettings.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp
    M mythtv/programs/mythfrontend/guidegrid.h
    M mythtv/programs/mythfrontend/main.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/playbackboxhelper.cpp
    M mythtv/programs/mythfrontend/prevreclist.cpp
    M mythtv/programs/mythfrontend/proglist.cpp
    M mythtv/programs/mythfrontend/programinfocache.h
    M mythtv/programs/mythfrontend/programrecpriority.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/statusbox.h
    M mythtv/programs/mythfrontend/videolist.cpp
    M mythtv/programs/mythfrontend/videometadatasettings.cpp
    M mythtv/programs/mythfrontend/videoplayersettings.cpp
    M mythtv/programs/mythfrontend/viewschedulediff.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (mythfrontend)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: d0f9125299bcc95b668bcf638219e2ae3cbd20b7
      https://github.com/MythTV/mythtv/commit/d0f9125299bcc95b668bcf638219e2ae3cbd20b7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythavtest/main.cpp
    M mythtv/programs/mythccextractor/main.cpp
    M mythtv/programs/mythexternrecorder/MythExternControl.cpp
    M mythtv/programs/mythfilerecorder/mythfilerecorder.cpp
    M mythtv/programs/mythfilldatabase/filldata.cpp
    M mythtv/programs/mythfilldatabase/filldata.h
    M mythtv/programs/mythfilldatabase/main.cpp
    M mythtv/programs/mythjobqueue/main.cpp
    M mythtv/programs/mythlcdserver/main.cpp
    M mythtv/programs/mythmediaserver/controlrequesthandler.h
    M mythtv/programs/mythmediaserver/main.cpp
    M mythtv/programs/mythmetadatalookup/main.cpp
    M mythtv/programs/mythpreviewgen/main.cpp
    M mythtv/programs/mythscreenwizard/main.cpp
    M mythtv/programs/mythscreenwizard/screenwizard.cpp
    M mythtv/programs/mythshutdown/main.cpp
    M mythtv/programs/mythtranscode/audioreencodebuffer.cpp
    M mythtv/programs/mythtranscode/cutter.cpp
    M mythtv/programs/mythtranscode/main.cpp
    M mythtv/programs/mythtranscode/mpeg2fix.h
    M mythtv/programs/mythtranscode/transcode.cpp
    M mythtv/programs/mythtv-setup/main.cpp
    M mythtv/programs/mythutil/recordingutils.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (other programs)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 2c46bd944fded76aafdeeddc1ca85d95a5548ab9
      https://github.com/MythTV/mythtv/commit/2c46bd944fded76aafdeeddc1ca85d95a5548ab9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythzoneminder/mythzmserver/main.cpp
    M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
    M mythplugins/mythzoneminder/mythzmserver/zmserver.h
    M mythplugins/mythzoneminder/mythzoneminder/main.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmclient.h
    M mythplugins/mythzoneminder/mythzoneminder/zmevents.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
    M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.h
    M mythplugins/mythzoneminder/mythzoneminder/zmplayer.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (mythzoneminder)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: 08598f0a80639876d789c8f37c738ef548257fe2
      https://github.com/MythTV/mythtv/commit/08598f0a80639876d789c8f37c738ef548257fe2
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/archivedbcheck.cpp
    M mythplugins/mytharchive/mytharchive/archiveutil.cpp
    M mythplugins/mytharchive/mytharchive/main.cpp
    M mythplugins/mytharchive/mytharchive/mythburn.cpp
    M mythplugins/mytharchive/mytharchive/videoselector.cpp
    M mythplugins/mytharchive/mytharchivehelper/main.cpp
    M mythplugins/mythbrowser/mythbrowser/bookmarkmanager.cpp
    M mythplugins/mythbrowser/mythbrowser/main.cpp
    M mythplugins/mythbrowser/mythbrowser/mythbrowser.cpp
    M mythplugins/mythbrowser/mythbrowser/mythflashplayer.cpp
    M mythplugins/mythbrowser/mythbrowser/webpage.cpp
    M mythplugins/mythgame/mythgame/gamedbcheck.cpp
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/bumpscope.cpp
    M mythplugins/mythmusic/mythmusic/bumpscope.h
    M mythplugins/mythmusic/mythmusic/cdrip.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.h
    M mythplugins/mythmusic/mythmusic/encoder.cpp
    M mythplugins/mythmusic/mythmusic/flacencoder.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.h
    M mythplugins/mythmusic/mythmusic/lameencoder.cpp
    M mythplugins/mythmusic/mythmusic/mainvisual.cpp
    M mythplugins/mythmusic/mythmusic/mainvisual.h
    M mythplugins/mythmusic/mythmusic/musiccommon.cpp
    M mythplugins/mythmusic/mythmusic/musicdbcheck.cpp
    M mythplugins/mythmusic/mythmusic/mythgoom.cpp
    M mythplugins/mythmusic/mythmusic/mythgoom.h
    M mythplugins/mythmusic/mythmusic/playlist.cpp
    M mythplugins/mythmusic/mythmusic/pls.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
    M mythplugins/mythmusic/mythmusic/smartplaylist.h
    M mythplugins/mythmusic/mythmusic/streamview.cpp
    M mythplugins/mythmusic/mythmusic/synaesthesia.cpp
    M mythplugins/mythmusic/mythmusic/visualize.cpp
    M mythplugins/mythmusic/mythmusic/visualize.h
    M mythplugins/mythmusic/mythmusic/vorbisencoder.cpp
    M mythplugins/mythnetvision/mythfillnetvision/main.cpp
    M mythplugins/mythnetvision/mythnetvision/main.cpp
    M mythplugins/mythnetvision/mythnetvision/netsearch.cpp
    M mythplugins/mythnews/mythnews/main.cpp
    M mythplugins/mythnews/mythnews/newsarticle.h
    M mythplugins/mythnews/mythnews/newssite.h
    M mythplugins/mythweather/mythweather/weatherScreen.cpp
    M themestringstool/main.cpp

  Log Message:
  -----------
  Don't include all of the standard namespace. (other plugins)

Including all of the standard namespace is considered bad practice. It
defeats the purpose of namespaces, and pollutes the global name table.


  Commit: d826cf9c0b1cfa20c65b449ae94a52eaa048bc1f
      https://github.com/MythTV/mythtv/commit/d826cf9c0b1cfa20c65b449ae94a52eaa048bc1f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/bumpscope.cpp

  Log Message:
  -----------
  Fix a double promotion warning.

This warning appeared because the code is no longer including all of
the standard namespace, and the function named "std::asin" is no
longer overriding the function named "asin" from the base C++ library.


  Commit: 96fe8873b22bd91427b677a36ed73224851d5935
      https://github.com/MythTV/mythtv/commit/96fe8873b22bd91427b677a36ed73224851d5935
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play_win.cpp

  Log Message:
  -----------
  Fix MythGestureEvent errors on android.


  Commit: 3d9e87e05b614c704ade98e809c96421d613f29e
      https://github.com/MythTV/mythtv/commit/3d9e87e05b614c704ade98e809c96421d613f29e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/xine_demux_sputext.cpp
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp
    M mythtv/libs/libmythtv/mythframe.h
    M mythtv/libs/libmythtv/mythvideooutnull.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videobuffers.cpp
    M mythtv/libs/libmythtv/videoouttypes.h
    M mythtv/libs/libmythtv/visualisations/videovisualdefs.h

  Log Message:
  -----------
  cppcheck: Fix "local variable shadows outer function" warnings.

Use more specific names for these functions instead of generic names
that conflict with variable names.


  Commit: a29847555ad936d46f742422448d62c3372b9ee6
      https://github.com/MythTV/mythtv/commit/a29847555ad936d46f742422448d62c3372b9ee6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/compat.h
    M mythtv/programs/mythfrontend/gallerytransitions.cpp
    M mythtv/programs/mythfrontend/galleryviews.cpp

  Log Message:
  -----------
  cppcheck: Suppress warnings about qrand/qsrand being called.

The recommended solution of QRandomGenerator has already been
implemented for versions of Qt where it exists.


  Commit: c5ff4fab2ca5b3954adfc30356c84f7f6b03f24c
      https://github.com/MythTV/mythtv/commit/c5ff4fab2ca5b3954adfc30356c84f7f6b03f24c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/Bluray/mythbdbuffer.cpp
    M mythtv/libs/libmythtv/decoders/mythv4l2m2mcontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/decoders/mythvdpaucontext.cpp
    M mythtv/libs/libmythtv/io/mythinteractivebuffer.cpp
    M mythtv/libs/libmythtv/mythframe.h
    M mythtv/libs/libmythtv/mythvideooutgpu.cpp
    M mythtv/libs/libmythtv/opengl/mythopenglinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvdpauinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythvideooutopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/vulkan/mythpaintervulkan.cpp

  Log Message:
  -----------
  cppcheck: Remove several redundant conditions.

All of these are in the form "!A || (A && B)" which is equivalent to
"!A || B".  If A is false, the first clause is true and the whole
condition is true.  The only time the second clause is evaluated is
when A is true, so to actually test for that in the second clause is
unnecessary.


  Commit: c9853364204e2de21d16d740cb2d40588b289c46
      https://github.com/MythTV/mythtv/commit/c9853364204e2de21d16d740cb2d40588b289c46
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputsettings.cpp

  Log Message:
  -----------
  cppcheck: Fix "using iterator that may be invalid" warning.

The std::vector::pop_back function invalidates any reference to the
last item or to the end() iterator.  Replace this code with a copy to
a temporary vector, and then replacing the original with the
temporary.


  Commit: 8b5c9ea87339a6c85125db517465ae436e1ebdab
      https://github.com/MythTV/mythtv/commit/8b5c9ea87339a6c85125db517465ae436e1ebdab
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/lines.cpp
    M mythtv/libs/libmythtv/visualisations/goom/tentacle3d.cpp

  Log Message:
  -----------
  cppcheck: Fix two "condition is always false" warnings.

In both of these cases an unsigned value is tested to see if it is
less than zero, which is false by definition. Remove these tests.


  Commit: 5c7fb21758759ed1cf382edfde3007a89dc1a74c
      https://github.com/MythTV/mythtv/commit/5c7fb21758759ed1cf382edfde3007a89dc1a74c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelutil.cpp

  Log Message:
  -----------
  cppcheck: Disable "identical inner condition is always true" warning.

The second check occurs after unlocking and relocking a lock, so the
value of the variable may have been changed by another waiting
process.


  Commit: e649c9a555438abbeb8cfa0c7f171d1a0a6294fa
      https://github.com/MythTV/mythtv/commit/e649c9a555438abbeb8cfa0c7f171d1a0a6294fa
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp

  Log Message:
  -----------
  cppcheck: Fix DVB test for reserved identifiers.


  Commit: dc66ea8d493f01a56bb99579bee4eb22885dbab1
      https://github.com/MythTV/mythtv/commit/dc66ea8d493f01a56bb99579bee4eb22885dbab1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp

  Log Message:
  -----------
  cppcheck: Clarify calculation precedence for '%' and '?'.


  Commit: 319df53a5b9237ae68f3ea994b4958fbf37aa30a
      https://github.com/MythTV/mythtv/commit/319df53a5b9237ae68f3ea994b4958fbf37aa30a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/spdifencoder.cpp
    M mythtv/libs/libmythtv/mpeg/atsctables.cpp
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp
    M mythtv/libs/libmythtv/recorders/firewiredevice.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp

  Log Message:
  -----------
  cppcheck: Clean up a couple of cstyle cast warnings.

Most of these were replaced with static_cast, a couple with
reinterpret_cast, and a couple were unnecessary an just removed.


  Commit: e70e51d535ed1a63aec58a4c1e741d78658e05b9
      https://github.com/MythTV/mythtv/commit/e70e51d535ed1a63aec58a4c1e741d78658e05b9
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/custompriority.cpp

  Log Message:
  -----------
  cppcheck: Fix redundant assignment in CustomPriority::addClicked.


  Commit: 636a7721d0de5696d77bee374dea4bdcd762593d
      https://github.com/MythTV/mythtv/commit/636a7721d0de5696d77bee374dea4bdcd762593d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/RTjpegN.cpp

  Log Message:
  -----------
  cppcheck: Ignore "redundant assignment" warning in RTjpeg::QuantInit.

Cppcheck doesn't recognize that the variable is being accesses by a
different alias in a union.


  Commit: 574ef221542e0af48d2f5484119d7decc09ccb83
      https://github.com/MythTV/mythtv/commit/574ef221542e0af48d2f5484119d7decc09ccb83
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/eithelper.cpp

  Log Message:
  -----------
  cppcheck: Remove duplicated line in eithelper init_fixup function.


  Commit: 041b216bdcc601530d435aed62bf377bc1de599f
      https://github.com/MythTV/mythtv/commit/041b216bdcc601530d435aed62bf377bc1de599f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/progdetails.cpp

  Log Message:
  -----------
  cppcheck: Fix several "known condition" warnings in mythfrontend.

These are cases where a variable has already been checked for nullptr,
and if true the function has exited. There is no need to have
additional nullptr tests on the same variable.


  Commit: 4b0c14c6b4301968078fa20317cb3a3956918bc3
      https://github.com/MythTV/mythtv/commit/4b0c14c6b4301968078fa20317cb3a3956918bc3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/networkcontrol.cpp

  Log Message:
  -----------
  cppcheck: Fix "known condition warning" in networkcontrol.cpp.

This warning used to be necessary as the code formerly used a
dynamic_cast to convert types. Switching to a simple assignment since
the code was casting to a parent type removed the need for this
validity test.


  Commit: d296a7f7791d03f3c0ab4b69b7c2107de826fab8
      https://github.com/MythTV/mythtv/commit/d296a7f7791d03f3c0ab4b69b7c2107de826fab8
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/scheduleeditor.cpp

  Log Message:
  -----------
  cppcheck: Fix "duplicate condition" warnings in scheduler.

There are several places where the same if condition occurs followed
by a one line else clause. Combine these into a single braced else
clause.


  Commit: fab45020a8089649406eb9287190534c370647ed
      https://github.com/MythTV/mythtv/commit/fab45020a8089649406eb9287190534c370647ed
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/videodlg.cpp

  Log Message:
  -----------
  cppcheck: Fix a couple of condition warnings in videodlg.cpp.

Combine two else clauses into one, and remove an unnecessary if test.


  Commit: 7c926ae538f21585495dbb5c34163057328fd41f
      https://github.com/MythTV/mythtv/commit/7c926ae538f21585495dbb5c34163057328fd41f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythmedia.h

  Log Message:
  -----------
  cppcheck: Fix CastIntegerToAddressAtReturn warning in mythmedia.h.

Be explicit about the conversion from a QPointer back to a regular
pointer.


  Commit: b5ef3f82ad7d2c09bed3ac93320bff4cfb2c56de
      https://github.com/MythTV/mythtv/commit/b5ef3f82ad7d2c09bed3ac93320bff4cfb2c56de
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/guidegrid.h

  Log Message:
  -----------
  cppcheck: Ignore "cast integer to address" warning in guidegrid.

The GuideGrid::GetCurrentProgram function appears to be correctly
returing a ProgramInfo pointer.


  Commit: 7ef8a8cbddb5623f50fbb0a9fb5f2441d5f3a387
      https://github.com/MythTV/mythtv/commit/7ef8a8cbddb5623f50fbb0a9fb5f2441d5f3a387
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/eitfixup.cpp

  Log Message:
  -----------
  cppcheck: Fix "duplicate condition" warnings in EIT fixups.


  Commit: 5ff0f80ae0dc699c564739d0a24ea53938ee6bd1
      https://github.com/MythTV/mythtv/commit/5ff0f80ae0dc699c564739d0a24ea53938ee6bd1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythgame/mythgame/rom_metadata.h
    M mythplugins/mythgame/mythgame/rominfo.h
    M mythtv/libs/libmythbase/mythsorthelper.cpp
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelinfo.h
    M mythtv/libs/libmythtv/recorders/avcinfo.cpp
    M mythtv/libs/libmythtv/recorders/avcinfo.h
    M mythtv/libs/libmythtv/recorders/vboxutils.cpp
    M mythtv/libs/libmythtv/recorders/vboxutils.h
    M mythtv/programs/mythbackend/encoderlink.cpp
    M mythtv/programs/mythfrontend/exitprompt.cpp
    M mythtv/programs/mythfrontend/manualschedule.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h
    M mythtv/programs/mythfrontend/proglist_helpers.cpp
    M mythtv/programs/mythfrontend/proglist_helpers.h

  Log Message:
  -----------
  cppcheck: Move variable initialization to function initialization list.


  Commit: 8cc709e350423af142b107ae7a683bdf4a8569ee
      https://github.com/MythTV/mythtv/commit/8cc709e350423af142b107ae7a683bdf4a8569ee
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/editmetadata.cpp
    M mythplugins/mythmusic/mythmusic/importmusic.cpp
    M mythplugins/mythzoneminder/mythzoneminder/alarmnotifythread.cpp
    M mythtv/libs/libmythtv/DVD/mythdvdbuffer.cpp

  Log Message:
  -----------
  cppcheck: Replace several obsolete usleep calls with nanosleep.


  Commit: 79638ed7fc8d88c582f41bca7366d7857b1bfa5a
      https://github.com/MythTV/mythtv/commit/79638ed7fc8d88c582f41bca7366d7857b1bfa5a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/captions/cc708decoder.cpp

  Log Message:
  -----------
  cppcheck: Fix "known condition" warning in cc708 decoder.

The enum value CLW occurs immediately after the value CW7. Given the
prior and handling of all cases where the value is <= CW7, the "else
if" check for >= CLW is redundant.


  Commit: 0a7690686e38ff504a942db3a4f745db0a39f08c
      https://github.com/MythTV/mythtv/commit/0a7690686e38ff504a942db3a4f745db0a39f08c
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp

  Log Message:
  -----------
  cppcheck: Fix duplicate condition in channelscanner.cpp.

Move the second ("DVB" == card_type) clause inside of the check for
USING_DVB, and combine them into a single "if" test.


  Commit: 4c5790007614c99c0cf005e79a00def438bb1415
      https://github.com/MythTV/mythtv/commit/4c5790007614c99c0cf005e79a00def438bb1415
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
    M mythtv/libs/libmythtv/opengl/mythmediacodecinterop.h
    M mythtv/libs/libmythtv/opengl/mythvtbinterop.h

  Log Message:
  -----------
  cppcheck: Mark several constructors as explicit.


  Commit: 5ba8d18a9bae45ea8d1b362384ef6911d86e08f7
      https://github.com/MythTV/mythtv/commit/5ba8d18a9bae45ea8d1b362384ef6911d86e08f7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/livetvchain.cpp

  Log Message:
  -----------
  cppcheck: Fix "known condition is always true" warning in live tv.


  Commit: 1b723681cc700421859487c4225bfe8dde18227d
      https://github.com/MythTV/mythtv/commit/1b723681cc700421859487c4225bfe8dde18227d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mheg/netstream.cpp

  Log Message:
  -----------
  cppcheck: Quiet bad "sscanf format string wrong number of arguments" warning in mheg.

The right number of arguments are present, they just aren't being
parsed by cppcheck because they use the SCNd64 macro to get the
correct per platform format argument.


  Commit: 38b765de809942765c6799b6025764954bc5efa3
      https://github.com/MythTV/mythtv/commit/38b765de809942765c6799b6025764954bc5efa3
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythframe.h

  Log Message:
  -----------
  cppcheck: Quiet "unused private function" warning in mythframe.


  Commit: 807731abef5c7a2c232a20137a92060c1ed0af81
      https://github.com/MythTV/mythtv/commit/807731abef5c7a2c232a20137a92060c1ed0af81
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythsystemevent.cpp

  Log Message:
  -----------
  cppcheck: Suppress "known condition: warning in mythsystemevent.

Cppcheck doesn't recognize that calling a constructor and passing the
status variable by reference, can allow the value to change.


  Commit: e5be0ea03d73764c44e967b0e4bcf86201c30633
      https://github.com/MythTV/mythtv/commit/e5be0ea03d73764c44e967b0e4bcf86201c30633
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythsystemevent.cpp

  Log Message:
  -----------
  cppcheck: Remove unused variable in myth system.


  Commit: 15500683f02a92097563d8c3050bbfc363520f44
      https://github.com/MythTV/mythtv/commit/15500683f02a92097563d8c3050bbfc363520f44
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/previewgeneratorqueue.cpp

  Log Message:
  -----------
  cppcheck: Fix "known condition" warning in preview generator.


  Commit: 516106c11e7341be251afd61c0066fef246d2f20
      https://github.com/MythTV/mythtv/commit/516106c11e7341be251afd61c0066fef246d2f20
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recordingrule.cpp

  Log Message:
  -----------
  cppcheck: Collapse duplicate conditions into a single clause in recording rule.


  Commit: 6533e58858cd04693a8437080e64a2f246c6e12b
      https://github.com/MythTV/mythtv/commit/6533e58858cd04693a8437080e64a2f246c6e12b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  cppcheck: Fix "known condition warning" in guide grid.


  Commit: 489bedbd08ee614dc21e1aad7514ce111c15dd69
      https://github.com/MythTV/mythtv/commit/489bedbd08ee614dc21e1aad7514ce111c15dd69
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythgame/mythgame/main.cpp

  Log Message:
  -----------
  cppcheck: Use static_cast instead of C cast in mythgame.


  Commit: b28228144c53669c8f618fcddead245df85bbf36
      https://github.com/MythTV/mythtv/commit/b28228144c53669c8f618fcddead245df85bbf36
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythnetvision/mythnetvision/netsearch.cpp

  Log Message:
  -----------
  cppcheck: Fix a couple of warnings about the "returned" variable in mythnetvision.

1) This variable is declared as a "uint" so it can never be less than
zero.  2) One the value of zero has been handled, the test for >0 is
redundant.


  Commit: 11e1e253c2015d953981ae62a7c9220a0252ff66
      https://github.com/MythTV/mythtv/commit/11e1e253c2015d953981ae62a7c9220a0252ff66
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythzoneminder/mythzoneminder/zmplayer.cpp

  Log Message:
  -----------
  cppcheck: Don't check for unsigned less than zero in zmplayer.


  Commit: 4b8115b08124de9571092ec3d95cc5851f1c10a7
      https://github.com/MythTV/mythtv/commit/4b8115b08124de9571092ec3d95cc5851f1c10a7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythmusic/mythmusic/streamview.cpp

  Log Message:
  -----------
  cppcheck: Fix "redundant or possible null dereference" warning in mythmusic.

Move the signal connection for m_countryList inside of the member
variable existence check.


  Commit: 45b0af8bd079eb9ea14eb76e67672039fb75ed42
      https://github.com/MythTV/mythtv/commit/45b0af8bd079eb9ea14eb76e67672039fb75ed42
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythnetvision/mythnetvision/nettree.cpp

  Log Message:
  -----------
  cppcheck: Fix "duplicate condition" warning in mythnetvision.

Collapse two if/else clauses into one.


  Commit: 4bf5a5325188d2004ca9635d257158a8fd8f505e
      https://github.com/MythTV/mythtv/commit/4bf5a5325188d2004ca9635d257158a8fd8f505e
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  cppcheck: Fix a couple of duplicateValueTernary warnings in channel importer.


  Commit: d8532ef8dd35a311bb36c8447586fe7d20625e19
      https://github.com/MythTV/mythtv/commit/d8532ef8dd35a311bb36c8447586fe7d20625e19
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  cppcheck: Comment out an unused variable in xmltv parser.


  Commit: a4ea3d1f5c520baaebb84c02abc69bd016752b7a
      https://github.com/MythTV/mythtv/commit/a4ea3d1f5c520baaebb84c02abc69bd016752b7a
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  cppcheck: Quiet "ignored return value" warning in guidegrid.


  Commit: 9d2b8e96ef1980a63c600085eff2512ae35c1982
      https://github.com/MythTV/mythtv/commit/9d2b8e96ef1980a63c600085eff2512ae35c1982
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/importnative.cpp

  Log Message:
  -----------
  cppcheck: Comment out an unused variable in mytharchive.


  Commit: 3e168532b48ffee1c5d5dc0ac1770bd7e97f6c7d
      https://github.com/MythTV/mythtv/commit/3e168532b48ffee1c5d5dc0ac1770bd7e97f6c7d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mytharchive/mytharchive/exportnative.h

  Log Message:
  -----------
  cppcheck: Pass variable by reference in mytharchive.


  Commit: 5e64f0465daebd8a8e18c7b5e4ffa6a9ec041afc
      https://github.com/MythTV/mythtv/commit/5e64f0465daebd8a8e18c7b5e4ffa6a9ec041afc
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythbase/signalhandling.cpp

  Log Message:
  -----------
  optimized: Fix "strict aliasing" warning in signal handling.


  Commit: cbcad7fe97c738e6c1842f9a25e193293b429281
      https://github.com/MythTV/mythtv/commit/cbcad7fe97c738e6c1842f9a25e193293b429281
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythtv/visualisations/goom/filters.cpp

  Log Message:
  -----------
  cppcheck: Fix unmatched ']' warning in goom.


  Commit: ec09218d5cdd180453c7872ced99d7647f744e24
      https://github.com/MythTV/mythtv/commit/ec09218d5cdd180453c7872ced99d7647f744e24
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythplugins/mythgame/mythgame/rominfo.cpp
    M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
    M mythplugins/mythmusic/mythmusic/decoder.cpp
    M mythtv/libs/libmyth/audio/audiooutputsettings.cpp
    M mythtv/libs/libmythtv/captions/cc608decoder.cpp
    M mythtv/libs/libmythtv/decoders/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/osd.cpp
    M mythtv/libs/libmythtv/recorders/avcinfo.cpp
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/tv_play.h
    M mythtv/libs/libmythtv/tvbrowsehelper.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythui/mythscreensaver.h
    M mythtv/libs/libmythui/mythuiwebbrowser.cpp
    M mythtv/libs/libmythui/platforms/mythscreensaverdrm.cpp
    M mythtv/libs/libmythui/platforms/mythscreensaverdrm.h
    M mythtv/libs/libmythupnp/httprequest.cpp
    M mythtv/libs/libmythupnp/httprequest.h
    M mythtv/programs/mythbackend/autoexpire.cpp
    M mythtv/programs/mythfrontend/globalsettings.cpp
    M mythtv/programs/mythfrontend/guidegrid.cpp

  Log Message:
  -----------
  tidy: Fix a bunch of new warnings.


  Commit: 8ac169c88264c913885e04b238b61b051fa9f3ff
      https://github.com/MythTV/mythtv/commit/8ac169c88264c913885e04b238b61b051fa9f3ff
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/platforms/mythscreensaverdbus.cpp

  Log Message:
  -----------
  tidy: Fix readability-use-anyofallof warning in mythscreensaverdbus.cpp.


  Commit: 8c1ffbaf3e5007263cac614c55eca83796c6e2e4
      https://github.com/MythTV/mythtv/commit/8c1ffbaf3e5007263cac614c55eca83796c6e2e4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-10-02 (Fri, 02 Oct 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythmainwindow.cpp
    M mythtv/libs/libmythui/mythuiscreenbounds.cpp
    M mythtv/libs/libmythui/mythuiscreenbounds.h

  Log Message:
  -----------
  tidy: Fix "invalid case style for protected member" warning.


Compare: https://github.com/MythTV/mythtv/compare/a82e32d72485...8c1ffbaf3e50


More information about the mythtv-commits mailing list