[mythtv-commits] [MythTV/mythtv] bc00a5: MythCommandLineParser: Suppress a few minor warnings

Mark Kendall noreply at github.com
Thu Nov 19 08:59:49 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: bc00a52f2ee3368cc8d78769818219d47de19e59
      https://github.com/MythTV/mythtv/commit/bc00a52f2ee3368cc8d78769818219d47de19e59
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp

  Log Message:
  -----------
  MythCommandLineParser: Suppress a few minor warnings


  Commit: 88f21d2202921996cdafe96e31f00bae3cc2e370
      https://github.com/MythTV/mythtv/commit/88f21d2202921996cdafe96e31f00bae3cc2e370
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythsystemlegacy.cpp
    M mythtv/libs/libmythbase/mythsystemlegacy.h

  Log Message:
  -----------
  MythSystemLegacy: Add myth_system variant that takes argument list


  Commit: b91e65dbd65d95302e452c8ecdccff3c9fd91a04
      https://github.com/MythTV/mythtv/commit/b91e65dbd65d95302e452c8ecdccff3c9fd91a04
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mythtv/programs/mythwelcome/welcomedialog.cpp

  Log Message:
  -----------
  MythWelcome: Pass the Qt QPA platform through to mythfrontend

- if it has not been explicitly set by the user already
- in mosts cases, this will have no impact but with many current Wayland
desktops, Qt has to be encouraged to use Wayland over xcb (even when
there is no X11). In these cases, we need to then ensure that the
mythfrontend instance launched by mythwelcome has the appropriate
platform

Refs #266


  Commit: 64fd0345420d7e481a9631d7cd4ab844ac4d10cc
      https://github.com/MythTV/mythtv/commit/64fd0345420d7e481a9631d7cd4ab844ac4d10cc
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h

  Log Message:
  -----------
  StatusBox: Use a clearer/more explicit description of color depth

- on the display screen


  Commit: 9ddcec8ce54efb8130212aa82aea631453f0db3d
      https://github.com/MythTV/mythtv/commit/9ddcec8ce54efb8130212aa82aea631453f0db3d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-11-19 (Thu, 19 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythpainterwindow.cpp
    M mythtv/libs/libmythui/mythpainterwindow.h

  Log Message:
  -----------
  Wayland: Add workaround for invisible windows...

- Qt 5.11.2 works, Qt 5.14.2 is broken. I'm not sure when it was broken
and if it has subsequently been fixed... but here's the explanation...
- on newer versions of Qt when using Wayland and the xdg-shell
integration (and its variants), our painter window's window
(MythPainterWindow is a widget - which has a window) does not receive an
expose event on startup.
- as a result, calls to MythPainterWindow::update (called from
MythMainWindow::animate) do not result in paintEvent calls being
delivered and we get a blank screen
- this is easily identifiable by checking whether the window is visible
and not exposed (note - we only start checking once we have received a
resizeEvent, which should imply MythPainterWindow itself is visible)
- use a QTimer to start checking - and once the issue appears to be
fixed, stop the timer (note - I'm not sure whether the check should
continue or maybe restarted following a visibility change?)
- the issue is avoidable by forcing Qt to use a non xdg-shell - but the
other shell variants are slowly being deprecated as the xdg-shell spec
is finalised.

Refs #266 (but this does not fix it)


Compare: https://github.com/MythTV/mythtv/compare/8316f85f77de...9ddcec8ce54e


More information about the mythtv-commits mailing list