[mythtv-commits] [MythTV/mythtv] 262062: Add comment pointing to list of checks.

David Hampton noreply at github.com
Mon Nov 9 17:17:59 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 26206232541eca80730f0794dd8b18a7e982de87
      https://github.com/MythTV/mythtv/commit/26206232541eca80730f0794dd8b18a7e982de87
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-07 (Sat, 07 Nov 2020)

  Changed paths:
    M .clazy

  Log Message:
  -----------
  Add comment pointing to list of checks.


  Commit: d9f69b42980345cae53182d40d7db8a977c2e839
      https://github.com/MythTV/mythtv/commit/d9f69b42980345cae53182d40d7db8a977c2e839
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  Pass target object into QObject::connect.

Use the variant of the functor QObject::connect call that takes a
target object.  This will cause the connection to be broken when the
target object is deleted.


  Commit: 56a685ae6442e8b0116567b12b05db4c11d20a17
      https://github.com/MythTV/mythtv/commit/56a685ae6442e8b0116567b12b05db4c11d20a17
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  Better solution for quieting "lambda in connect" warnings.

Convert these lambda function callbacks to use a return value that is
member variable instead of a function local variable.


  Commit: 0ee48dbafddf579b972fd6ad213851a5551a0390
      https://github.com/MythTV/mythtv/commit/0ee48dbafddf579b972fd6ad213851a5551a0390
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/satipstreamhandler.h

  Log Message:
  -----------
  tidy: Provide an initializer for m_frontend.


  Commit: 22534cb9480a040eb65550697e70e4e7bace6ca1
      https://github.com/MythTV/mythtv/commit/22534cb9480a040eb65550697e70e4e7bace6ca1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  tidy: Fix misleading indent warning.

Using the NOLINT comment here seems to be the only available
solution. Adding spacing between this line and the previous line
doesn't help, and removing the "emit" keyword or putting it on a
separate line causes a clazy readability warning that the code is
calling a signal without "emit".


  Commit: be056f11d1744fba0b13d768ba58731ed8b4c8a4
      https://github.com/MythTV/mythtv/commit/be056f11d1744fba0b13d768ba58731ed8b4c8a4
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.h
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.cpp
    M mythtv/libs/libmythtv/AirPlay/mythraopdevice.h

  Log Message:
  -----------
  clazy: Fix "overriding signal with non-signal" warnings in AirPlay.

"newConnection" is a signal in the parent class, so rename the slots
in the derived classes from "newConnection" to something unique.


  Commit: 82df01b5e48d55162cbb657d6703b5e88adde4ef
      https://github.com/MythTV/mythtv/commit/82df01b5e48d55162cbb657d6703b5e88adde4ef
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/networkcontrol.h

  Log Message:
  -----------
  clazy: Fix "overriding signal with non-signal" warnings in network control.

"newConnection" is a signal in the parent class, so rename the slots
in the derived classes from "newConnection" to something unique.


  Commit: 3a243d67f1c887e8f1df2151eca54d69819180b6
      https://github.com/MythTV/mythtv/commit/3a243d67f1c887e8f1df2151eca54d69819180b6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-11-09 (Mon, 09 Nov 2020)

  Changed paths:
    M mythtv/libs/libmythtv/diseqcsettings.cpp
    M mythtv/libs/libmythtv/diseqcsettings.h

  Log Message:
  -----------
  clazy: Fix "overriding signal with non-signal" warnings in diseqcsettings.

"valueChanged" is a signal in the grandparent class, so rename the
slot in the derived classes from "valueChanged" to "newValue".


Compare: https://github.com/MythTV/mythtv/compare/62af17be20a0...3a243d67f1c8


More information about the mythtv-commits mailing list