[mythtv-commits] Ticket #13625: Insure mythfilldatabase issues reschedule even if --no-mark-repeats is given

MythTV noreply at mythtv.org
Sun May 24 21:45:32 UTC 2020


#13625: Insure mythfilldatabase issues reschedule even if --no-mark-repeats is
given
-------------------------------------------+--------------------------
     Reporter:  Gary Buhrmaster            |      Owner:  (none)
         Type:  Patch - Bug Fix            |     Status:  new
     Priority:  minor                      |  Milestone:  needs_triage
    Component:  MythTV - Mythfilldatabase  |    Version:  Master Head
     Severity:  medium                     |   Keywords:
Ticket locked:  0                          |
-------------------------------------------+--------------------------
 Insure mythfilldatabase issues reschedule even if --no-mark-repeats is
 given

 Ticket created by request of dev from oob discussion.

 Mythfilldatabase currently skips the reschedule if the --no-mark-repeats
 command line option is given, even if other changes to the program
 database have occurred (which is likely for any real run with real data).

 Mitigation: Don't use --no-mark-repeats (which is likely a very rare use
 case), or run a separate request (`mythutil --resched`) to force a
 reschedule after running mythfilldatabase with --no-mark-repeats.

 Lightly tested proposed patch follows:

 {{{
 diff --git a/mythtv/programs/mythfilldatabase/main.cpp
 b/mythtv/programs/mythfilldatabase/main.cpp
 index aa6c33ace2..dba30522f8 100644
 --- a/mythtv/programs/mythfilldatabase/main.cpp
 +++ b/mythtv/programs/mythfilldatabase/main.cpp
 @@ -660,9 +660,8 @@ int main(int argc, char *argv[])
              "| the master backend is restarted.
 |\n"
 "===============================================================");

 -    if (mark_repeats)
 -        ScheduledRecording::RescheduleMatch(0, 0, 0, QDateTime(),
 -                                            "MythFillDatabase");
 +    ScheduledRecording::RescheduleMatch(0, 0, 0, QDateTime(),
 +                                        "MythFillDatabase");

      gCoreContext->SendMessage("CLEAR_SETTINGS_CACHE");

 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13625>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list