[mythtv-commits] [MythTV/mythtv] f719c9: mythtranscode: Fix leak of HLS object on error

Sun Mar 8 08:28:19 UTC 2020

  Branch: refs/heads/fixes/31
  Home:   https://github.com/MythTV/mythtv
  Commit: f719c938d5d621b5c58e1fc380171e6ac00fdd90
      https://github.com/MythTV/mythtv/commit/f719c938d5d621b5c58e1fc380171e6ac00fdd90
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/programs/mythtranscode/transcode.cpp

  Log Message:
  -----------
  mythtranscode: Fix leak of HLS object on error

- per coverity

(cherry picked from commit 1d3bc7b58b7b6045414af5548022c78fd9c148e9)


  Commit: 0ad87021b9421f372f066e811fa5d4643d554d03
      https://github.com/MythTV/mythtv/commit/0ad87021b9421f372f066e811fa5d4643d554d03
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/pink.h

  Log Message:
  -----------
  libmyth: Fix coverity 'out-of-bounds access' warning in pink

(cherry picked from commit 3a596b9981197af05305e59541afe9a1ac22387d)


  Commit: 1cb76970b3d6b7603491cba7a9e7fdc047630de4
      https://github.com/MythTV/mythtv/commit/1cb76970b3d6b7603491cba7a9e7fdc047630de4
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.h

  Log Message:
  -----------
  audiogeneralsettings: Squash a few cland-tidy warnings

(cherry picked from commit f6ba4a620945541ba261683c1c240db2a321f048)


  Commit: 288b7e6592aa43eefee0f1183991e71fa69de6a1
      https://github.com/MythTV/mythtv/commit/288b7e6592aa43eefee0f1183991e71fa69de6a1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  ExternalStreamHandler: Fix 'non-array delete for scalars' (coverity)

(cherry picked from commit 8806e4108688a9c2ae7397718e2c28309812b325)


  Commit: bad55296d1ab18b27ef76b3d3d76830f4a9a57ba
      https://github.com/MythTV/mythtv/commit/bad55296d1ab18b27ef76b3d3d76830f4a9a57ba
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp

  Log Message:
  -----------
  AudioOutputBase: Fix coverity 'Unintentional integer overflow'

(cherry picked from commit 4ad4c566305149d831f2d1a01a36714c1bab9497)


  Commit: b9ca35ca6704fa648173c1a57e1063a9926829e1
      https://github.com/MythTV/mythtv/commit/b9ca35ca6704fa648173c1a57e1063a9926829e1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicLogoDetector.cpp
    M mythtv/programs/mythcommflag/ClassicLogoDetector.h
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.cpp
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.h

  Log Message:
  -----------
  mythcommflag: Suppress coverity leak warnings

- there is no point in deleting resources in deleteLater
- technically these would not be leaked but coverity cannnot see this
- the use of deleteLater in various mythcommflag classes appears to
serve no useful purpose.

(cherry picked from commit f8fa82d5a3a23f0af5a1d409bfb472879c9e2b70)


  Commit: cad10add0b809b4f96d0b1e970650971ae7b138c
      https://github.com/MythTV/mythtv/commit/cad10add0b809b4f96d0b1e970650971ae7b138c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h

  Log Message:
  -----------
  MythRenderOpenGL: Initial compute shader support

(cherry picked from commit 599a7ba92fa90bbac66c4bc41c720311cfeb7e68)


  Commit: dc2aefb0e6999b6252ed99447989086c8eeceb90
      https://github.com/MythTV/mythtv/commit/dc2aefb0e6999b6252ed99447989086c8eeceb90
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h

  Log Message:
  -----------
  MythRenderOpenGL: Improve core profile support

(cherry picked from commit 6208b051cfb2904b78916c945a1ae80469d4bf28)


  Commit: 765aa0ce62ca788b53cafd44ed0f1155714b2365
      https://github.com/MythTV/mythtv/commit/765aa0ce62ca788b53cafd44ed0f1155714b2365
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythrender_base.h

  Log Message:
  -----------
  MythRender: Make ReleaseResources protected

(cherry picked from commit 891d5fc8885c89214b90ffb2ce8eb708f87d2eb4)


  Commit: 5607179bb31fa1fd96b74f7095bf6680ac2550a8
      https://github.com/MythTV/mythtv/commit/5607179bb31fa1fd96b74f7095bf6680ac2550a8
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/opengl/mythmediacodecinterop.cpp
    M mythtv/libs/libmythtv/opengl/mythmmalinterop.cpp

  Log Message:
  -----------
  OpenGL: Fix 2 cases of direct OpenGL calls

- all calls need to use MythRenderOpenGL

(cherry picked from commit 0a45f67e53fecec4009a231fd77fc4127420dfa9)


  Commit: ba93524811921a43b1acbcdd8ca03976d07387ab
      https://github.com/MythTV/mythtv/commit/ba93524811921a43b1acbcdd8ca03976d07387ab
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/services/frontend.cpp

  Log Message:
  -----------
  frontend (Services API): Reset screensaver in SendAction

- Fixes #10886

(cherry picked from commit dab6126de3f8b86f443b92011453286dd51e9e04)


  Commit: 1ea97269d8175ad0edfc652da2d602548ee9d3aa
      https://github.com/MythTV/mythtv/commit/1ea97269d8175ad0edfc652da2d602548ee9d3aa
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythbase/plist.cpp

  Log Message:
  -----------
  PList: Fix cppcheck portability warnings

(cherry picked from commit fda93868afcc8a6a90262ceaf71324bcbfe8e277)


  Commit: e4c80f19e440005e96b4ddbe9fcb513c47dea285
      https://github.com/MythTV/mythtv/commit/e4c80f19e440005e96b4ddbe9fcb513c47dea285
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythsystemlegacy.h
    M mythtv/libs/libmythtv/mheg/dsmcccache.cpp
    M mythtv/libs/libmythtv/mheg/dsmcccache.h
    M mythtv/libs/libmythtv/recorders/HLS/HLSStream.h

  Log Message:
  -----------
  cppcheck: Fix a few style warnings

(cherry picked from commit 1ea77568ce7eb5947517ac29123b4814f4588747)


  Commit: 76624f0a9d544be5fb32571c476e8139cea84784
      https://github.com/MythTV/mythtv/commit/76624f0a9d544be5fb32571c476e8139cea84784
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythui/opengl/mythrenderopengl.cpp
    M mythtv/libs/libmythui/opengl/mythrenderopengl.h

  Log Message:
  -----------
  MythRenderOpenGL: Minor cleanup

(cherry picked from commit 81a65c06f5422d84579b9a33fccb168a268e5a84)


  Commit: 252c0905485183760c72792c54b1fad020161760
      https://github.com/MythTV/mythtv/commit/252c0905485183760c72792c54b1fad020161760
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/teletextreader.cpp
    M mythtv/libs/libmythtv/teletextreader.h

  Log Message:
  -----------
  TeletextReader: Ensure TeletextMagazine is properly initialised

(cherry picked from commit 2ca15e648cb8abd4a1a81e4a6ed9dcb8ea41668a)


  Commit: 0e25152edbb1d89315a67dd509dc31f2b67dabdb
      https://github.com/MythTV/mythtv/commit/0e25152edbb1d89315a67dd509dc31f2b67dabdb
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/netstream.cpp

  Log Message:
  -----------
  NetStream: Squash cppcheck sscanf warning

(cherry picked from commit cb3a4ccab6907219c147042f152045c7e6ee464b)


  Commit: 23e8bf73f9e7b788725172e8c3088f32bc0156e2
      https://github.com/MythTV/mythtv/commit/23e8bf73f9e7b788725172e8c3088f32bc0156e2
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythdeque.h
    M mythtv/libs/libmythbase/portchecker.cpp
    M mythtv/libs/libmythtv/HLS/m3u.cpp

  Log Message:
  -----------
  cppcheck: Suppress a few false positives

(cherry picked from commit bf60e3109fbc983b3f433ef6a277c90c16003158)


  Commit: ca3608eb63c727b9ebfd85357a398a1efc7f39eb
      https://github.com/MythTV/mythtv/commit/ca3608eb63c727b9ebfd85357a398a1efc7f39eb
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.h

  Log Message:
  -----------
  VideoDisplayProfile: Extend Setinput to disregard decoders

- which will be used to fallthrough to other decoders when certain
hardware decoders are unavailable

(cherry picked from commit 780555dc5676d2a5c8883ef78fed5156b402fa19)


  Commit: 240038b689f7b9ad3cfa990ba7ce8ff3e707674b
      https://github.com/MythTV/mythtv/commit/240038b689f7b9ad3cfa990ba7ce8ff3e707674b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/decoders/avformatdecoder.cpp

  Log Message:
  -----------
  AvFormatDecoder: Fallback to alternative decoders when necessary

- if a (hardware) decoder is not available, disallow it in the
VideoDisplayProfile and try again
- note - this only works when the decoder fails pre-setup checks (which
are pretty good for most decoders except MMAL, VideoToolbox and V4L2
Codecs). A subsequent decoder failure will still fallback directly to
software decoding.
- note - this is unlikely to be useful in the vast majority of cases;
there is often only one hardware decoder available and for those
decoders, the pre-setup checks are good.
- it is also advisable to setup a 'catchall' fallback profile item that
ensures there are useful CPU and deinterlacer settings when hardware
decoding is not available.
- Refs #10602

(cherry picked from commit fb01cb3f43f0f481a35abf7cfba6b4b5ccfc70c8)


  Commit: f927c14d7658e414c6dc1bb7247679f652f1f4d5
      https://github.com/MythTV/mythtv/commit/f927c14d7658e414c6dc1bb7247679f652f1f4d5
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/videodisplayprofile.cpp

  Log Message:
  -----------
  VideoDisplayProfile: Ensure each profile group has a software fallback

- and has sensible defaults (if it uses hardware decoders)

(cherry picked from commit 4ac3a088dff2724d03e2a46d9c24f0acde1e128c)


  Commit: 82442cb3a409d8d336450a89ccc5d22db8520de9
      https://github.com/MythTV/mythtv/commit/82442cb3a409d8d336450a89ccc5d22db8520de9
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/galleryviews.cpp
    M mythtv/programs/mythfrontend/galleryviews.h

  Log Message:
  -----------
  mythfrontend: Workaround Qt14 QSet depcrecated warnings

- instead of using the new iterator style constructors, just use some
regular code which should be as efficient and doesn't require any
ifdeferry for Qt versions

(cherry picked from commit 5e66ba299fbae03f2a25d6ef82fc0b23ed9b3fbf)


  Commit: e9e928b19b0add4ba5f4806010364a3ff19ad686
      https://github.com/MythTV/mythtv/commit/e9e928b19b0add4ba5f4806010364a3ff19ad686
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-08 (Sun, 08 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythdeque.h
    M mythtv/libs/libmythtv/HLS/m3u.cpp

  Log Message:
  -----------
  cppcheck: Try and use the correct suppression

(cherry picked from commit 68e4660fa001d2f299ee7fc4df8ed3712e40a4e2)


Compare: https://github.com/MythTV/mythtv/compare/7097da34c8ff...e9e928b19b0a