[mythtv-commits] [MythTV/mythtv] cf2825: mythfilldatabase: Fix 2 potential leaks

Mark Kendall noreply at github.com
Tue Mar 3 14:23:49 UTC 2020


  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: cf282591a249864215c82cb7248153b3033d6ea1
      https://github.com/MythTV/mythtv/commit/cf282591a249864215c82cb7248153b3033d6ea1
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/programs/mythfilldatabase/xmltvparser.cpp

  Log Message:
  -----------
  mythfilldatabase: Fix 2 potential leaks

- introduced in a9aa006139da24cb and picked up by coverity.


  Commit: 1d3bc7b58b7b6045414af5548022c78fd9c148e9
      https://github.com/MythTV/mythtv/commit/1d3bc7b58b7b6045414af5548022c78fd9c148e9
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/programs/mythtranscode/transcode.cpp

  Log Message:
  -----------
  mythtranscode: Fix leak of HLS object on error

- per coverity


  Commit: 3a596b9981197af05305e59541afe9a1ac22387d
      https://github.com/MythTV/mythtv/commit/3a596b9981197af05305e59541afe9a1ac22387d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/pink.h

  Log Message:
  -----------
  libmyth: Fix coverity 'out-of-bounds access' warning in pink


  Commit: f6ba4a620945541ba261683c1c240db2a321f048
      https://github.com/MythTV/mythtv/commit/f6ba4a620945541ba261683c1c240db2a321f048
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/programs/mythfrontend/audiogeneralsettings.cpp
    M mythtv/programs/mythfrontend/audiogeneralsettings.h

  Log Message:
  -----------
  audiogeneralsettings: Squash a few cland-tidy warnings


  Commit: 8806e4108688a9c2ae7397718e2c28309812b325
      https://github.com/MythTV/mythtv/commit/8806e4108688a9c2ae7397718e2c28309812b325
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/ExternalStreamHandler.cpp

  Log Message:
  -----------
  ExternalStreamHandler: Fix 'non-array delete for scalars' (coverity)


  Commit: 4ad4c566305149d831f2d1a01a36714c1bab9497
      https://github.com/MythTV/mythtv/commit/4ad4c566305149d831f2d1a01a36714c1bab9497
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputbase.cpp

  Log Message:
  -----------
  AudioOutputBase: Fix coverity 'Unintentional integer overflow'


  Commit: f8fa82d5a3a23f0af5a1d409bfb472879c9e2b70
      https://github.com/MythTV/mythtv/commit/f8fa82d5a3a23f0af5a1d409bfb472879c9e2b70
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2020-03-03 (Tue, 03 Mar 2020)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicLogoDetector.cpp
    M mythtv/programs/mythcommflag/ClassicLogoDetector.h
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.cpp
    M mythtv/programs/mythcommflag/ClassicSceneChangeDetector.h

  Log Message:
  -----------
  mythcommflag: Suppress coverity leak warnings

- there is no point in deleting resources in deleteLater
- technically these would not be leaked but coverity cannnot see this
- the use of deleteLater in various mythcommflag classes appears to
serve no useful purpose.


Compare: https://github.com/MythTV/mythtv/compare/1a53afffefb0...f8fa82d5a3a2


More information about the mythtv-commits mailing list