[mythtv-commits] [MythTV/mythtv] e460f1: tidy: Fix false positive warning in test code.

Tue Jun 16 11:57:21 UTC 2020

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: e460f127ab702ed194b3d77af0a17ebefae6c3e1
      https://github.com/MythTV/mythtv/commit/e460f127ab702ed194b3d77af0a17ebefae6c3e1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M mythtv/libs/libmythbase/test/test_lcddevice/test_lcddevice.cpp

  Log Message:
  -----------
  tidy: Fix false positive warning in test code.

  Commit: b5464d904e0cec611a90949c18b3473934bb5092
      https://github.com/MythTV/mythtv/commit/b5464d904e0cec611a90949c18b3473934bb5092
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/musicfilescanner.h
    M mythtv/libs/libmythtv/mythavutil.cpp
    M mythtv/programs/mythbackend/services/video.cpp

  Log Message:
  -----------
  Fix warnings from the clang-tidy builder.

  Commit: ddaa8bd94a1055f33105d3fdb7265304e7a66498
      https://github.com/MythTV/mythtv/commit/ddaa8bd94a1055f33105d3fdb7265304e7a66498
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M mythtv/libs/libmythtv/mythavutil.cpp

  Log Message:
  -----------
  Fix potential null pointer dereference in mythavutil.cpp.

Validate that codeccpar is valid before trying to access the
codec_type. Collapse the previous validation check with this code.
Pointed out by the clang-tidy NullDereference checker.

  Commit: 498502a5ebba1c6fdac53845bf0059fb4f5b66f1
      https://github.com/MythTV/mythtv/commit/498502a5ebba1c6fdac53845bf0059fb4f5b66f1
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-15 (Mon, 15 Jun 2020)

  Changed paths:
    M mythtv/external/FFmpeg/libavcodec/get_bits.h
    M mythtv/external/FFmpeg/libavcodec/golomb.h

  Log Message:
  -----------
  tidy: Quiet a couple of warnings in FFmpeg.

The FFmpeg sources themselves aren't run through clang-tidy, but a
couple of header files generate a potential NullDereference warning
when they are included from one of the MythTV sources.  Quiet these
warnings to get one step closer to being able to add the
NullDereferences checks to the automated builds.

  Commit: 6491189451f450e6e5787616ad27d3959b11a84b
      https://github.com/MythTV/mythtv/commit/6491189451f450e6e5787616ad27d3959b11a84b
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M mythtv/configure
    M mythtv/external/libexiv2/libexiv2.pro

  Log Message:
  -----------
  Pass configure LDFLAGS into the Makefiles.

  Commit: 3e1af480338f552f19971576d73fb2894b4508f7
      https://github.com/MythTV/mythtv/commit/3e1af480338f552f19971576d73fb2894b4508f7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M mythtv/configure
    M mythtv/external/FFmpeg/configure

  Log Message:
  -----------
  Pass the correct stack-alignment flag to the clang compiler.

  Commit: 63d913665fab4fb2ee0a816f4941216323d12402
      https://github.com/MythTV/mythtv/commit/63d913665fab4fb2ee0a816f4941216323d12402
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M .gitignore
    M mythtv/configure
    M mythtv/libs/libmyth/test/test_audioconvert/.gitignore
    M mythtv/libs/libmyth/test/test_audioutils/.gitignore
    M mythtv/libs/libmyth/test/test_programinfo/.gitignore
    M mythtv/libs/libmythbase/test/test_mythsystem/.gitignore
    M mythtv/libs/libmythbase/test/test_mythsystemlegacy/.gitignore
    M mythtv/libs/libmythbase/test/test_template/.gitignore
    M mythtv/libs/libmythmetadata/test/test_videometadata/.gitignore
    M mythtv/libs/libmythservicecontracts/test/test_datacontracts/.gitignore
    M mythtv/libs/libmythtv/test/test_avcinfo/.gitignore
    M mythtv/libs/libmythtv/test/test_copyframes/.gitignore
    M mythtv/libs/libmythtv/test/test_eitfixups/.gitignore
    M mythtv/libs/libmythtv/test/test_iptvrecorder/.gitignore
    M mythtv/libs/libmythtv/test/test_mpegtables/.gitignore
    M mythtv/libs/libmythtv/test/test_mythiowrapper/.gitignore

  Log Message:
  -----------
  Get gcov working again for gcc and clang.

Works for gcc.  When compiling with clang and gcov support, clang
crashes while compiling the file mythfifowriter.cpp.  A bug report
needs to be filed against clang.

  Commit: 35f79e9156126545b109ae0c5a7e7765ed409ae6
      https://github.com/MythTV/mythtv/commit/35f79e9156126545b109ae0c5a7e7765ed409ae6
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-06-16 (Tue, 16 Jun 2020)

  Changed paths:
    M mythtv/programs/scripts/unittests.sh

  Log Message:
  -----------
  Have unittests.sh set LD_LIBRARY_PATH on FreeBSD.

This is needed because of the way various systems handle interactions
between the RPATH specifications and the "--as-needed" linker flag.

RPATH specifies the runtime path to use when loading libraries.

The "--as-needed" linker flag affects how dependency information
is written into a program executable.  Without the "--as-needed"
linker flag, the linker will write dependency information into the
executable for every library listed on the command line.  With the
"--as-needed" flag the linker will only write dependency information
into the executable for libraries that are directly called from the
program.

On Linux and OSX, the RPATH specifications in the executable program
are used for loading all libraries.  If a library is not listed in the
executable but is listed as a dependency for a loaded library, it is
still the RPATH specifications from the program that are used for
loading the library.

On FreeBSD however, the RPATH specification in the executable is only
used for loading libraries *that* *are* *specified* *in* *the*
*executable*.  If one library depends upon another library, and that
library isn't listed in the executable because the "--as-needed" flag
was specified, then it is the RPATH values in the first library are
used to load the second library.  Since none of our libraries are
compiled with embedded RPATH specifications, the dependent library
cannot be found if isn't in the default system library locations.
FreeBSD does honor the LD_LIBRARY_PATH variable, so setting that
allows the libraries to be found even when the "--as-needed" linker
flag is used.

Compare: https://github.com/MythTV/mythtv/compare/82ffe9d36cf6...35f79e915612