[mythtv-commits] [MythTV/mythtv] b56213: Fix tidy "make parameter a const reference" warning.

linuxdude42 noreply at github.com
Wed Jul 22 21:13:29 UTC 2020 

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: b56213e2c53f20ae9f3eb3cc6e1c666fc29f03ef
      https://github.com/MythTV/mythtv/commit/b56213e2c53f20ae9f3eb3cc6e1c666fc29f03ef
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/cetonrtsp.cpp

  Log Message:
  -----------
  Fix tidy "make parameter a const reference" warning.


  Commit: c79b1ae9373bbb308330ede18ff7dd7963450df7
      https://github.com/MythTV/mythtv/commit/c79b1ae9373bbb308330ede18ff7dd7963450df7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythplugins/settings.pro
    M mythtv/settings.pro

  Log Message:
  -----------
  Mark the Qt include directories as system header directories.

This covers cases where the Qt headers aren't part of the standard
system include directories.  For some reason it doesn't work on
Android.


  Commit: 567f2321d05712e5c3e12ee64aaea643cd5ed6de
      https://github.com/MythTV/mythtv/commit/567f2321d05712e5c3e12ee64aaea643cd5ed6de
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Remove some wshadow and nullptr availability checks.

Given the requirement for Qt5.9, the platforms that needed these
checks are no longer supported, so the checks can be removed.


  Commit: f78bc4a60dbda3b4e20eeb44ed0dcc2b33e939dc
      https://github.com/MythTV/mythtv/commit/f78bc4a60dbda3b4e20eeb44ed0dcc2b33e939dc
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/musicfilescanner.h
    M mythtv/libs/libmythtv/captions/subtitlescreen.h
    M mythtv/libs/libmythtv/channelsettings.cpp
    M mythtv/libs/libmythtv/mythavutil.h
    M mythtv/libs/libmythtv/recorders/satiprtcppacket.h
    M mythtv/libs/libmythtv/recorders/satiprtsp.h
    M mythtv/libs/libmythui/mythpainterwindow.h
    M mythtv/libs/libmythui/mythpainterwindowqt.h
    M mythtv/libs/libmythui/opengl/mythpainterwindowopengl.h

  Log Message:
  -----------
  tidy: Mark some constructors as "explicit".

The clang-tidy "explicit constructor" checker pointed out a couple of
places where constructors should be marked as explicit.

https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html


  Commit: 2be62bdd2b762278a028b8299dc0be73a70a2856
      https://github.com/MythTV/mythtv/commit/2be62bdd2b762278a028b8299dc0be73a70a2856
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythmetadata/musicmetadata.cpp
    M mythtv/libs/libmythmetadata/musicmetadata.h

  Log Message:
  -----------
  Switch the AlbumArt::addImage parameter from a reference to a pointer.

Marking the AlbumArt constructor as explicit pointed out that all the
callers to the addImage() function were passing a pointer where the
function expected a reference, and the compiler was implicitly
converting between the two.  Rewrite this function to take a pointer,
and thus eliminate all the implicit conversions from pointer to
reference. Add a couple of "const" keywords.

https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html


  Commit: 8ff2a2f4b9c85de07bcb6a69685fde7daeb8955d
      https://github.com/MythTV/mythtv/commit/8ff2a2f4b9c85de07bcb6a69685fde7daeb8955d
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythcommandlineparser.cpp
    M mythtv/libs/libmythbase/mythcoreutil.cpp
    M mythtv/libs/libmythbase/mythversion.h
    M mythtv/libs/libmythui/myththemedmenu.cpp
    M mythtv/libs/libmythupnp/httpserver.cpp
    M mythtv/libs/libmythupnp/upnpdevice.cpp
    M mythtv/programs/mythbackend/backendhousekeeper.cpp
    M mythtv/programs/mythfrontend/networkcontrol.cpp
    M mythtv/programs/mythfrontend/services/frontend.cpp
    M mythtv/programs/mythfrontend/statusbox.cpp
    M mythtv/programs/mythfrontend/themechooser.cpp

  Log Message:
  -----------
  Limit include of version.h to a single file.

This change introduces accessor functions for retrieving the current
git version and branch name. This reduces the recompilation necessary
because of a version change to a single file, down from ten.


  Commit: 822a4f5e139e082fa2e418f930a5521741dd7205
      https://github.com/MythTV/mythtv/commit/822a4f5e139e082fa2e418f930a5521741dd7205
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythui/mythrect.cpp
    M mythtv/libs/libmythui/mythrect.h
    M mythtv/libs/libmythui/mythuitype.cpp
    M mythtv/libs/libmythui/mythuitype.h

  Log Message:
  -----------
  Add some explicit functions for manipulating a MythPoint/QPoint.

Some issues show up when changing MythPoint to have an explicit
constructor.  Add some specific functions to handle a QPoint being
passed to a function where a MythPoint was expected.  Two of the three
new functions simplify the necessary processing.


  Commit: d6eb8609f9f07a915248000a1e6ad8f6390d4b9f
      https://github.com/MythTV/mythtv/commit/d6eb8609f9f07a915248000a1e6ad8f6390d4b9f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythplugins/mythbrowser/mythbrowser/mythflashplayer.cpp
    M mythplugins/mythbrowser/mythbrowser/webpage.cpp
    M mythtv/libs/libmythtv/captions/subtitlescreen.cpp
    M mythtv/libs/libmythtv/captions/teletextscreen.cpp
    M mythtv/libs/libmythtv/mheg/interactivescreen.cpp
    M mythtv/libs/libmythui/mythrect.cpp
    M mythtv/libs/libmythui/mythrect.h
    M mythtv/libs/libmythui/mythuisimpletext.cpp
    M mythtv/libs/libmythui/mythuitext.cpp
    M mythtv/libs/libmythui/mythuitype.cpp
    M mythtv/libs/libmythui/mythuitype.h

  Log Message:
  -----------
  Add some explicit functions for manipulating a MythRect/QRect.

Some issues show up when changing MythRect to have an explicit
constructor.  Add some specific functions to handle a QRect being
passed to a function where a MythRect was expected.  These new
functions simplify the necessary processing by eliminating QRect ->
MythRect ->QRect conversions.  Add a handful of explicit conversions
from QRect to MythRect.

Future work could include writing news MythUIType::SetArea and
MythUIType::SetMinArea functions that operate on a QRect. Adding these
will require adding similar override functions to every subclass that
redefines SetArea or SetMinArea. At this time it was simpler to add
the explicit conversions mentioned before.


  Commit: d1897ae2043791c919f37da839a41649eb8990ad
      https://github.com/MythTV/mythtv/commit/d1897ae2043791c919f37da839a41649eb8990ad
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythbase/mythcorecontext.cpp
    M mythtv/libs/libmythbase/mythcorecontext.h
    M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
    M mythtv/libs/libmythtv/tv_play.cpp

  Log Message:
  -----------
  Change several functions to replace varags with a std::vector.

These two functions take a variable umber of the same argument, and it
is easy to replace that with a vector and greatly simplify the
processing of the arguments.  These functions were pointed out by the
clang-tidy cert-dcl50-cpp check.

https://clang.llvm.org/extra/clang-tidy/checks/cert-dcl50-cpp.html


  Commit: 3f57921b1c97200b1e79f2c13b3ae099f5b1c1fb
      https://github.com/MythTV/mythtv/commit/3f57921b1c97200b1e79f2c13b3ae099f5b1c1fb
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Update configure libdav1d version check to match FFmpeg configure.


  Commit: 6b673aabd951e40df6af54c51d4c07f09295e68f
      https://github.com/MythTV/mythtv/commit/6b673aabd951e40df6af54c51d4c07f09295e68f
  Author: David Hampton <mythtv at love2code.net>
  Date:   2020-07-22 (Wed, 22 Jul 2020)

  Changed paths:
    M mythtv/libs/libmythfreesurround/freesurround.cpp

  Log Message:
  -----------
  Fix some minor warnings in freesurround.cpp


Compare: https://github.com/MythTV/mythtv/compare/1d56b04ef76a...6b673aabd951

More information about the mythtv-commits mailing list