[mythtv-commits] [MythTV/mythtv] 9dfa5c: Fixes #13467 - Handle null blocks in DSMCC

Mark Kendall noreply at github.com
Tue Sep 17 12:09:44 UTC 2019


  Branch: refs/heads/devel/2019-render
  Home:   https://github.com/MythTV/mythtv
  Commit: 9dfa5c7a70bb422d748ab327f4b1a0cb3e435794
      https://github.com/MythTV/mythtv/commit/9dfa5c7a70bb422d748ab327f4b1a0cb3e435794
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/dsmccobjcarousel.cpp

  Log Message:
  -----------
  Fixes #13467 - Handle null blocks in DSMCC


  Commit: 7924ad992c75c2dad04eef992d51c349d9e4a64d
      https://github.com/MythTV/mythtv/commit/7924ad992c75c2dad04eef992d51c349d9e4a64d
  Author: Paul Harrison <pharrison at mythtv.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp

  Log Message:
  -----------
  mythzmserver: don't try to get the shared memory pointers for a disabled Monitor

Also allow for a NULL result for the Host field in the Monitors table.
Fixes #13466


  Commit: 13ec89b65ea4a95dafbdfc31ff27a621ca126860
      https://github.com/MythTV/mythtv/commit/13ec89b65ea4a95dafbdfc31ff27a621ca126860
  Author: Tom Dexter <digitalaudiorock at gmail.com>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M mythtv/configure

  Log Message:
  -----------
  Gentoo users may not have nvidia-settings utils installed. From https://bugs.gentoo.org/688084

Signed-off-by: Stuart Auchterlonie <stuarta at mythtv.org>


  Commit: afa06ff24e5f76d230e6ff7516e8534f6d0675d8
      https://github.com/MythTV/mythtv/commit/afa06ff24e5f76d230e6ff7516e8534f6d0675d8
  Author: John Poet <jpoet at mythtv.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythservicecontracts/services/guideServices.h
    M mythtv/programs/mythbackend/services/guide.cpp
    M mythtv/programs/mythbackend/services/guide.h

  Log Message:
  -----------
  Services API: Add WithInvisible params to GetProgramGuide and GetProgramList


  Commit: 850c539b5956c6a76890b24557fd20b6460949e3
      https://github.com/MythTV/mythtv/commit/850c539b5956c6a76890b24557fd20b6460949e3
  Author: John Poet <jpoet at mythtv.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.h

  Log Message:
  -----------
  MetadataOptions: Add an optional inetref clear button.

Useful when the user does not have a keyboard handy.


  Commit: d55578b4f9db41fcc95aa7666aa35badb90a6e02
      https://github.com/MythTV/mythtv/commit/d55578b4f9db41fcc95aa7666aa35badb90a6e02
  Author: John Poet <jpoet at mythtv.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h

  Log Message:
  -----------
  RecMetadataEdit: Add an optional inetref clear button.

Useful when the user does not have a keyboard handy.


  Commit: 1c1268dc5ee0d443e720b7a16aa51e511c6a4b9e
      https://github.com/MythTV/mythtv/commit/1c1268dc5ee0d443e720b7a16aa51e511c6a4b9e
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-13 (Sat, 13 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/tv_rec.cpp

  Log Message:
  -----------
  Typo's in comment.


  Commit: a4a64bf4af07f8e045c1941e13cd6a27e346fae3
      https://github.com/MythTV/mythtv/commit/a4a64bf4af07f8e045c1941e13cd6a27e346fae3
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-13 (Sat, 13 Jul 2019)

  Changed paths:
    M mythtv/programs/mythbackend/main_helpers.cpp

  Log Message:
  -----------
  Clear EIT channel locks on master startup

EIT channels can be left locked when mythbackend is
terminated with a SIGKILL.
This means that there will be no new EIT information
for these channels when mythbackend is started again.
The only way to get the channels unlocked at short
notice is to execute the appropriate sql commands manually.
The function to clear the channel locks was already
implemented, but it was never called.
It is now called on startup of the master backend.


  Commit: 1347bfaff6fa29232ab55e63eaecf9d2c2e306d4
      https://github.com/MythTV/mythtv/commit/1347bfaff6fa29232ab55e63eaecf9d2c2e306d4
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-13 (Sat, 13 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp

  Log Message:
  -----------
  Use isEmpty for empty QString

Trivial change: replace comparison with an empty string
with isEmpty() to catch the case when the QString pointer
might be null instead of pointing to an empty string.


  Commit: c4a1d5314b72116885f168bf28ebebaff775e825
      https://github.com/MythTV/mythtv/commit/c4a1d5314b72116885f168bf28ebebaff775e825
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-13 (Sat, 13 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h

  Log Message:
  -----------
  Multirec with DVB CAM on encrypted channels

Creating recordings of more than one channel of the same multiplex
with only one tuner, called multirec, has been implemented already
a long time ago. This works OK for non-encrypted (FTA) channels.

However, multirec has never worked reliably for encrypted channels
received with a card that has a CAM and a smartcard for decryption.
This is not a limitation of the CAM or the smartcard; recordings
that are started at different times are always good, but when
recordings start exactly the same moment sometimes one of them fails.
This happens when the backend is running and multiple recordings
are scheduled to start at the same time, or when the backend is
started when multiple recordings should have been running.

This is cause by the following.
- Each recording uses a StreamHandler
- The StreamHandler uses a DeviceRingBuffer when buffering is needed
- There is only one StreamHandler per physical tuner; additional
  recordings of that tuner share the same StreamHandler
- Starting a recording in MythTV is a two-stage process; first
  the StreamHandler is started without buffering; when
  that succeeds the StreamHandler is started again with buffering
- When two recordings start at the same time, and StreamHandler
  is shared, it can happen that a StreamHandler is shared
  when it does not do buffering but that buffering is required.
- In that case the StreamHandler is restarted. There is a log
  message "Restarting StreamHandler" when this happens.
- When the StreamHandler is restarted there is a short time
  when the StreamHandler is not running. This is typically
  5 to 10 milliseconds, as measured on my system.
- In the DVBSignalMonitor::UpdateValues() the function
  StreamHandler::IsRunning() is called to check if the
  StreamHandler is still running.
- If this happens exactly in the interval when the
  StreamHandler is restarted then the DVBSignalMonitor
  decides that the StreamHandler is NOT running and
  the error state m_error is set to "Error: stream handler died".
- TVRec::TuningSignalCheck checks SignalMonitor::IsErrored()
  and when that is true the recording fails.

The solution for this is to consider the StreamHandler
to be running while it is being restarted.

A possible reason why this problem happens on encrypted channels
and not on non-encrypted channels is that the tuning the first
channel takes much longer than tuning the second channel.
The second channel needs the buffering while the StreamHandler
is still in the non-buffering state needed by the first channel.

Note that there is still the possibility that this bug might also
have incidentally caused failed recordings on non-encrypted channels
because the "Restarting StreamHandler" messages have incidentally
been observed on non-encrypted channels.


  Commit: e35e97e1a08d79e4bd99072c45daef035e1fd873
      https://github.com/MythTV/mythtv/commit/e35e97e1a08d79e4bd99072c45daef035e1fd873
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-14 (Sun, 14 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelutil.cpp

  Log Message:
  -----------
  Channel list in Program Guide

The Program Guide displayed by mythfrontend now shows only the
channels from videosources that are connected to a capturecard.
Previously, the Program Guide showed all channels in the database,
including channels that could never have been recorded because
they are from videosources not connected to a capturecard.


  Commit: a3771fcdb6e1e28c2a2a5491b60069ba3648dc10
      https://github.com/MythTV/mythtv/commit/a3771fcdb6e1e28c2a2a5491b60069ba3648dc10
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  Channel list sorted on frequency in mythtv-setup output

The list of channels written to standard output by mythtv-setup
after a succesful scan is now sorted in order of increasing freqency.
This makes it easier to compare with channel lists from previous scans
and, for satellites, it also makes it easier to compare the output of
mythtv-setup with the channel information on lyngsat.com and kingofsat.net.


  Commit: 428a1918a706e74a1760e1653b899845de2e15b9
      https://github.com/MythTV/mythtv/commit/428a1918a706e74a1760e1653b899845de2e15b9
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h

  Log Message:
  -----------
  Help text of option "Complete scan data required" changed


  Commit: 8648d8326bdaafea14d67f9f33c55593c4ebfe37
      https://github.com/MythTV/mythtv/commit/8648d8326bdaafea14d67f9f33c55593c4ebfe37
  Author: Bill Meek <billmeek at mythtv.org>
  Date:   2019-07-19 (Fri, 19 Jul 2019)

  Changed paths:
    M mythtv/html/tv/guide.qsp
    M mythtv/html/tv/programsearch.qsp

  Log Message:
  -----------
  WebFrontend: Restore TV/Program Guide and TV/Program Search

afa06ff added the WithVisible parameter to the Guide/GetProgramGuide
and Guide/GetProgramList endpoints that needed to be added to the
html/tv/guide.qsp html/tv/programsearch.qsp files.


  Commit: 7821422d7438908650e47002887b5dc71f2951c5
      https://github.com/MythTV/mythtv/commit/7821422d7438908650e47002887b5dc71f2951c5
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-21 (Sun, 21 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  Function value of ShowManualChannelPopup

The ShowManualChannelPopup dialog of mythtv-setup
has the choices OK, Edit, Cancel and Cancel All.
This dialog is used when there is a conflict in updating
channels after a channel scan.
With this fix the dialog returns kOctCancel for the Cancel
button and kOctCancelAll for the Cancel All button.
Previously, kOctCancelAll was returned for both the Cancel
and the Cancel All button.


  Commit: 62d85000e7444ed5bec773e3c6f046b1d1efb778
      https://github.com/MythTV/mythtv/commit/62d85000e7444ed5bec773e3c6f046b1d1efb778
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  Channel info in Insert and Update log messages

In mythtv-setup, the log messages "Skipping Insert", "Insert",
"Update" and ""Skipping Update" now all have the complete
channel information instead of only the channel number.


  Commit: 75d87e40a3ecf38e8282be1e9b12142bd580f832
      https://github.com/MythTV/mythtv/commit/75d87e40a3ecf38e8282be1e9b12142bd580f832
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  Improved dialog text for new channels

In mythtv-setup, when new channels are found there is a popup message.
This message is now "Found %n new %1 channel(s).".
Previously there was also "non-conflicting" mentioned.
This was not very clear as at this stage in the scanning process
the only thing that is checked is that the service id's of the
new channels are unique within the video source; the channel
numbers are not yet known.
In mythtv-setup, the terms "conflicting" and "non-conflicting"
generally refer to channel numbers.


  Commit: 592d495bf9e56b3269020ed4e7680720a88f40b4
      https://github.com/MythTV/mythtv/commit/592d495bf9e56b3269020ed4e7680720a88f40b4
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  Channel insert conflict message text improved

The message in the popup box that is shown by QueryUserResolve
and that appears when there is a channel number conflict now
clearly states that the new channel has a channel number that
is already in use.


  Commit: 3cb5c2aca03a728e81407dc7a52432e6f0c9a7e8
      https://github.com/MythTV/mythtv/commit/3cb5c2aca03a728e81407dc7a52432e6f0c9a7e8
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelutil.cpp

  Log Message:
  -----------
  Use existing setting of useonairguide on channel update

In mythtv-setup, the values of xmltvid, useonairguide and
visible are copied from the existing channel to the
new channel on a channel update.
The logic for this existed already but useonairguide was
previously only copied to the new channel if there was a
value for xmltvid defined.


  Commit: ff6bd41e0c01c212daae6dd9124832606289057f
      https://github.com/MythTV/mythtv/commit/ff6bd41e0c01c212daae6dd9124832606289057f
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M mythtv/libs/libmyth/audio/audiooutputaudiotrack.cpp

  Log Message:
  -----------
  Android audiotrack: Fix crash when watching Live TV

When trying to start Live TV with audiotrack selected as the
audio device, frontend was crashing with a seg fault due to
a pause when the audio device was not yet opened.


  Commit: 29afe012e7a01768c73e76a7e875d4f1cac9f03a
      https://github.com/MythTV/mythtv/commit/29afe012e7a01768c73e76a7e875d4f1cac9f03a
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h

  Log Message:
  -----------
  Mythtv-setup option "Complete scan data required" now default

The mythtv-setup Channel Scan option "Complete scan data required",
if selected, insures that only services that are present in the PAT,
the PMT and the SDT and that have a name will be added during the scan.
This option is now selected by default.


  Commit: 06a1158ead9aafd6c394e90860049b53e1e16978
      https://github.com/MythTV/mythtv/commit/06a1158ead9aafd6c394e90860049b53e1e16978
  Author: Paul B. Henson <henson at acm.org>
  Date:   2019-07-25 (Thu, 25 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp

  Log Message:
  -----------
  DVB symbol errros with gcc 8.3

Include of dvbchannel.h in channelscanner.cpp is now
conditional on USING_DVB.
This does solve the compilation issue for gcc 8.3.
Note that there are no compilation issues with
newer gcc versions, as tested with gcc 9.1.

Signed-off-by: Klaas de Waal <kdewaal at mythtv.org>


  Commit: 85314f4e900fe27b72bf2845c6d0a2d8a591125e
      https://github.com/MythTV/mythtv/commit/85314f4e900fe27b72bf2845c6d0a2d8a591125e
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/channelutil.h

  Log Message:
  -----------
  Channel Scan improvements

Add the following features:
1. Add "OK All" button for automatic assignment of non-conflicting channel numbers.
2. Keep existing channel numbers with a rescan.
3. Allow duplicate service ID's in a single video source.
For a complete description please see ticket 13472.

Refs #13472


  Commit: a229c27a9d2f91ae612668404be4a3373c0ca032
      https://github.com/MythTV/mythtv/commit/a229c27a9d2f91ae612668404be4a3373c0ca032
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M mythtv/libs/libmythtv/diseqc.cpp

  Log Message:
  -----------
  Trivial: fixed typo in log message.


  Commit: 590c4122401c6eeda5f2abbcb1203d79b5a43134
      https://github.com/MythTV/mythtv/commit/590c4122401c6eeda5f2abbcb1203d79b5a43134
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-02 (Fri, 02 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  Sorted channel lists

The terminal output of mythtv-setup has channel lists that
are now all sorted in order of increasing frequency.
In addition to the complete list of channels there are now
also separate lists of:
- off-air channels
- updated old channels
- skipped old channels
- inserted new channels
- skipped new channels
The lists with updated and inserted channels
also have the channel number.
There are no intentional functional changes.

Refs #13472


  Commit: 16840147a2960f264cb18913a6d24dba4dc05899
      https://github.com/MythTV/mythtv/commit/16840147a2960f264cb18913a6d24dba4dc05899
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-02 (Fri, 02 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.cpp

  Log Message:
  -----------
  Fix error handling for non-existing video device

In mythtv-setup, it is possible to enter a non-existing device
name after choosing "New Entry" in the capture card dialogs.
In this case, the error number was erronously passed back
as a file descriptor instead of an error status.


  Commit: 3a918bd11d9ccd55e6dc699bd503e1b8fdad0833
      https://github.com/MythTV/mythtv/commit/3a918bd11d9ccd55e6dc699bd503e1b8fdad0833
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-04 (Sun, 04 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/diseqc.cpp

  Log Message:
  -----------
  "No device tree" messages only for DVB-S/S2 cards

The warning messages "DiSEqCDevTree: No device tree for cardid"
can now only given for DVB devices that are configured to use
the DVB-S or DVB-S2 satellite delivery systems.
Previously this message was given for all DVB devices including
the DVB-C/T/T2 devices that never have a DiSEqC configuration.


  Commit: da558ca5f531b8074155946b96c82ef4fe0ddefa
      https://github.com/MythTV/mythtv/commit/da558ca5f531b8074155946b96c82ef4fe0ddefa
  Author: Peter Bennett <pbennett at mythtv.org>
  Date:   2019-08-08 (Thu, 08 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/dbcheck.cpp

  Log Message:
  -----------
  dbcheck: Enforce correct recgroupids for special recording groups

If the mysql server is set up with auto_increment_increment=2 or
some value other than 1, the wrong values were set for the special
recording groups.

This only fixes it for new database setups or upgrades from schema
id 1320.

Refs #13473


  Commit: 3b58ac6e106368b57eb66bcbc2e24bf45acaa46a
      https://github.com/MythTV/mythtv/commit/3b58ac6e106368b57eb66bcbc2e24bf45acaa46a
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    A mythtv/make.log

  Log Message:
  -----------
  Suggest existing channel number if non-conflicting

In ComputedSuggestedChannelNumber, now first test if the
already present channel number is non-conflicting.
This is useful when "Insert Manually" is selected  after a channels scan
and when there are already channel numbers present, such as the Logical
Channel Numbers that are present in some DVB networks.


  Commit: d8956b9397db8e36d82118b72958bf7e9f27eb62
      https://github.com/MythTV/mythtv/commit/d8956b9397db8e36d82118b72958bf7e9f27eb62
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  Remove unused parameters.

Fixes compiler diagnostic about unused parameter in functions
ChannelImporter::QueryUserResolve and ChannelImporter::QueryUserInsert.


  Commit: 5636b629ad96a7d712b635b29382786807b1c2d4
      https://github.com/MythTV/mythtv/commit/5636b629ad96a7d712b635b29382786807b1c2d4
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-12 (Mon, 12 Aug 2019)

  Changed paths:
    R mythtv/make.log

  Log Message:
  -----------
  Remove accidentally committed log file.


  Commit: 4636d7e4146a70195b33ba9a565f01e9ed43a521
      https://github.com/MythTV/mythtv/commit/4636d7e4146a70195b33ba9a565f01e9ed43a521
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M mythtv/programs/mythtv-setup/channeleditor.cpp

  Log Message:
  -----------
  Check video source and capture card

In mythtv-setup page Channel Editor, check that a video source is
selected and that the selected video source is connected to a
capture card before starting the Channel Scan dialog after
pressing the Channel Scan button.
Give a popup message when the checks fail.


  Commit: 7c91ad743541c0f432bbe04a75ffb1ac22f6ce2f
      https://github.com/MythTV/mythtv/commit/7c91ad743541c0f432bbe04a75ffb1ac22f6ce2f
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelinfo.cpp

  Log Message:
  -----------
  Trivial: DBError messages improved

In channelinfo.cpp the MythDB::DBError messages now all
have the correct function name in the message text.


  Commit: e5e8548a3c21602a479548fa17635d7eb699b7f9
      https://github.com/MythTV/mythtv/commit/e5e8548a3c21602a479548fa17635d7eb699b7f9
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-16 (Fri, 16 Aug 2019)

  Changed paths:
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp

  Log Message:
  -----------
  Fix typo in commercial flagging SLOT function name

Function sceneChangeDetectorHasNewInformation had accidentally
received a m_ prefix in one place. The m_ prefix is used for
class members such as int's but not for functions.


  Commit: adc2c4f0416d770fd4e1b22bc07719671ddc9cfd
      https://github.com/MythTV/mythtv/commit/adc2c4f0416d770fd4e1b22bc07719671ddc9cfd
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/diseqc.cpp

  Log Message:
  -----------
  Fix segfault in capture card editor

There can be a segmentation fault in the capture card editor
of mythtv-setup when configuring DVB-S satellite cards.
This happens when a capture card is changed from DVB-S,with
a configured input type of LNB (anything but not Unconnected),
to another type of DVB card.
After the capture card has been changed to a non-DVB-S type and
the DiSEqC tree has been deleted, a "Save then Exit" refers
to the already deleted DiSEqC tree. This creates a segmentation fault.
There are many more things to fix in the DiSEqC configuration
code and once this is done the "delete m_root" can be enabled again.
For now it is better to have a memory leak than a segmentation fault.

Refs #13465


  Commit: c6c5f607902eec53f7c78260dc0c6aa4a93e89fb
      https://github.com/MythTV/mythtv/commit/c6c5f607902eec53f7c78260dc0c6aa4a93e89fb
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.h

  Log Message:
  -----------
  Initialize number of channels found to 0 instead of 999.


  Commit: 796c4c5827d8484d47f32c91e423ae22651678ab
      https://github.com/MythTV/mythtv/commit/796c4c5827d8484d47f32c91e423ae22651678ab
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-17 (Sat, 17 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp

  Log Message:
  -----------
  No more channel conflicts on ATSC major/minor numbers.

This change is similar to that for channel conflicts on service ID's for DVB.

Rationale (also the same):
A "conflicting channel" in mythtv-setup is a channel that does not have a unique channel number.
It is essential to have a unique channel number for all channels in a video source otherwise
mythbackend can arbitrarily select any channel with the same channel number for a recording.
However, mythtv-setup also considers a channel conflicting if the ATSC major/minor number
combination is the same as another channel and then forces the user to enter a unique channel number.

In my understanding this is a bug because A. it does not change the ATSC major/minor numbers
and B. ATSC major/minor number combinations do not need to be unique in MythTV.
For ATSC the test on the major/minor number combination uniqueness is removed and all ATSC channels
are now considered "non-conflicting" to start with.
The ATSC major/minor number combination is used to create default channel numbers
but later on the check on the uniqueness of the channel number is still done.

Refs #13472


  Commit: 1c8a75d3d1718ac934037b940ba1958675d66dc4
      https://github.com/MythTV/mythtv/commit/1c8a75d3d1718ac934037b940ba1958675d66dc4
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelinfo.h
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.h
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.h
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/scanwizard.h
    M mythtv/programs/mythtv-setup/main.cpp

  Log Message:
  -----------
  Full search for old channels

In mythtv-setup page Channel Scan there is now a new
option "Full search for old channels".

If set, compare all channels in the database with the channels found in
the scan; otherwise only the channels in the same transport are compared.
This option is useful when you want to keep channel data such as
the xmltvid and the icon path when doing a rescan
after channels have been rearranged across transports.

For ATSC the comparison is done only on the major and minor numbers.
For DVB the comparison of channels in the same transport is done
on service id but the comparison of channels in different transports
is done on network id and service id.

Without this option, when channels have moved to another transport
the old channels are classified as "off-air" and can only be deleted.
The moved channels are classified as "New" and they then do not have
the non-scanned data anymore such as the xmltvid and the icon path
that may have been added to the old channel.

The option is currently unchecked by default. If this option proves to
be a succes then this can be changed to checked by default.

Refs #13472


  Commit: 58350d95f8b25205f187b6fd05ad64c19cfe2548
      https://github.com/MythTV/mythtv/commit/58350d95f8b25205f187b6fd05ad64c19cfe2548
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp

  Log Message:
  -----------
  Initialisation of dtv_property and dtv_properties variables

All variables of type struct dtv_property and struct dtv_properties
are now initialized with the C++ zero initializer {}.
This does solve a valgrind "Uninitialised value" message for
a struct dtv_properties in cardutil.cpp.


  Commit: 477ddfdaf5ba4110a82d6367033b40726932a1db
      https://github.com/MythTV/mythtv/commit/477ddfdaf5ba4110a82d6367033b40726932a1db
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M mythtv/libs/libmythtv/diseqc.cpp

  Log Message:
  -----------
  Initialisation to fix valgrind message.


  Commit: d63aa66667a7df9c709a42cf596bc15c2e28aabe
      https://github.com/MythTV/mythtv/commit/d63aa66667a7df9c709a42cf596bc15c2e28aabe
  Author: Paul Harrison <pharrison at mythtv.org>
  Date:   2019-08-31 (Sat, 31 Aug 2019)

  Changed paths:
    M mythtv/README

  Log Message:
  -----------
  README: update the min Qt version to match configure


  Commit: 6ab6329ce1d512f6cca3403a6d30cda2d0aeb731
      https://github.com/MythTV/mythtv/commit/6ab6329ce1d512f6cca3403a6d30cda2d0aeb731
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h

  Log Message:
  -----------
  Number of transports in mythtv-setup log output

The number of transports in the summary of the log output
is now always the number of transports found in the scan.
In the processing of the scan results, at some point all
transports of channels in the database that are not found in the scan,
called the off-air channels, are added to the list of transports.
This caused an incorrect number of transports to be presented.
This is now fixed.
Also added a summary of the scan parameters in the log output.
Also added, when option -v chanscan is given, a separate
listing of all transports found, in order of ascending frequency.

Refs #13472


  Commit: 2dcfeb4952ef1e77a62d67034d92fe0e3e6b9477
      https://github.com/MythTV/mythtv/commit/2dcfeb4952ef1e77a62d67034d92fe0e3e6b9477
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythtv/programdata.cpp

  Log Message:
  -----------
  Update recording starttime for single recordings

When a program guide update from the EIT changes the
starttime of a program and if that program is sceduled
to be recorded as a single reording then update
the starttime of hte scheduled recording.

If the starttime of a scheduled single recording is
not correct then the program is shown as "Not Listed"
in the Scheduled Recording page because the starttime
is used to identify the program to be recorded.

Fixes #13481


  Commit: de64859ddd1799d3c82cef94c845965465963cea
      https://github.com/MythTV/mythtv/commit/de64859ddd1799d3c82cef94c845965465963cea
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythservicecontracts/enums/recStatus.h

  Log Message:
  -----------
  Replace the Q_ENUMS macro with the Q_ENUM macro.

The former was deprecated in the release of Qt 5.5.


  Commit: a287f95152a61c39ae38db2e688d7ce3dd1232a5
      https://github.com/MythTV/mythtv/commit/a287f95152a61c39ae38db2e688d7ce3dd1232a5
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythtv/subtitlescreen.cpp
    M mythtv/libs/libmythui/mythuiguidegrid.cpp

  Log Message:
  -----------
  Trivial changes to replace several obsoleted functions.

Looking at the Qt sources, the old version of each of these functions
directly calls the new version of the function.

  QColor::dark -> QColor::darker
    - new function added in Qt4.3

  QFileInfo::readLink -> QFileInfo::symLinkTarget
    - new function added in Qt4.2

  QFontMetrics::width -> QFontMetrics::horizontalAdvance
    - new function added in Qt5.11


  Commit: 474a107cfb6982a2f544722fa1855c148bef58c7
      https://github.com/MythTV/mythtv/commit/474a107cfb6982a2f544722fa1855c148bef58c7
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mpeg/tspacket.h

  Log Message:
  -----------
  Quiet several array bounds warning messages.

These are valid accesses, but since the array was defined with size 4
instead of size 0 (a variable length array) the compiler throws
warning messages.  Interestingly I only see these on Arch (gcc 9.1.0)
and not on Fedora 30 (gcc 9.1.1).


  Commit: dc87fada554f8b200bf8b67ce51174936b429a04
      https://github.com/MythTV/mythtv/commit/dc87fada554f8b200bf8b67ce51174936b429a04
  Author: David Hampton <mythtv at love2code.net>
  Date:   2019-09-06 (Fri, 06 Sep 2019)

  Changed paths:
    M mythtv/bindings/php/MythBackend.php

  Log Message:
  -----------
  Fix php7.2 count warnings in MythBackend bindings.

The mythweb portion of this bug was fixed in a separate commit.

Adapted from a fix by daraden.

Fixes #13406.


  Commit: 7ea2d6c414b10067a9965ee1c245ba4207261b51
      https://github.com/MythTV/mythtv/commit/7ea2d6c414b10067a9965ee1c245ba4207261b51
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2019-09-10 (Tue, 10 Sep 2019)

  Changed paths:
    M mythtv/programs/scripts/hardwareprofile/smolt.py

  Log Message:
  -----------
  Handle kernel 5.x


  Commit: 479abcc77d11331a2c5732a55d3201241212367f
      https://github.com/MythTV/mythtv/commit/479abcc77d11331a2c5732a55d3201241212367f
  Author: Stuart Auchterlonie <stuarta at mythtv.org>
  Date:   2019-09-12 (Thu, 12 Sep 2019)

  Changed paths:
    M mythtv/programs/scripts/hardwareprofile/software.py

  Log Message:
  -----------
  Set default runlevel to 9, as systemd targets report as unknown. This blows the current smolt backend up


  Commit: 1ad17d49ea6bdfb16c3cd5e4882227a32f06ef2a
      https://github.com/MythTV/mythtv/commit/1ad17d49ea6bdfb16c3cd5e4882227a32f06ef2a
  Author: Klaas de Waal <kdewaal at mythtv.org>
  Date:   2019-09-12 (Thu, 12 Sep 2019)

  Changed paths:
    M mythtv/libs/libmythtv/eitcache.cpp

  Log Message:
  -----------
  EITCache check on table version

The EITcache code that checks if an EIT event contains new data or
that it contains data that has been already processed did now allow
for missing table versions when the table version wrapped around
from 31 to 0.
If that happens then the guide data of that channel will not
be updated for a few days until the table version is 31 again.
Note that it is completely valid for a receiver to not receive
all table versions. This happens for instance when a tuner is
used for recording; during that time the active EIT scanning
is suspended and only the EIT data on the multiplex of the
channel that is currently being reorded is processed.
This happens also when a device is switched off.
The check as now implemented only checks if the new table version
is different from the previously processed table version.
Also changed the layout of the statistics log message so
that it is more likely to fit on one line.


  Commit: 074e325b837a7dd155fc233a053e6fedd0bfcb6d
      https://github.com/MythTV/mythtv/commit/074e325b837a7dd155fc233a053e6fedd0bfcb6d
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-09-17 (Tue, 17 Sep 2019)

  Changed paths:
    M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
    M mythtv/README
    M mythtv/bindings/php/MythBackend.php
    M mythtv/configure
    M mythtv/html/tv/guide.qsp
    M mythtv/html/tv/programsearch.qsp
    M mythtv/libs/libmyth/audio/audiooutputaudiotrack.cpp
    M mythtv/libs/libmythbase/mythmiscutil.cpp
    M mythtv/libs/libmythservicecontracts/enums/recStatus.h
    M mythtv/libs/libmythservicecontracts/services/guideServices.h
    M mythtv/libs/libmythtv/cardutil.cpp
    M mythtv/libs/libmythtv/channelinfo.cpp
    M mythtv/libs/libmythtv/channelinfo.h
    M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
    M mythtv/libs/libmythtv/channelscan/channelimporter.h
    M mythtv/libs/libmythtv/channelscan/channelscan_sm.h
    M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h
    M mythtv/libs/libmythtv/channelscan/channelscanner.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner.h
    M mythtv/libs/libmythtv/channelscan/channelscanner_cli.cpp
    M mythtv/libs/libmythtv/channelscan/channelscanner_gui.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
    M mythtv/libs/libmythtv/channelscan/scanwizardconfig.h
    M mythtv/libs/libmythtv/channelutil.cpp
    M mythtv/libs/libmythtv/channelutil.h
    M mythtv/libs/libmythtv/dbcheck.cpp
    M mythtv/libs/libmythtv/diseqc.cpp
    M mythtv/libs/libmythtv/eitcache.cpp
    M mythtv/libs/libmythtv/mheg/dsmccobjcarousel.cpp
    M mythtv/libs/libmythtv/mpeg/tspacket.h
    M mythtv/libs/libmythtv/programdata.cpp
    M mythtv/libs/libmythtv/recorders/dtvsignalmonitor.cpp
    M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.cpp
    M mythtv/libs/libmythtv/recorders/streamhandler.h
    M mythtv/libs/libmythtv/scanwizard.cpp
    M mythtv/libs/libmythtv/scanwizard.h
    M mythtv/libs/libmythtv/subtitlescreen.cpp
    M mythtv/libs/libmythtv/tv_rec.cpp
    M mythtv/libs/libmythui/mythuiguidegrid.cpp
    M mythtv/programs/mythbackend/main_helpers.cpp
    M mythtv/programs/mythbackend/services/guide.cpp
    M mythtv/programs/mythbackend/services/guide.h
    M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
    M mythtv/programs/mythfrontend/playbackbox.cpp
    M mythtv/programs/mythfrontend/playbackbox.h
    M mythtv/programs/mythfrontend/scheduleeditor.cpp
    M mythtv/programs/mythfrontend/scheduleeditor.h
    M mythtv/programs/mythtv-setup/channeleditor.cpp
    M mythtv/programs/mythtv-setup/main.cpp
    M mythtv/programs/scripts/hardwareprofile/smolt.py
    M mythtv/programs/scripts/hardwareprofile/software.py

  Log Message:
  -----------
  Merge branch 'master' into devel/2019-render


Compare: https://github.com/MythTV/mythtv/compare/abdab7fdc000...074e325b837a



More information about the mythtv-commits mailing list