[mythtv-commits] [MythTV/mythtv] 36d96c: Fix TestIPTVRecorder after change to IPTVChannelInfo

[Ian Campbell]

  Branch: refs/heads/master
  Home:   https://github.com/MythTV/mythtv
  Commit: 36d96c956969a85feb8578f0cbe2cc42fee01016
      https://github.com/MythTV/mythtv/commit/36d96c956969a85feb8578f0cbe2cc42fee01016
  Author: Ian Campbell <ijc at hellion.org.uk>
  Date:   2019-10-06 (Sun, 06 Oct 2019)

  Changed paths:
    M mythtv/libs/libmythtv/channelscan/iptvchannelfetcher.h
    M mythtv/libs/libmythtv/iptvtuningdata.h
    M mythtv/libs/libmythtv/test/test_iptvrecorder/test_iptvrecorder.h

  Log Message:
  -----------
  Fix TestIPTVRecorder after change to IPTVChannelInfo

In a60e7429a09a ("IPTVChannelInfo: explictly set IPTVTuningData protocol to
invalid") I removed `IPTVChannelInfo::IsValid()` thinking it was unused but
missed the uses in these test cases. Reintroduce the method, but make it
`protected` and a friend of the `TestIPTVRecorder` class.

The above change also changed the behaviour of `IPTVChannelInfo`'s constructors
such that the protocol is not always probed, and therefore `IsValid()` is not
necessarily true. This is the case when constructed via
`IPTVChannelFetcher::ParsePlayList`. Update `TestIPTVRecorder::ParseChanInfo` to
reflect this by now asserting that the tuning data is not valid and that the
protocol is `inValid` as expected.

Refs #13488

Signed-off-by: Paul Harrison <pharrison at mythtv.org>