[mythtv-commits] [MythTV/mythtv] 3b91b0: tidy: Fix some class member naming. (plugins)
linuxdude42
noreply at github.com
Sat Nov 23 21:46:07 UTC 2019
Branch: refs/heads/master
Home: https://github.com/MythTV/mythtv
Commit: 3b91b0aed50b7a96c261d23b13aeafea791b87e1
https://github.com/MythTV/mythtv/commit/3b91b0aed50b7a96c261d23b13aeafea791b87e1
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythplugins/mytharchive/mytharchivehelper/external/pxsup2dast.c
M mythplugins/mythgame/mythgame/gamesettings.cpp
M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
M mythplugins/mythmusic/mythmusic/bumpscope.cpp
M mythplugins/mythmusic/mythmusic/cddb.cpp
M mythplugins/mythmusic/mythmusic/cddecoder.cpp
M mythplugins/mythmusic/mythmusic/mythgoom.cpp
M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
M mythplugins/mythmusic/mythmusic/synaesthesia.cpp
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythnews/mythnews/mythnewsconfig.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
Log Message:
-----------
tidy: Fix some class member naming. (plugins)
The clang-tidy "identifier naming" checker pointed out a number of
places where class member variables don't use the convention of
starting with "m_", or static variables don't begin with "s_". Fix
these for naming consistency across the code base. There are also a
handful of member variables names that were converted from the
"m_lower_case" form to the "m_camelBack" form.
https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html
Commit: 5856229b593873f74216f347169e4cd934851cf3
https://github.com/MythTV/mythtv/commit/5856229b593873f74216f347169e4cd934851cf3
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/filters/adjust/filter_adjust.c
M mythtv/filters/bobdeint/filter_bobdeint.c
M mythtv/filters/crop/filter_crop.c
M mythtv/filters/denoise3d/filter_denoise3d.c
M mythtv/filters/fieldorder/filter_fieldorder.c
M mythtv/filters/greedyhdeint/filter_greedyhdeint.c
M mythtv/filters/invert/filter_invert.c
M mythtv/filters/ivtc/filter_ivtc.c
M mythtv/filters/kerneldeint/filter_kerneldeint.c
M mythtv/filters/linearblend/filter_linearblend.c
M mythtv/filters/onefield/filter_onefield.c
M mythtv/filters/postprocess/filter_postprocess.c
M mythtv/filters/quickdnr/filter_quickdnr.c
M mythtv/filters/vflip/filter_vflip.c
M mythtv/filters/yadif/filter_yadif.c
Log Message:
-----------
tidy: Fix some class member naming. (filters)
The clang-tidy "identifier naming" checker pointed out a number of
places where class member variables don't use the convention of
starting with "m_", or static variables don't begin with "s_". Fix
these for naming consistency across the code base. There are also a
handful of member variables names that were converted from the
"m_lower_case" form to the "m_camelBack" form.
https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html
Commit: 636d2605c4fb766db35a8870e5507beaf7b90045
https://github.com/MythTV/mythtv/commit/636d2605c4fb766db35a8870e5507beaf7b90045
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutput.cpp
M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
M mythtv/libs/libmyth/audio/audiopulsehandler.cpp
M mythtv/libs/libmyth/audio/pink.c
M mythtv/libs/libmyth/audio/spdifencoder.cpp
M mythtv/libs/libmyth/mythcontext.cpp
M mythtv/libs/libmyth/omxcontext.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/rssparse.cpp
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/mthreadpool.cpp
M mythtv/libs/libmythbase/mythcdrom-linux.cpp
M mythtv/libs/libmythbase/mythcdrom.cpp
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythcoreutil.cpp
M mythtv/libs/libmythbase/mythdb.cpp
M mythtv/libs/libmythbase/mythdbcon.cpp
M mythtv/libs/libmythbase/mythdownloadmanager.cpp
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/mythsystemunix.cpp
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/libs/libmythbase/signalhandling.cpp
M mythtv/libs/libmythfreemheg/ParseText.cpp
M mythtv/libs/libmythfreemheg/Text.cpp
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythfreesurround/freesurround.cpp
M mythtv/libs/libmythmetadata/cleanup.cpp
M mythtv/libs/libmythmetadata/dbaccess.cpp
M mythtv/libs/libmythmetadata/dirscan.cpp
M mythtv/libs/libmythmetadata/metadatagrabber.cpp
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/videometadatalistmanager.cpp
M mythtv/libs/libmythmetadata/videoscan.cpp
M mythtv/libs/libmythmpeg2/decode.c
M mythtv/libs/libmythmpeg2/header.c
M mythtv/libs/libmythmpeg2/idct_mmx.c
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/libs/libmythupnp/msocketdevice_unix.cpp
Log Message:
-----------
tidy: Fix some class member naming. (libs)
The clang-tidy "identifier naming" checker pointed out a number of
places where class member variables don't use the convention of
starting with "m_", or static variables don't begin with "s_". Fix
these for naming consistency across the code base. There are also a
handful of member variables names that were converted from the
"m_lower_case" form to the "m_camelBack" form.
https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html
Commit: b015fa3ec93ba5437a494bb10f01a1896e59698b
https://github.com/MythTV/mythtv/commit/b015fa3ec93ba5437a494bb10f01a1896e59698b
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/programs/mythavtest/main.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
M mythtv/programs/mythcommflag/BorderDetector.cpp
M mythtv/programs/mythcommflag/ClassicLogoDetector.cpp
M mythtv/programs/mythcommflag/CommDetector2.cpp
M mythtv/programs/mythcommflag/EdgeDetector.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/TemplateFinder.cpp
M mythtv/programs/mythcommflag/TemplateMatcher.cpp
M mythtv/programs/mythexternrecorder/MythExternControl.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/main.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/services/frontend.cpp
M mythtv/programs/mythfrontend/statusbox.cpp
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/videolist.cpp
M mythtv/programs/mythfrontend/videoplayercommand.cpp
M mythtv/programs/mythtranscode/external/replex/ts.c
M mythtv/programs/mythtranscode/mpeg2fix.cpp
M mythtv/programs/mythtv-setup/backendsettings.cpp
M mythtv/programs/mythtv-setup/exitprompt.cpp
M mythtv/programs/mythtv-setup/startprompt.cpp
M mythtv/programs/mythutil/mpegutils.cpp
M mythtv/programs/mythutil/musicmetautils.cpp
Log Message:
-----------
tidy: Fix some class member naming. (programs)
The clang-tidy "identifier naming" checker pointed out a number of
places where class member variables don't use the convention of
starting with "m_", or static variables don't begin with "s_". Fix
these for naming consistency across the code base. There are also a
handful of member variables names that were converted from the
"m_lower_case" form to the "m_camelBack" form.
https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html
Commit: d041910d04bc024f5a744eea96931effed1c8a69
https://github.com/MythTV/mythtv/commit/d041910d04bc024f5a744eea96931effed1c8a69
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M .clang-tidy
M mythtv/libs/libmythbase/logging.cpp
Log Message:
-----------
Fix member variable name capitalization.
Commit: 6bc50bc34c289218c63e5f8eef1903fc7c90465b
https://github.com/MythTV/mythtv/commit/6bc50bc34c289218c63e5f8eef1903fc7c90465b
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M .clang-tidy
Log Message:
-----------
Add two new checks to clang-tidy.
Commit: 213edce060742a0583917dc1959e5833dcc00111
https://github.com/MythTV/mythtv/commit/213edce060742a0583917dc1959e5833dcc00111
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/Makefile
A mythtv/programs/scripts/build_commdb.py
Log Message:
-----------
Rework code to build the compdb for clang-tidy.
Commit: d2d642a495c4eabcf810346a77cf7bb2566eb5e2
https://github.com/MythTV/mythtv/commit/d2d642a495c4eabcf810346a77cf7bb2566eb5e2
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythplugins/mythmusic/mythmusic/cddecoder.cpp
M mythtv/libs/libmyth/mythcontext.cpp
M mythtv/libs/libmythbase/mythcdrom-linux.cpp
M mythtv/libs/libmythbase/mythdbcon.cpp
M mythtv/libs/libmythfreemheg/Actions.cpp
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythfreesurround/freesurround.cpp
M mythtv/libs/libmythtv/mythsystemevent.cpp
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/videosource.cpp
Log Message:
-----------
tidy: Mark some additional constructors as "explicit".
The clang-tidy "explicit constructor" checker pointed out a couple of
places where constructors should be marked as explicit. It also
falsely pointed out a couple of class "operator" methods that it
thought should be explicit, but marking these as explicit causes the
compilation to fail in unexpected ways, so mark them to be ignored
instead.
https://clang.llvm.org/extra/clang-tidy/checks/google-explicit-constructor.html
Commit: f72d0790d427fa8c84cbe82b5c102ae649735554
https://github.com/MythTV/mythtv/commit/f72d0790d427fa8c84cbe82b5c102ae649735554
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutput_omx.cpp
M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
M mythtv/libs/libmyth/audio/audiooutputnull.cpp
M mythtv/libs/libmyth/audio/audiooutputoss.cpp
Log Message:
-----------
tidy: Silence a couple of misleading "infinite loop" warnings.
The clang-tidy "infinite loop" checker pointed out a couple of places
that look like infinite loops, because the loop variable isn't updated
anywhere inside of the loop. All of these are written in the form:
while ( x=fn() )
{...}
What clang-tidy doesn't see is that inside the function is an iterator
that will eventually return 0 and cause the loop to exit. Tell
clang-tidy to ignore these loops in the future.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-infinite-loop.html
Commit: 1332eb822bffa5adf5fb0cef60e0bb4f7ff8ffaa
https://github.com/MythTV/mythtv/commit/1332eb822bffa5adf5fb0cef60e0bb4f7ff8ffaa
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/programs/mythfrontend/galleryslide.cpp
M mythtv/programs/mythfrontend/galleryslide.h
Log Message:
-----------
Fix calling chain in galleryslide functions.
The clang-tidy "bugprone parent virtual call" checker pointed out a
couple of places where galleryslide functions call directly up to
their grandparent function instead of their (in this case
non-existent) parent function. Add new parent functions that do
nothing more than call up, and call those instead of directly calling
the grandparent.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-parent-virtual-call.html
Commit: c3eee4e50b2c3884641b862e5cd48f45568c6bee
https://github.com/MythTV/mythtv/commit/c3eee4e50b2c3884641b862e5cd48f45568c6bee
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
M mythtv/libs/libmythui/mythuitype.cpp
Log Message:
-----------
Fix customEvent handlers to chain up to their parent.
The clang-tidy "bugprone parent virtual call" checker pointed out a
couple of places where customEvent handlers either don't call up to
their parent, or skip the parent and call up to the grandparent. Fix
these so that they all call from child to parent.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-parent-virtual-call.html
Commit: a47e34146a1effffaa34d86abe8d3f9d37ab012c
https://github.com/MythTV/mythtv/commit/a47e34146a1effffaa34d86abe8d3f9d37ab012c
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmythtv/fileringbuffer.cpp
Log Message:
-----------
tidy: Fix a couple of error checks on calls to posix_fadvise.
The clang-tidy "posix return" checker pointed out a couple of places
where the return value of a function call is incorrectly tested for an
error. The test is for a negative number, but the function returns
zero for success and a positive number on error. Change these test
check for a non-zero value instead of a negative value.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-posix-return.html
Commit: afaeef4ab4735102bb7485adb5b46146a7b24c8f
https://github.com/MythTV/mythtv/commit/afaeef4ab4735102bb7485adb5b46146a7b24c8f
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputjack.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/visualisations/goom/filters.c
M mythtv/libs/libmythtv/visualisations/goom/goom_core.c
M mythtv/libs/libmythtv/visualisations/goom/surf3d.c
M mythtv/libs/libmythui/mythuitext.cpp
Log Message:
-----------
tidy: Clean up integer division warnings.
The clang-tidy "integer division result used by floating point" test
pointed out a number of potential rounding issues. Fix most of these
by converting to a float/double before the division, whether by a an
explicit cast or by changing the integer divisor to a float divisor.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-integer-division.html
Commit: f0edeb1a7dc194983d0b01b12259597f3c57a46f
https://github.com/MythTV/mythtv/commit/f0edeb1a7dc194983d0b01b12259597f3c57a46f
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythmusic/mythmusic/lyricsview.cpp
M mythplugins/mythmusic/mythmusic/musicplayer.cpp
M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
M mythtv/libs/libmyth/audio/audiooutputpulse.cpp
M mythtv/libs/libmyth/audio/eldutils.cpp
M mythtv/libs/libmyth/remoteutil.cpp
M mythtv/libs/libmythbase/mythsystemlegacy.cpp
M mythtv/libs/libmythbase/unzip.cpp
M mythtv/libs/libmythfreemheg/Actions.cpp
M mythtv/libs/libmythfreemheg/Programs.cpp
M mythtv/libs/libmythmetadata/metadatacommon.cpp
M mythtv/libs/libmythmetadata/metadatafactory.cpp
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/parentalcontrols.cpp
M mythtv/libs/libmythservicecontracts/enums/recStatus.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cc608decoder.cpp
M mythtv/libs/libmythtv/cc708decoder.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/commbreakmap.cpp
M mythtv/libs/libmythtv/dtvconfparser.cpp
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/fileringbuffer.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mythiowrapper.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/vbitext/lang.c
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/libs/libmythui/lirc_client.c
M mythtv/libs/libmythui/mythfontproperties.cpp
M mythtv/libs/libmythui/myththemedmenu.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/libs/libmythupnp/upnpcds.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/mythsettings.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfrontend/main.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythtranscode/external/replex/element.c
M mythtv/programs/mythtranscode/mpeg2fix.cpp
M mythtv/programs/mythtv-setup/main.cpp
M mythtv/programs/mythutil/mpegutils.cpp
Log Message:
-----------
tidy: Clean up duplicated if/then/else and switch bodies.
The clang-tidy bugprone "branch clone" checker pointed out a number of
places where the bodies of an if/then/else clause were duplicated, or
where the bodies of switch clauses were duplicated. Clean up these
warnings either by collapsing the multiple instances of code into a
single instance, or by flagging clang-tidy to ignore these warnings.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: 07eab11e41c0f59282c67a4eb08a69edf4742dbe
https://github.com/MythTV/mythtv/commit/07eab11e41c0f59282c67a4eb08a69edf4742dbe
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
Log Message:
-----------
tidy: Clean up code stripping dvd or bluray device names.
The clang-tidy bugprone "branch clone" checker pointed out two places
where it appears that the bodies of an if/then/else clause were
duplicated. It appears that this code was designed to strip a device
name from the front of the string, and replace a double "//" with a
single slash. Rewrite these two clauses to simplify them.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: a07683254252d3f4a48ccf3921172c4343d107e1
https://github.com/MythTV/mythtv/commit/a07683254252d3f4a48ccf3921172c4343d107e1
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmythtv/dsmccbiop.cpp
Log Message:
-----------
tidy: Replace sparse DSMCC "switch" statement with an "if" statement.
The clang-tidy bugprone "branch clone" checker pointed out a ten item
switch statement that only processed a single value. Replace this
"switch" statement with an "if" statement to eliminate the redundant
branch warnings. Leave a comment with the value/name pairs that were
part of the original switch statement.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: 5f3491fefa37a1195d43f8ba84b5ea430c0c6e28
https://github.com/MythTV/mythtv/commit/5f3491fefa37a1195d43f8ba84b5ea430c0c6e28
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
Log Message:
-----------
tidy: Clean up duplicated conditional if/then/else and switch bodies.
The clang-tidy bugprone "branch clone" checker pointed out two places
where the bodies of an if/then/else clause appeared to be duplicated
because the code inside of the clause was only conditionally compiled.
Making the entire "else if" clause conditionally compiled (instead of
just the body) eliminates most of these warnings. The remaining
warnings are truly duplicated code, so flag them to be ignored by
clang-tidy.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: 91e5b1b47203663b3babea544369278e3e3e89ec
https://github.com/MythTV/mythtv/commit/91e5b1b47203663b3babea544369278e3e3e89ec
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
Log Message:
-----------
tidy: Fix internal format to ALSA format for 24bit audio.
The clang-tidy bugprone "branch clone" checker pointed out two places
where a case statement had duplicated clauses, and upon inspection it
appeared that one of the clauses was wrong. The code is converting
from the internal FORMAT_S24 code to the external ALSA
SND_PCM_FORMAT_S32 code. Correct this to convert to the external
SND_PCM_FORMAT_S24 code.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: 17e24143779d3f7706784c34fd9e096c11c0f8c1
https://github.com/MythTV/mythtv/commit/17e24143779d3f7706784c34fd9e096c11c0f8c1
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
Log Message:
-----------
tidy: Clean up duplicated if/then/else statement in lcdprocclient.cpp.
The clang-tidy bugprone "branch clone" checker pointed out a spot
where the bodies of an if/then/elseif statement were duplicated.
Given that the first test is for "x==1", and the second test for
"x!=0" is also true when the first test is true, the entire first
clause can be dropped without changing the functionality.
https://clang.llvm.org/extra/clang-tidy/checks/bugprone-branch-clone.html
Commit: 4c95aac2bdee87bb91fcb99ebaacd82916b66a7e
https://github.com/MythTV/mythtv/commit/4c95aac2bdee87bb91fcb99ebaacd82916b66a7e
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-22 (Fri, 22 Nov 2019)
Changed paths:
R mythplugins/cpsimple
R mythplugins/cpsvndir
M mythplugins/mytharchive/mytharchive/mytharchive.pro
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mytharchive/theme/theme.pro
M mythplugins/mythbrowser/theme/theme.pro
M mythplugins/mythgame/mythgame/dbcheck.cpp
M mythplugins/mythgame/mythgame/gamehandler.cpp
M mythplugins/mythgame/mythgame/rominfo.cpp
M mythplugins/mythgame/theme/theme.pro
M mythplugins/mythmusic/theme/theme.pro
M mythplugins/mythnetvision/theme/theme.pro
M mythplugins/mythnews/theme/theme.pro
M mythplugins/mythweather/mythweather/mythweather.pro
M mythplugins/mythweather/theme/theme.pro
M mythplugins/mythzoneminder/theme/theme.pro
M mythtv/bindings/perl/MythTV.pm
M mythtv/bindings/php/MythTV.php
M mythtv/bindings/python/MythTV/__init__.py
M mythtv/bindings/python/MythTV/_conn_mysqldb.py
M mythtv/bindings/python/MythTV/altdict.py
M mythtv/bindings/python/MythTV/connections.py
M mythtv/bindings/python/MythTV/database.py
M mythtv/bindings/python/MythTV/dataheap.py
M mythtv/bindings/python/MythTV/logging.py
M mythtv/bindings/python/MythTV/methodheap.py
M mythtv/bindings/python/MythTV/msearch.py
M mythtv/bindings/python/MythTV/mythproto.py
M mythtv/bindings/python/MythTV/static.py
M mythtv/bindings/python/MythTV/system.py
M mythtv/bindings/python/MythTV/ttvdb/tvdb_api.py
M mythtv/bindings/python/MythTV/utility/__init__.py
M mythtv/bindings/python/MythTV/utility/dt.py
M mythtv/bindings/python/MythTV/utility/enum.py
M mythtv/bindings/python/MythTV/utility/other.py
M mythtv/bindings/python/MythTV/wikiscripts/__init__.py
M mythtv/bindings/python/MythTV/wikiscripts/wikiscripts.py
M mythtv/bindings/python/scripts/mythpython
M mythtv/bindings/python/scripts/mythwikiscripts
M mythtv/bindings/python/tmdb3/scripts/populate_locale.py
M mythtv/bindings/python/tmdb3/scripts/pytmdb3.py
M mythtv/bindings/python/tmdb3/tmdb3/__init__.py
M mythtv/bindings/python/tmdb3/tmdb3/cache.py
M mythtv/bindings/python/tmdb3/tmdb3/cache_engine.py
M mythtv/bindings/python/tmdb3/tmdb3/cache_file.py
M mythtv/bindings/python/tmdb3/tmdb3/cache_null.py
M mythtv/bindings/python/tmdb3/tmdb3/locales.py
M mythtv/bindings/python/tmdb3/tmdb3/pager.py
M mythtv/bindings/python/tmdb3/tmdb3/request.py
M mythtv/bindings/python/tmdb3/tmdb3/tmdb_api.py
M mythtv/bindings/python/tmdb3/tmdb3/tmdb_auth.py
M mythtv/bindings/python/tmdb3/tmdb3/util.py
M mythtv/configure
R mythtv/html/cpsvndir
M mythtv/html/html.pro
M mythtv/html/setup/js/guidedatasources.js
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmythbase/mythversion.h
M mythtv/libs/libmythprotoserver/requesthandler/fileserverhandler.cpp
M mythtv/libs/libmythservicecontracts/datacontracts/videoSource.h
M mythtv/libs/libmythservicecontracts/services/channelServices.h
M mythtv/libs/libmythtv/cardutil.cpp
M mythtv/libs/libmythtv/cardutil.h
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.cpp
M mythtv/libs/libmythtv/channelscan/channelscan_sm.h
M mythtv/libs/libmythtv/channelscan/channelscanmiscsettings.h
M mythtv/libs/libmythtv/channelscan/panedvbc.h
M mythtv/libs/libmythtv/channelscan/panedvbs.h
M mythtv/libs/libmythtv/channelscan/panedvbs2.h
M mythtv/libs/libmythtv/channelscan/panedvbt.h
M mythtv/libs/libmythtv/channelscan/panedvbt2.h
M mythtv/libs/libmythtv/channelscan/scanwizardconfig.cpp
M mythtv/libs/libmythtv/channelscan/scanwizardconfig.h
M mythtv/libs/libmythtv/channelsettings.cpp
M mythtv/libs/libmythtv/channelsettings.h
M mythtv/libs/libmythtv/channelutil.cpp
M mythtv/libs/libmythtv/dbcheck.cpp
M mythtv/libs/libmythtv/dtvmultiplex.cpp
M mythtv/libs/libmythtv/eithelper.cpp
M mythtv/libs/libmythtv/eitscanner.cpp
M mythtv/libs/libmythtv/mhi.cpp
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/dvbdescriptors.h
M mythtv/libs/libmythtv/mpeg/dvbtables.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.cpp
M mythtv/libs/libmythtv/mpeg/mpegdescriptors.h
M mythtv/libs/libmythtv/mpeg/mpegtables.h
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dvbchannel.cpp
M mythtv/libs/libmythtv/recorders/dvbsignalmonitor.cpp
M mythtv/libs/libmythtv/recorders/v4lchannel.cpp
M mythtv/libs/libmythtv/recordingrule.h
M mythtv/libs/libmythtv/scanwizard.h
M mythtv/libs/libmythtv/sourceutil.cpp
M mythtv/libs/libmythtv/sourceutil.h
M mythtv/libs/libmythtv/transporteditor.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_play.h
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/locales/locales.pro
M mythtv/programs/mythbackend/backendhousekeeper.cpp
M mythtv/programs/mythbackend/backendhousekeeper.h
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/capture.cpp
M mythtv/programs/mythbackend/services/channel.cpp
M mythtv/programs/mythbackend/services/channel.h
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythfilldatabase/filldata.cpp
M mythtv/programs/mythfilldatabase/main.cpp
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/manualschedule.cpp
M mythtv/programs/mythfrontend/networkcontrol.cpp
M mythtv/programs/mythfrontend/progdetails.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythtv-setup/channeleditor.cpp
M mythtv/programs/mythtv-setup/checksetup.cpp
M mythtv/programs/mythtv-setup/checksetup.h
M mythtv/programs/mythtv-setup/importicons.cpp
M mythtv/programs/mythutil/eitutils.cpp
R mythtv/programs/scripts/cpsimple
R mythtv/programs/scripts/cpsvndir
M mythtv/programs/scripts/hardwareprofile/MultipartPostHandler.py
M mythtv/programs/scripts/hardwareprofile/config.py
M mythtv/programs/scripts/hardwareprofile/deleteProfile.py
M mythtv/programs/scripts/hardwareprofile/devicelist.py
M mythtv/programs/scripts/hardwareprofile/distros/all.py
M mythtv/programs/scripts/hardwareprofile/distros/distro.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/data_mythtv.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/main.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/makeopts.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/orddict.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/request.py
M mythtv/programs/scripts/hardwareprofile/distros/mythtv_data/uuiddb.py
M mythtv/programs/scripts/hardwareprofile/fs_util.py
M mythtv/programs/scripts/hardwareprofile/gate.py
M mythtv/programs/scripts/hardwareprofile/getLink.py
M mythtv/programs/scripts/hardwareprofile/hwdata.py
M mythtv/programs/scripts/hardwareprofile/i18n.py
M mythtv/programs/scripts/hardwareprofile/os_detect.py
M mythtv/programs/scripts/hardwareprofile/request.py
M mythtv/programs/scripts/hardwareprofile/scan.py
M mythtv/programs/scripts/hardwareprofile/sendProfile.py
M mythtv/programs/scripts/hardwareprofile/smolt.py
M mythtv/programs/scripts/hardwareprofile/software.py
M mythtv/programs/scripts/hardwareprofile/uuiddb.py
M mythtv/programs/scripts/metadata/Movie/tmdb3.py
M mythtv/programs/scripts/metadata/Television/ttvdb.py
M mythtv/programs/scripts/scripts.pro
R mythtv/themes/cpsimple
R mythtv/themes/cpsvndir
M mythtv/themes/themes.pro
Log Message:
-----------
Merge branch 'master' into clang-tidy cleanups branch.
Commit: 656eeed12d0c542395a5f334967b10eb2f4eeb82
https://github.com/MythTV/mythtv/commit/656eeed12d0c542395a5f334967b10eb2f4eeb82
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-23 (Sat, 23 Nov 2019)
Changed paths:
M mythtv/configure
Log Message:
-----------
Remove Qt4 hack from configure.
Commit: 5665d89b92ed076192b8f3d93572aa46e089dd42
https://github.com/MythTV/mythtv/commit/5665d89b92ed076192b8f3d93572aa46e089dd42
Author: David Hampton <mythtv at love2code.net>
Date: 2019-11-23 (Sat, 23 Nov 2019)
Changed paths:
M .clang-tidy
M mythplugins/mytharchive/mytharchivehelper/external/pxsup2dast.c
M mythplugins/mytharchive/mytharchivehelper/main.cpp
M mythplugins/mythgame/mythgame/gamesettings.cpp
M mythplugins/mythmusic/mythmusic/avfdecoder.cpp
M mythplugins/mythmusic/mythmusic/bumpscope.cpp
M mythplugins/mythmusic/mythmusic/cddb.cpp
M mythplugins/mythmusic/mythmusic/cddecoder.cpp
M mythplugins/mythmusic/mythmusic/lyricsview.cpp
M mythplugins/mythmusic/mythmusic/musicplayer.cpp
M mythplugins/mythmusic/mythmusic/mythgoom.cpp
M mythplugins/mythmusic/mythmusic/playlisteditorview.cpp
M mythplugins/mythmusic/mythmusic/smartplaylist.cpp
M mythplugins/mythmusic/mythmusic/synaesthesia.cpp
M mythplugins/mythmusic/mythmusic/visualize.cpp
M mythplugins/mythnews/mythnews/mythnewsconfig.cpp
M mythplugins/mythzoneminder/mythzmserver/zmserver.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmliveplayer.cpp
M mythplugins/mythzoneminder/mythzoneminder/zmminiplayer.cpp
M mythtv/Makefile
M mythtv/configure
M mythtv/filters/adjust/filter_adjust.c
M mythtv/filters/bobdeint/filter_bobdeint.c
M mythtv/filters/crop/filter_crop.c
M mythtv/filters/denoise3d/filter_denoise3d.c
M mythtv/filters/fieldorder/filter_fieldorder.c
M mythtv/filters/greedyhdeint/filter_greedyhdeint.c
M mythtv/filters/invert/filter_invert.c
M mythtv/filters/ivtc/filter_ivtc.c
M mythtv/filters/kerneldeint/filter_kerneldeint.c
M mythtv/filters/linearblend/filter_linearblend.c
M mythtv/filters/onefield/filter_onefield.c
M mythtv/filters/postprocess/filter_postprocess.c
M mythtv/filters/quickdnr/filter_quickdnr.c
M mythtv/filters/vflip/filter_vflip.c
M mythtv/filters/yadif/filter_yadif.c
M mythtv/libs/libmyth/audio/audiooutput.cpp
M mythtv/libs/libmyth/audio/audiooutput_omx.cpp
M mythtv/libs/libmyth/audio/audiooutputalsa.cpp
M mythtv/libs/libmyth/audio/audiooutputgraph.cpp
M mythtv/libs/libmyth/audio/audiooutputjack.cpp
M mythtv/libs/libmyth/audio/audiooutputnull.cpp
M mythtv/libs/libmyth/audio/audiooutputoss.cpp
M mythtv/libs/libmyth/audio/audiooutputpulse.cpp
M mythtv/libs/libmyth/audio/audiopulsehandler.cpp
M mythtv/libs/libmyth/audio/eldutils.cpp
M mythtv/libs/libmyth/audio/pink.c
M mythtv/libs/libmyth/audio/spdifencoder.cpp
M mythtv/libs/libmyth/mythcontext.cpp
M mythtv/libs/libmyth/omxcontext.cpp
M mythtv/libs/libmyth/programinfo.cpp
M mythtv/libs/libmyth/remoteutil.cpp
M mythtv/libs/libmyth/rssparse.cpp
M mythtv/libs/libmythbase/logging.cpp
M mythtv/libs/libmythbase/loggingserver.cpp
M mythtv/libs/libmythbase/mthreadpool.cpp
M mythtv/libs/libmythbase/mythcdrom-linux.cpp
M mythtv/libs/libmythbase/mythcdrom.cpp
M mythtv/libs/libmythbase/mythcorecontext.cpp
M mythtv/libs/libmythbase/mythcoreutil.cpp
M mythtv/libs/libmythbase/mythdb.cpp
M mythtv/libs/libmythbase/mythdbcon.cpp
M mythtv/libs/libmythbase/mythdownloadmanager.cpp
M mythtv/libs/libmythbase/mythmiscutil.cpp
M mythtv/libs/libmythbase/mythsystemlegacy.cpp
M mythtv/libs/libmythbase/mythsystemunix.cpp
M mythtv/libs/libmythbase/serverpool.cpp
M mythtv/libs/libmythbase/signalhandling.cpp
M mythtv/libs/libmythbase/unzip.cpp
M mythtv/libs/libmythfreemheg/Actions.cpp
M mythtv/libs/libmythfreemheg/ParseText.cpp
M mythtv/libs/libmythfreemheg/Programs.cpp
M mythtv/libs/libmythfreemheg/Text.cpp
M mythtv/libs/libmythfreesurround/el_processor.cpp
M mythtv/libs/libmythfreesurround/freesurround.cpp
M mythtv/libs/libmythmetadata/cleanup.cpp
M mythtv/libs/libmythmetadata/dbaccess.cpp
M mythtv/libs/libmythmetadata/dirscan.cpp
M mythtv/libs/libmythmetadata/metadatacommon.cpp
M mythtv/libs/libmythmetadata/metadatafactory.cpp
M mythtv/libs/libmythmetadata/metadatagrabber.cpp
M mythtv/libs/libmythmetadata/musicmetadata.cpp
M mythtv/libs/libmythmetadata/parentalcontrols.cpp
M mythtv/libs/libmythmetadata/videometadatalistmanager.cpp
M mythtv/libs/libmythmetadata/videoscan.cpp
M mythtv/libs/libmythmpeg2/decode.c
M mythtv/libs/libmythmpeg2/header.c
M mythtv/libs/libmythmpeg2/idct_mmx.c
M mythtv/libs/libmythservicecontracts/enums/recStatus.cpp
M mythtv/libs/libmythtv/AirPlay/mythairplayserver.cpp
M mythtv/libs/libmythtv/Bluray/bdringbuffer.cpp
M mythtv/libs/libmythtv/DVD/dvdringbuffer.cpp
M mythtv/libs/libmythtv/HLS/httplivestreambuffer.cpp
M mythtv/libs/libmythtv/avformatdecoder.cpp
M mythtv/libs/libmythtv/cc608decoder.cpp
M mythtv/libs/libmythtv/cc708decoder.cpp
M mythtv/libs/libmythtv/channelscan/channelimporter.cpp
M mythtv/libs/libmythtv/commbreakmap.cpp
M mythtv/libs/libmythtv/dsmccbiop.cpp
M mythtv/libs/libmythtv/dtvconfparser.cpp
M mythtv/libs/libmythtv/eitfixup.cpp
M mythtv/libs/libmythtv/fileringbuffer.cpp
M mythtv/libs/libmythtv/jobqueue.cpp
M mythtv/libs/libmythtv/mpeg/H264Parser.cpp
M mythtv/libs/libmythtv/mpeg/mpegtables.cpp
M mythtv/libs/libmythtv/mythiowrapper.cpp
M mythtv/libs/libmythtv/mythplayer.cpp
M mythtv/libs/libmythtv/mythsystemevent.cpp
M mythtv/libs/libmythtv/programdata.cpp
M mythtv/libs/libmythtv/recorders/NuppelVideoRecorder.cpp
M mythtv/libs/libmythtv/recorders/channelbase.cpp
M mythtv/libs/libmythtv/recorders/dtvrecorder.cpp
M mythtv/libs/libmythtv/recorders/mpegrecorder.cpp
M mythtv/libs/libmythtv/recorders/recorderbase.cpp
M mythtv/libs/libmythtv/recorders/v4l2encstreamhandler.cpp
M mythtv/libs/libmythtv/recorders/vbitext/lang.c
M mythtv/libs/libmythtv/recordingprofile.cpp
M mythtv/libs/libmythtv/tv_play.cpp
M mythtv/libs/libmythtv/tv_rec.cpp
M mythtv/libs/libmythtv/videosource.cpp
M mythtv/libs/libmythtv/visualisations/goom/filters.c
M mythtv/libs/libmythtv/visualisations/goom/goom_core.c
M mythtv/libs/libmythtv/visualisations/goom/surf3d.c
M mythtv/libs/libmythtv/xine_demux_sputext.cpp
M mythtv/libs/libmythui/lirc_client.c
M mythtv/libs/libmythui/mythfontproperties.cpp
M mythtv/libs/libmythui/myththemedmenu.cpp
M mythtv/libs/libmythui/mythuitext.cpp
M mythtv/libs/libmythui/mythuitype.cpp
M mythtv/libs/libmythui/mythuiwebbrowser.cpp
M mythtv/libs/libmythupnp/httprequest.cpp
M mythtv/libs/libmythupnp/msocketdevice.cpp
M mythtv/libs/libmythupnp/msocketdevice_unix.cpp
M mythtv/libs/libmythupnp/upnpcds.cpp
M mythtv/programs/mythavtest/main.cpp
M mythtv/programs/mythbackend/mainserver.cpp
M mythtv/programs/mythbackend/mythsettings.cpp
M mythtv/programs/mythbackend/scheduler.cpp
M mythtv/programs/mythbackend/services/dvr.cpp
M mythtv/programs/mythbackend/services/guide.cpp
M mythtv/programs/mythcommflag/BlankFrameDetector.cpp
M mythtv/programs/mythcommflag/BorderDetector.cpp
M mythtv/programs/mythcommflag/ClassicCommDetector.cpp
M mythtv/programs/mythcommflag/ClassicLogoDetector.cpp
M mythtv/programs/mythcommflag/CommDetector2.cpp
M mythtv/programs/mythcommflag/EdgeDetector.cpp
M mythtv/programs/mythcommflag/HistogramAnalyzer.cpp
M mythtv/programs/mythcommflag/TemplateFinder.cpp
M mythtv/programs/mythcommflag/TemplateMatcher.cpp
M mythtv/programs/mythexternrecorder/MythExternControl.cpp
M mythtv/programs/mythfilldatabase/xmltvparser.cpp
M mythtv/programs/mythfrontend/channelrecpriority.cpp
M mythtv/programs/mythfrontend/galleryslide.cpp
M mythtv/programs/mythfrontend/galleryslide.h
M mythtv/programs/mythfrontend/globalsettings.cpp
M mythtv/programs/mythfrontend/guidegrid.cpp
M mythtv/programs/mythfrontend/main.cpp
M mythtv/programs/mythfrontend/playbackbox.cpp
M mythtv/programs/mythfrontend/progfind.cpp
M mythtv/programs/mythfrontend/proglist.cpp
M mythtv/programs/mythfrontend/scheduleeditor.cpp
M mythtv/programs/mythfrontend/services/frontend.cpp
M mythtv/programs/mythfrontend/statusbox.cpp
M mythtv/programs/mythfrontend/upnpscanner.cpp
M mythtv/programs/mythfrontend/videodlg.cpp
M mythtv/programs/mythfrontend/videofileassoc.cpp
M mythtv/programs/mythfrontend/videolist.cpp
M mythtv/programs/mythfrontend/videoplayercommand.cpp
M mythtv/programs/mythlcdserver/lcdprocclient.cpp
M mythtv/programs/mythtranscode/external/replex/element.c
M mythtv/programs/mythtranscode/external/replex/ts.c
M mythtv/programs/mythtranscode/mpeg2fix.cpp
M mythtv/programs/mythtv-setup/backendsettings.cpp
M mythtv/programs/mythtv-setup/exitprompt.cpp
M mythtv/programs/mythtv-setup/main.cpp
M mythtv/programs/mythtv-setup/startprompt.cpp
M mythtv/programs/mythutil/mpegutils.cpp
M mythtv/programs/mythutil/musicmetautils.cpp
A mythtv/programs/scripts/build_commdb.py
Log Message:
-----------
Merge 'clang-tidy' branch back into master.
Compare: https://github.com/MythTV/mythtv/compare/dae831860b54...5665d89b92ed
More information about the mythtv-commits
mailing list