[mythtv-commits] Ticket #13506: Ansible feature patch - install nasm rather than yasm

[MythTV]

#13506: Ansible feature patch - install nasm rather than yasm
---------------------------------+---------------------------------
     Reporter:  Gary Buhrmaster  |      Owner:  Stuart Auchterlonie
         Type:  Patch - Feature  |     Status:  new
     Priority:  minor            |  Milestone:  needs_triage
    Component:  Ansible          |    Version:  Master Head
     Severity:  medium           |   Keywords:
Ticket locked:  0                |
---------------------------------+---------------------------------
 In ffmpeg commit 4f9297ac3b39098547863d28fbc8d2a906d5be49 (from June 2017,
 derived from a libav patch from Oct 2016) nasm has been preferred over
 yasm for ffmpeg.

    build: Prefer NASM assembler over YASM

    NASM is more actively maintained and permits generating dependency
 information as a sideeffect of assembling, thus cutting build times in
 half.

 And, indeed, the current mythtv configure script (derived/merged from the
 ffmpeg configure), prefers nasm, but falls back to yasm.

 Test builds with nasm (rather than yasm) only lightly tested on recent
 fedora and centos systems.

 Proposed patch follows:

 {{{
 From 63c85753bf2a68c9b64bac10749d8be69ab72506 Mon Sep 17 00:00:00 2001
 From: Gary Buhrmaster <gtb at bb0.garybuhrmaster.net>
 Date: Wed, 13 Nov 2019 17:43:17 +0000
 Subject: [PATCH] install nasm rather than yasm per ffmpeg preference

 ---
  roles/mythtv-deb/tasks/main.yml     | 2 +-
  roles/mythtv-dnf/tasks/main.yml     | 2 +-
  roles/mythtv-freebsd/tasks/main.yml | 2 +-
  roles/mythtv-pacman/tasks/main.yml  | 2 +-
  roles/mythtv-rpm/tasks/main.yml     | 2 +-
  roles/mythtv-suse/tasks/main.yml    | 2 +-
  6 files changed, 6 insertions(+), 6 deletions(-)

 diff --git a/roles/mythtv-deb/tasks/main.yml b/roles/mythtv-
 deb/tasks/main.yml
 index 534c780..1bda6cc 100644
 --- a/roles/mythtv-deb/tasks/main.yml
 +++ b/roles/mythtv-deb/tasks/main.yml
 @@ -7,7 +7,7 @@
        - g++
        - make
        - build-essential
 -      - yasm
 +      - nasm
        - automake
        - libtool
        - ccache
 diff --git a/roles/mythtv-dnf/tasks/main.yml b/roles/mythtv-
 dnf/tasks/main.yml
 index fa26145..a9a1c9d 100644
 --- a/roles/mythtv-dnf/tasks/main.yml
 +++ b/roles/mythtv-dnf/tasks/main.yml
 @@ -19,7 +19,7 @@
        - libtool
        - pkgconfig
        # packages in repo for fedora, and in epel for centos7/rhel7
 -      - yasm
 +      - nasm
        - ccache

  - name: add mythtv essential build libraries
 diff --git a/roles/mythtv-freebsd/tasks/main.yml b/roles/mythtv-
 freebsd/tasks/main.yml
 index 08e3788..ab423d3 100644
 --- a/roles/mythtv-freebsd/tasks/main.yml
 +++ b/roles/mythtv-freebsd/tasks/main.yml
 @@ -12,7 +12,7 @@
      pkgng_pkg_lst:
        - git
        - ccache
 -      - yasm
 +      - nasm
        - autoconf
        - automake
        - pkgconf
 diff --git a/roles/mythtv-pacman/tasks/main.yml b/roles/mythtv-
 pacman/tasks/main.yml
 index 6971f04..c44d032 100644
 --- a/roles/mythtv-pacman/tasks/main.yml
 +++ b/roles/mythtv-pacman/tasks/main.yml
 @@ -11,7 +11,7 @@
      pacman_pkg_lst:
        - '{{ pacman_pkg_lst }}'
        - base-devel
 -      - yasm
 +      - nasm
        - ccache

  - name: add mythtv essential build libraries
 diff --git a/roles/mythtv-rpm/tasks/main.yml b/roles/mythtv-
 rpm/tasks/main.yml
 index 99045ec..12620fb 100644
 --- a/roles/mythtv-rpm/tasks/main.yml
 +++ b/roles/mythtv-rpm/tasks/main.yml
 @@ -19,7 +19,7 @@
        - libtool
        - pkgconfig
        # packages in repo for fedora, and in epel for centos7/rhel7
 -      - yasm
 +      - nasm
        - ccache

  - name: add mythtv essential build libraries
 diff --git a/roles/mythtv-suse/tasks/main.yml b/roles/mythtv-
 suse/tasks/main.yml
 index 58df23d..2219dd4 100644
 --- a/roles/mythtv-suse/tasks/main.yml
 +++ b/roles/mythtv-suse/tasks/main.yml
 @@ -10,7 +10,7 @@
        - autoconf
        - libtool
        - pkg-config
 -      - yasm
 +      - nasm
        - ccache

  - name: add mythtv essential build libraries
 --
 2.18.1

 }}}

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13506>
MythTV <http://www.mythtv.org>
MythTV Media Center