[mythtv-commits] Ticket #12848: DVB channel scan generates negative channel numbers

[MythTV]

#12848: DVB channel scan generates negative channel numbers
---------------------------------------+-----------------------------
 Reporter:  dag@…                      |          Owner:  JYA
     Type:  Bug Report - General       |         Status:  closed
 Priority:  minor                      |      Milestone:  31.0
Component:  MythTV - Mythtv-setup      |        Version:  Master Head
 Severity:  low                        |     Resolution:  Fixed
 Keywords:  DVB channel scan negative  |  Ticket locked:  0
---------------------------------------+-----------------------------
Changes (by Klaas de Waal):

 * status:  new => closed
 * resolution:   => Fixed
 * milestone:  unknown => 31.0


Comment:

 The negative channel numbers were apparently created by the minus sign
 between the freqid and the serviceid; when the freqid was empty the result
 is a negative serviceid value.

 This is the code segment in channelscan_sm.cpp in today's master:
 {{{
        if ((info.m_si_standard == "mpeg") ||
             (info.m_si_standard == "scte") ||
             (info.m_si_standard == "opencable"))
         {
             if (info.m_freqid.isEmpty())
                 info.m_chan_num = QString("%1-%2")
                     .arg(info.m_source_id)
                     .arg(info.m_service_id);
             else
                 info.m_chan_num = QString("%1-%2")
                     .arg(info.m_freqid)
                     .arg(info.m_service_id);
         }

 }}}

 The freqid is now only used to create the chan_num when freqid is not
 empty. This is equivalent to the patch in file 07_chanid.diff. Problem
 solved, ticket closed.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/12848#comment:1>
MythTV <http://www.mythtv.org>
MythTV Media Center