[mythtv-commits] Ticket #13504: Feature patch - clean up (dead) QMAKE_COPY_DIR code

MythTV noreply at mythtv.org
Thu Nov 7 17:15:30 UTC 2019


#13504: Feature patch - clean up (dead) QMAKE_COPY_DIR code
----------------------------------+--------------------------
     Reporter:  Gary Buhrmaster   |      Owner:  (none)
         Type:  Patch - Feature   |     Status:  new
     Priority:  minor             |  Milestone:  needs_triage
    Component:  MythTV - General  |    Version:  Master Head
     Severity:  medium            |   Keywords:
Ticket locked:  0                 |
----------------------------------+--------------------------
 Proposed cleanup of code base for QMAKE_COPY_DIR (dead code ).

 As of qt5.9(ish), which includes all the current stable distro releases,
 the directive QMAKE_COPY_DIR has been (essentially) a noop if one does not
 have explicit [group] commands to utilize them (although they are still
 carried forward in various created Makefiles just in case).  So the
 attempt to call cpsvndir and cpsimple have not done what they might have
 done (or were intended to do) in the past. This is dead code.

 As background, the cpsvndir and cpsimple scripts essentially performed a
 recursive copy, and then removed any .svn directories, but .svn
 directories have not existed for, well, quite some time, in the code base.
 In addition, cpsvndir modified python file shebangs according to any
 specified python in configure.  But, as it is no longer called, it does
 not perform that work, and in any case, there is a pending python3 pull
 request that will modify the python requirements in different mechanisms.
 And for the themes and html directories there are no python files that
 currently need adjustment in any case.  All dead code now.

 Patches attached (individual patches so that they may be more easily
 reviewed by a developer)

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13504>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list