[mythtv-commits] Ticket #13432: mythtv-setup - second run of channel scan results in duplicate channels

[MythTV]

#13432: mythtv-setup - second run of channel scan results in duplicate channels
--------------------------------------+-------------------------------
 Reporter:  Mike Bibbings             |          Owner:  Klaas de Waal
     Type:  Bug Report - General      |         Status:  closed
 Priority:  minor                     |      Milestone:  needs_triage
Component:  MythTV - Channel Scanner  |        Version:  Master Head
 Severity:  medium                    |     Resolution:  fixed
 Keywords:                            |  Ticket locked:  0
--------------------------------------+-------------------------------

Comment (by Mike Bibbings):

 Replying to [comment:5 Klaas de Waal <kdewaal@…>]:
 > In [changeset:"b8141c84cba8fe95c85cd446acd6bf2f2e31d1e9/mythtv"
 b8141c84cb/mythtv]:
 > {{{
 > #!CommitTicketReference repository="mythtv"
 revision="b8141c84cba8fe95c85cd446acd6bf2f2e31d1e9"
 > Existing multiplexes not recognized with new DVB-T2 "Full Scan".
 >
 > Doing a "Full Scan" with mythtv-setup for the first time the
 > channels are added and have the correct channel number.
 > The second run of "Full Scan" finds the same channels again
 > but sees them as new channels and they get the service ID number
 > because the correct channel number is already in use.
 > The third run gives conflicts on insertion because both
 > the correct channelnumber and the service id are already in use.
 >
 > This problem is caused by the implementation of the
 > preliminary DVB-T2 support that has been added some time ago.
 > This creates some confusion whether a multiplex uses
 > the DVB-T or the DVB-T2 modulation system.
 > The strict comparison on the modulation system in
 > DTVMultiplex::IsEqual even for the "fuzzy" type  of
 > comparison makes that a new multiplex is not recognized
 > as already existing.
 >
 > The solution for now is to treat the DVB-T and DVB-T modulation
 > systems as compatible when the "fuzzy" type of comparison is done.
 >
 > Tickets #13014 and #12638 will comprise a more complete
 > implementation of DVB-T2 support.
 >
 > Fixes #13432
 > }}}

 Confirmed as fixed for DVB-T/T2 capable tuner, not fixed for DVB-T only
 tuner.

 I note that dtv_multiplex mod_sys is set to UNDEFINED, rather than DVB-T.
 For a DVB-T/T2 capable tuner mod_sys is set to either DVB-T or DVB-T2 as
 appropriate


 Attachments:

 dvb-t-scans-mythtv-setup.20190322103440.5235.log.tar.bz2

 dvb-t-scans-results.txt

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13432#comment:7>
MythTV <http://www.mythtv.org>
MythTV Media Center