[mythtv-commits] [MythTV/mythtv] 3054aa: Android: Fix MediaCodec pause frame when direct re...

[Mark Kendall]

  Branch: refs/heads/devel/2019-render
  Home:   https://github.com/MythTV/mythtv
  Commit: 3054aadb66bb32588e3d590ba98fb2971d6585a0
      https://github.com/MythTV/mythtv/commit/3054aadb66bb32588e3d590ba98fb2971d6585a0
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mythmediacodecinterop.cpp
    M mythtv/libs/libmythtv/mythopenglinterop.cpp

  Log Message:
  -----------
  Android: Fix MediaCodec pause frame when direct rendering


  Commit: 096e347f1623b58727dec964bb2a0917ffeccc4c
      https://github.com/MythTV/mythtv/commit/096e347f1623b58727dec964bb2a0917ffeccc4c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/videoout_opengl.cpp
    M mythtv/libs/libmythtv/videoout_opengl.h

  Log Message:
  -----------
  VideoOutputOpenGL: Remove DiscardVideoFrames override

- looks like it is unnecessary


  Commit: 47df3efb5627525ec385be47ca7f2978aca259ff
      https://github.com/MythTV/mythtv/commit/47df3efb5627525ec385be47ca7f2978aca259ff
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/DVD/avformatdecoderdvd.cpp
    M mythtv/libs/libmythtv/DVD/avformatdecoderdvd.h
    M mythtv/libs/libmythtv/avformatdecoder.cpp
    M mythtv/libs/libmythtv/avformatdecoder.h
    M mythtv/libs/libmythtv/decoderbase.cpp
    M mythtv/libs/libmythtv/decoderbase.h
    M mythtv/libs/libmythtv/dummydecoder.h
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/nuppeldecoder.cpp
    M mythtv/libs/libmythtv/nuppeldecoder.h

  Log Message:
  -----------
  MythPlayer: Refactor handling of EAGAIN when decoding video

- mediacodec direct rendering was stalling/deadlocking/failing in
numerous places as the decoder thread would get stuck continually
retrying for the next video frame when the underlying decoder is waiting
for a new bufer to render to.
- we cannot safely signal to the decoder thread that it needs to stop
retrying as we cannot guarantee getting a lock on the decoder.
- instead, move responsibility for handling EAGAIN into mythplayer,
which can try again if necessary or abort if the player is trying to
pause or exit.
- no obvious problems in testing...


  Commit: a599277b484382e9f19decaba4ac26ed6d6f58ca
      https://github.com/MythTV/mythtv/commit/a599277b484382e9f19decaba4ac26ed6d6f58ca
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-03-11 (Mon, 11 Mar 2019)

  Changed paths:
    M mythtv/libs/libmythtv/openglvideo.cpp
    M mythtv/libs/libmythui/mythrender_opengl.cpp
    M mythtv/libs/libmythui/mythrender_opengl.h
    M mythtv/programs/mythfrontend/globalsettings.cpp

  Log Message:
  -----------
  MythRenderOpenGL: Remove framebuffer discard support

- this is not working as intended and further digging suggests it is not
appropriate for our prospective use case


Compare: https://github.com/MythTV/mythtv/compare/7cd4c24580e4...a599277b4843