[mythtv-commits] Ticket #13292: LiveTV Channel Switching - DVB-T/T2 UK Freeview

[MythTV]

#13292: LiveTV Channel Switching - DVB-T/T2 UK Freeview
----------------------------------+-------------------------------
 Reporter:  Mike Bibbings         |          Owner:  Peter Bennett
     Type:  Bug Report - General  |         Status:  assigned
 Priority:  minor                 |      Milestone:  needs_triage
Component:  MythTV - DVB          |        Version:  Master Head
 Severity:  medium                |     Resolution:
 Keywords:                        |  Ticket locked:  0
----------------------------------+-------------------------------

Comment (by Peter Bennett):

 By always returning 1 from the FAIL macro, the patch means that the
 function has_codec_parameters always returns true. In that case the
 has_codec_parameters function as well as the loop from where it is called,
 will have no effect and could be removed.

 It looks like the loop is designed to pause for 50 ms if the data is not
 ready for live tv.

 Is that loop really unnecessary? It seems that the worst it can do is
 cause a fraction of a second delay, while removing it could cause playback
 to fail if the data is not really there when needed.

 Am I understanding this correctly? Do you have any insight on why this
 fixes the problem?

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13292#comment:11>
MythTV <http://www.mythtv.org>
MythTV Media Center