[mythtv-commits] [MythTV/mythtv] babfe2: VideoOutput: Start cleaning up VideoOutput (base)

[Mark Kendall]

  Branch: refs/heads/devel/2019-render
  Home:   https://github.com/MythTV/mythtv
  Commit: babfe21a62a055603586b7831f45263091310b06
      https://github.com/MythTV/mythtv/commit/babfe21a62a055603586b7831f45263091310b06
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-06-18 (Tue, 18 Jun 2019)

  Changed paths:
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videodisplayprofile.cpp
    M mythtv/libs/libmythtv/videoout_d3d.h
    M mythtv/libs/libmythtv/videoout_opengl.h
    M mythtv/libs/libmythtv/videooutbase.cpp
    M mythtv/libs/libmythtv/videooutbase.h

  Log Message:
  -----------
  VideoOutput: Start cleaning up VideoOutput (base)


  Commit: a40ba669357c2cbf9f9a0199c7603c58389a903b
      https://github.com/MythTV/mythtv/commit/a40ba669357c2cbf9f9a0199c7603c58389a903b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-06-18 (Tue, 18 Jun 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/videoout_d3d.cpp
    M mythtv/libs/libmythtv/videoout_d3d.h
    M mythtv/libs/libmythtv/videoout_null.cpp
    M mythtv/libs/libmythtv/videoout_null.h
    M mythtv/libs/libmythtv/videoout_opengl.cpp
    M mythtv/libs/libmythtv/videoout_opengl.h
    M mythtv/libs/libmythtv/videooutbase.cpp
    M mythtv/libs/libmythtv/videooutbase.h

  Log Message:
  -----------
  VideoOutput: More cleanup - mostly member var naming


  Commit: 6311342227334398d39d52ed9c43da0c73b3f86c
      https://github.com/MythTV/mythtv/commit/6311342227334398d39d52ed9c43da0c73b3f86c
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-06-18 (Tue, 18 Jun 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mythplayer.cpp
    M mythtv/libs/libmythtv/mythplayer.h
    M mythtv/libs/libmythtv/tv_play.cpp
    M mythtv/libs/libmythtv/videooutbase.h

  Log Message:
  -----------
  VideoOutput: Remove GetScreenShot

- now that we use OpenGL exclusively, Qt will grab the fullscreen
framebuffer for all output types - hardware decoders included.


  Commit: fe58d5ae521b4256bbb9b4b2e61d28a94d894847
      https://github.com/MythTV/mythtv/commit/fe58d5ae521b4256bbb9b4b2e61d28a94d894847
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-06-20 (Thu, 20 Jun 2019)

  Changed paths:
    M mythtv/libs/libmythtv/videobuffers.cpp
    M mythtv/libs/libmythtv/videooutbase.cpp

  Log Message:
  -----------
  VideoOutput: Use VideoDispDim for display profile input

- i.e. use 1080 and not 1088


  Commit: 2fb173e64c825f095d325ee7294595153bc9a48b
      https://github.com/MythTV/mythtv/commit/2fb173e64c825f095d325ee7294595153bc9a48b
  Author: Mark Kendall <mark.kendall at gmail.com>
  Date:   2019-06-20 (Thu, 20 Jun 2019)

  Changed paths:
    M mythtv/libs/libmythtv/mythvaapicontext.cpp
    M mythtv/libs/libmythtv/mythvaapicontext.h

  Log Message:
  -----------
  VAAPI: Fix scaling of 1088 video when using copyback

- round 387 of the VAAPI merry-go-round
- 1088 video was displaying the garbage line at the bottom of the screen
when using copy-back
- we need to create the VAAPI frames context with the coded_height of
the source material so that full 1088 frames are returned - with the
VideoOutput class just ignoring the garbage. If 1080 is used, the driver
appears to scale the 1088 frame into a 1080 frame when copying back to
main memory.
- requires a reversion back to initialising the decoder in GetFormat as
the coded_height is not available/ready in HwDecoderInit
- re-introduces the problem of multiple calls to InitialiseContext2 when
using copyback for some VP8 files - but this appears to be harmless, if
annoying.
- using the coded_height also fixes the previous problems seen with some
files when InitialiseContext2 was called from GetFormat2


Compare: https://github.com/MythTV/mythtv/compare/979209698650...2fb173e64c82