[mythtv-commits] Ticket #13473: Get RecGroupIDs from the DB instead of hard-coding them in an enum

MythTV noreply at mythtv.org
Wed Jul 31 20:10:21 UTC 2019


#13473: Get RecGroupIDs from the DB instead of hard-coding them in an enum
------------------------------+-------------------------------
 Reporter:  mdabbs            |          Owner:  Peter Bennett
     Type:  Patch - Feature   |         Status:  assigned
 Priority:  minor             |      Milestone:  needs_triage
Component:  MythTV - General  |        Version:  v30-fixes
 Severity:  medium            |     Resolution:
 Keywords:  RecGroupID        |  Ticket locked:  0
------------------------------+-------------------------------

Comment (by Peter Bennett):

 My feelings on this

 - It likely affects very few users.
 - The proposed change adds database accesses.
 - It is possible that some users have decided to update the database and
 change the name of their default group to something else. The proposed
 change would clobber them.

 I recommend a simple change rather in dbcheck.cpp to insert the special
 groups with the correct ids in the first place, regardless to the auto
 increment value. This should have been done at the start and this problem
 would never have happened.

 For those who already have the wrong values, run this:
 {{{
 update recgroups set recgroupid = 1 where recgroup = 'Default';
 update recorded set recgroupid = 1 where recgroup = 'Default';
 }}}
 Repeat for the other two special group names.

-- 
Ticket URL: <https://code.mythtv.org/trac/ticket/13473#comment:4>
MythTV <http://www.mythtv.org>
MythTV Media Center


More information about the mythtv-commits mailing list