[mythtv-commits] Ticket #13386: No Signal/Noise and Signal Strength with MyGica T230 DVB tuner
MythTV
noreply at mythtv.org
Mon Jan 28 12:57:17 UTC 2019
#13386: No Signal/Noise and Signal Strength with MyGica T230 DVB tuner
-------------------------------+--------------------------------
Reporter: Klaas de Waal | Owner: (none)
Type: Patch - Bug Fix | Status: infoneeded_new
Priority: minor | Milestone: 30.1
Component: MythTV - DVB | Version: Master Head
Severity: medium | Resolution:
Keywords: DVBv5 channelscan | Ticket locked: 0
-------------------------------+--------------------------------
Comment (by Klaas de Waal):
Hi Stuart,\\
There is no timeout value change in the patch. However, there is a fix in
the function wait_for_backend where a timeout value in milliseconds is
converted to seconds and microseconds. I assume that is what you refer
to.\\
This is the part of the patch:
{{{
@@ -1494,7 +1499,8 @@ static void drain_dvb_events(int fd)
*/
static bool wait_for_backend(int fd, int timeout_ms)
{
- struct timeval select_timeout = { 0, (timeout_ms % 1000) * 1000
/*usec*/};
+ struct timeval select_timeout = { timeout_ms / 1000, (timeout_ms %
1000) * 1000 /*usec*/};
+
fd_set fd_select_set;
FD_ZERO( &fd_select_set);
FD_SET (fd, &fd_select_set);
}}}
In the original code the number of seconds is set to zero. This means the
function will not work correct for timeout values of 1 second or more.\\
This is not yet a problem because the function is currently only being
called with a timeout value of 50 milliseconds but nevertheless it is
wrong and it could give surprises if the timeout value is ever changed.\\
I can make a separate ticket for this if that is appreciated.\\
Regards, Klaas.
--
Ticket URL: <https://code.mythtv.org/trac/ticket/13386#comment:2>
MythTV <http://www.mythtv.org>
MythTV Media Center
More information about the mythtv-commits
mailing list